From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=203.18.50.4; helo=nat-hk.nvidia.com; envelope-from=ashishsingha@nvidia.com; receiver=edk2-devel@lists.01.org Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 01010211AEA73 for ; Wed, 9 Jan 2019 17:18:58 -0800 (PST) Received: from hkpgpgate101.nvidia.com (Not Verified[10.18.92.77]) by nat-hk.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 10 Jan 2019 09:18:56 +0800 Received: from HKMAIL101.nvidia.com ([10.18.16.10]) by hkpgpgate101.nvidia.com (PGP Universal service); Wed, 09 Jan 2019 17:18:56 -0800 X-PGP-Universal: processed; by hkpgpgate101.nvidia.com on Wed, 09 Jan 2019 17:18:56 -0800 Received: from DRBGMAIL102.nvidia.com (10.18.16.21) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 10 Jan 2019 01:18:55 +0000 Received: from HKMAIL102.nvidia.com (10.18.16.11) by DRBGMAIL102.nvidia.com (10.18.16.21) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 10 Jan 2019 01:18:54 +0000 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.58) by HKMAIL102.nvidia.com (10.18.16.11) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Thu, 10 Jan 2019 01:18:53 +0000 Received: from BYAPR12MB2743.namprd12.prod.outlook.com (20.177.125.220) by BYAPR12MB3304.namprd12.prod.outlook.com (20.179.93.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1516.15; Thu, 10 Jan 2019 01:18:50 +0000 Received: from BYAPR12MB2743.namprd12.prod.outlook.com ([fe80::d51a:3dbb:3b90:178b]) by BYAPR12MB2743.namprd12.prod.outlook.com ([fe80::d51a:3dbb:3b90:178b%5]) with mapi id 15.20.1495.011; Thu, 10 Jan 2019 01:18:50 +0000 From: Ashish Singhal To: "Kinney, Michael D" , "edk2-devel@lists.01.org" CC: "Gao, Liming" , "Fu, Siyuan" , "Wu, Jiaxin" Thread-Topic: [PATCH v4 0/2] Provide UEFILib functions for protocol uninstallation Thread-Index: AQHUqF4gwIjNzS3FxUyzKNqwGG70X6Wnra6AgAAFrHA= Date: Thu, 10 Jan 2019 01:18:50 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Enabled=True; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SiteId=43083d15-7273-40c1-b7db-39efd9ccc17a; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Owner=ashishsingha@nvidia.com; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SetDate=2019-01-10T01:18:48.8399353Z; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Name=Unrestricted; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Application=Microsoft Azure Information Protection; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Extended_MSFT_Method=Automatic; Sensitivity=Unrestricted authentication-results: spf=none (sender IP is ) smtp.mailfrom=ashishsingha@nvidia.com; x-originating-ip: [8.46.90.104] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BYAPR12MB3304; 6:aa9Wp7Alb168YGmZqkA43lYgznJ20g1Bzl1avHXDmSIC7eC0jH02pgn6ZYjdVsbS1sGPhSKmqpsTLvCsN9eYPdKU1g20YPkY9sPAYuWHPsHOuA/K74XwqQdRmacdfSCoNTvt8XFg+HOWh0LNxn65NOCkP8vyMm5Td/501tuf4I5LfIyHOY5j8VaHac9Qi8orHGsymn0J/sFNhhOmBC0JZOy3dEmBDUgaMfERvRc7uVp8J6SN8tmKbl7nTZIzFHZwjzHmI1x6WiB+yytH/IzjWn/T+tvEVwIGe1wZZf1kweTVPWTy6tvDAvdBrdx35iQ52h8o3dTkraXv8Wf+dE21ZEdlT1H//Z+AVDxD7J/eJ5H6MtMzuXRINIK3d10ReqzAXYncocyGC7+6wzLDFvX0fNKwYofDef9oWLr681QxdfXrzZZT6ohktqSiYpp/OScVPfgzshz6qNMv8xq6/lee2A==; 5:Jp2p57kOlJcokppf9N/b/gDb3JFCMXnZV2YJqqsUlaEuJ0SrbfuxlJ7x2X5ry1M3RO9TqB2zi7xwu3GQkuSmVxomEYRIMuIkEI/cwJaW8qD0SufZ6rIdbtTD/qV7klhOpVmiV/+aVeKWdo2C1j3lYVwtYWIk7C/VVxXLJZ7/ngu4Xi1o6JXO/+mH4XFBNm5jfrFHPbKmklj6H2VBWo1Dig==; 7:Nae63iT2oDx3mpWT2V0XPGflQJIDZo8TrCZ2g6bpITcRf1+Ouk6zt8m/ePUa3ExVC0UwXimAy1Q8dP7o6yO1iZZ4N/OC2xNvzx2M5bE1d3ctI5STr/x5Wr7gp9C0rn+5bPILL8E83eMYx5W8byGdbQ== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: cbbdfd25-10e7-4a50-735a-08d67699941f x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(2017052603328)(7153060)(7193020); SRVR:BYAPR12MB3304; x-ms-traffictypediagnostic: BYAPR12MB3304: x-microsoft-antispam-prvs: x-forefront-prvs: 0913EA1D60 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(39860400002)(346002)(376002)(396003)(136003)(199004)(189003)(13464003)(43544003)(86362001)(3846002)(6116002)(7736002)(68736007)(71200400001)(71190400001)(97736004)(74316002)(305945005)(5660300001)(8936002)(81166006)(186003)(8676002)(81156014)(476003)(11346002)(446003)(105586002)(106356001)(7696005)(2501003)(6506007)(53546011)(102836004)(26005)(76176011)(6246003)(2906002)(53936002)(14454004)(486006)(4326008)(54906003)(25786009)(110136005)(256004)(14444005)(66066001)(99286004)(316002)(9686003)(229853002)(6436002)(33656002)(55016002)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR12MB3304; H:BYAPR12MB2743.namprd12.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nvidia.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 4qX3SRTaIObcxQalcY0KKs19mbMFJyNSlvbMFZTc1Qz33aHoaxS6PiLX9WkWqoC1N3LPgVolxBqKvHNl6PpKneAqXqSJMDFMJCF/d76B/Xh+caZFrM9PMO8kKOfM4KDHGGoMPZEKcZs4NAd0WpSOlsXOZJYIndiNvv1PzQ0kj+3XoLt7N6ExgAsNjZ3xkeBJFrOos5/jtFBCqKCCMkwwNLXrScgB6F/KGkl4Khu+GFkaKAaah/TUAzlGAsxhmHujrA0jbm0uv01ttR1VmAdLOpr1cXhjXPdK3Jss3l1ACvZg+hgcU2g8v/zHSEjVnwRa spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: cbbdfd25-10e7-4a50-735a-08d67699941f X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2019 01:18:50.4445 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3304 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1547083136; bh=6SknkRM2V4wSzDQtsknqZpCDahPLDqNpDMwrriBSAzo=; h=X-PGP-Universal:From:To:CC:Subject:Thread-Topic:Thread-Index:Date: Message-ID:References:In-Reply-To:Accept-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:msip_labels:authentication-results: x-originating-ip:x-ms-publictraffictype: x-microsoft-exchange-diagnostics: x-ms-exchange-antispam-srfa-diagnostics: x-ms-office365-filtering-correlation-id:x-microsoft-antispam: x-ms-traffictypediagnostic:x-microsoft-antispam-prvs: x-forefront-prvs:x-forefront-antispam-report:received-spf: x-ms-exchange-senderadcheck:x-microsoft-antispam-message-info: spamdiagnosticoutput:spamdiagnosticmetadata:MIME-Version: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg: Content-Language:Content-Type:Content-Transfer-Encoding; b=LaEHbZ5v09xSkG8HbVguMRb7UUbP6jnopvaeUqTmWHDANCBBk37509bAqvAc8jRY9 HE0q6qfQiAssH/DdjsB57cxul779WY1yFT7xkTFRXx6FmsCKmWRGlgdTFD7YDh9bCx +nRgeqqIu//pzTBV2cRMXZhXjiRzLlyn4Nj4OulNCDDHB3nfkGbRXIcd2aTHG0moYu rH9mH0y2x/j7CEvCtDyevTwZRINeqbjF7DxadUxUtwEH4hiz0eWMfdctY4SaGSxC9M dRUG1Hhyn5mr9UjykGDu/cc7+Hfsg3hUcrGOVImfN+LXKUFU2imiopMmKmCQcm4EoM 5rO1DpUJrt/9w== Subject: Re: [PATCH v4 0/2] Provide UEFILib functions for protocol uninstallation X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jan 2019 01:18:59 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Mike. Hope to see the patches merged soon. Please let me know if y= ou want me to file the BZ. Hi Liming, Please let me know if you need me to take care of anything in the patch b= efore you push it. Hi Siyuan/Jiaxin, I think you reviewed the changes in PATCH v2 which is same as in PATCH v4= . Please let me know if you have any issues with this going in. Thanks Ashish -----Original Message----- From: Kinney, Michael D =20 Sent: Wednesday, January 9, 2019 5:56 PM To: Ashish Singhal ; edk2-devel@lists.01.org; Ki= nney, Michael D Cc: Gao, Liming ; Fu, Siyuan ;= =20Wu, Jiaxin Subject: RE: [PATCH v4 0/2] Provide UEFILib functions for protocol uninst= allation Hi Ashish, This V4 version of the patch produces the expected size results for platf= orm and driver builds. There are some very minor issues with some extra carriage returns, but th= ose can be handled by Liming when the patch series is committed. I may be good to have an additional BZ to use these new APIs from all UEF= I Driver Model drivers that have failure paths in their entry point or su= pport the unload feature. Those updates can be done later. Thanks, Mike > -----Original Message----- > From: Ashish Singhal [mailto:ashishsingha@nvidia.com] > Sent: Wednesday, January 9, 2019 12:59 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming=20 > ; Fu, Siyuan ; Wu, Jiaxin=20 > ; Ashish Singhal > Subject: [PATCH v4 0/2] Provide UEFILib functions for protocol=20 > uninstallation >=20 > An issue was seen in IScsiDxe in NetworkPkg where driver cleanup after = > initialization failure was not done right. Bug 1428 was filed in this=20 > regard. > As per discussions with Mike, it was also discussed that having=20 > UEFILib provide protocol uninstallation abstraction would help to=20 > avoid these issues in the future. Bug 1429 was found to track this. > These 2 patches > take care of this. >=20 >=20 > Ashish Singhal (2): > MdePkg/UefiLib: Abstract driver model protocol uninstallation > NetworkPkg/IScsiDxe: Use UEFILib APIs to uninstall protocols. >=20 > MdePkg/Include/Library/UefiLib.h | 103 ++++ > MdePkg/Library/UefiLib/UefiDriverModel.c | 972 > ++++++++++++++++++++++++++++++- > NetworkPkg/IScsiDxe/IScsiDriver.c | 31 +- > 3 files changed, 1085 insertions(+), 21 deletions(-) >=20 > -- > 2.7.4 -------------------------------------------------------------------------= ---------- This email message is for the sole use of the intended recipient(s) and m= ay contain confidential information. Any unauthorized review, use, disclosure or di= stribution is prohibited. If you are not the intended recipient, please contact the= =20sender by reply email and destroy all copies of the original message. -------------------------------------------------------------------------= ----------