From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=203.18.50.4; helo=nat-hk.nvidia.com; envelope-from=ashishsingha@nvidia.com; receiver=edk2-devel@lists.01.org Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 08F852119FF5E for ; Thu, 10 Jan 2019 07:33:27 -0800 (PST) Received: from hkpgpgate102.nvidia.com (Not Verified[10.18.92.9]) by nat-hk.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 10 Jan 2019 23:33:25 +0800 Received: from HKMAIL104.nvidia.com ([10.18.16.13]) by hkpgpgate102.nvidia.com (PGP Universal service); Thu, 10 Jan 2019 07:33:24 -0800 X-PGP-Universal: processed; by hkpgpgate102.nvidia.com on Thu, 10 Jan 2019 07:33:24 -0800 Received: from DRBGMAIL102.nvidia.com (10.18.16.21) by HKMAIL104.nvidia.com (10.18.16.13) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 10 Jan 2019 15:33:22 +0000 Received: from HKMAIL102.nvidia.com (10.18.16.11) by DRBGMAIL102.nvidia.com (10.18.16.21) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 10 Jan 2019 15:33:20 +0000 Received: from NAM05-DM3-obe.outbound.protection.outlook.com (104.47.49.50) by HKMAIL102.nvidia.com (10.18.16.11) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Thu, 10 Jan 2019 15:33:20 +0000 Received: from BYAPR12MB2743.namprd12.prod.outlook.com (20.177.125.220) by BYAPR12MB3621.namprd12.prod.outlook.com (20.178.54.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1516.14; Thu, 10 Jan 2019 15:33:17 +0000 Received: from BYAPR12MB2743.namprd12.prod.outlook.com ([fe80::d51a:3dbb:3b90:178b]) by BYAPR12MB2743.namprd12.prod.outlook.com ([fe80::d51a:3dbb:3b90:178b%5]) with mapi id 15.20.1495.011; Thu, 10 Jan 2019 15:33:17 +0000 From: Ashish Singhal To: "Gao, Liming" , "Kinney, Michael D" , "edk2-devel@lists.01.org" CC: "Fu, Siyuan" , "Wu, Jiaxin" Thread-Topic: [PATCH v4 0/2] Provide UEFILib functions for protocol uninstallation Thread-Index: AQHUqF4gwIjNzS3FxUyzKNqwGG70X6Wnra6AgAAFrHCAAOyLAIAAAnOQ Date: Thu, 10 Jan 2019 15:33:17 +0000 Message-ID: References: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3AF073@SHSMSX152.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3AF073@SHSMSX152.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Enabled=True; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SiteId=43083d15-7273-40c1-b7db-39efd9ccc17a; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Owner=ashishsingha@nvidia.com; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SetDate=2019-01-10T15:33:15.4149273Z; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Name=Unrestricted; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Application=Microsoft Azure Information Protection; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Extended_MSFT_Method=Automatic; Sensitivity=Unrestricted authentication-results: spf=none (sender IP is ) smtp.mailfrom=ashishsingha@nvidia.com; x-originating-ip: [216.228.112.21] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BYAPR12MB3621; 6:m457xawOX2BagHBTUjHa8/7R9MYmW2rr/y0RJBZfH/678kSks498VQ9TZHI7suvwCY7uAcSOxAAGWUdIlNbwICC9zsNgfvzxnOrL2hfsx1q5dD/l8+fY/9OresDyGayOvDDqjZHZZsk8jzs/lHD5wh2TFAOi06z8Xi8oSZieo7VtOykW5A/muTIvOXljeqonZTOxDogBQB/tK6wYj9S0MuUOE4ByQbe0DwwbVuTsCwEPc75g1Z3bAsZYzOdTZcilL5vasM2fAMVKWyXS+d6Spth+X2eXaWTxbo6g1Xb8xSLfklDOZk7xmuhEO4CgUGJJW9zdc3/aB93piTC1vKNttXDIfplCRj8abcti7n/wc3xeGv9ZZ96VHqECRP/vBvexmxeiKnm3QWV+LKLZJ8Kx8HhlymUHquMkmW6Jm/YODLw3pninxqSy2nBResFfCj5mvttwthhl1l7zwXCqAygo+A==; 5:uyEaoH+SfsAHusVO6uO3EXTSx83nQagorHGoxa4HlXtGdIzGHIbd7TfzRZRvjzefj+wsmbirL7V5Lj29eCL/VZ1IC8OwcaOYEuAfWuuyFsZRnZQ1JkFoIAa8KfWr5J3ueOOqcyFiC+l6/WaHnGUi7SxasFKJmVAhdysSKIxTPOSki6z2/bhYTAb9Erw7Y7r8dOsPerDNIJ7kHHVAsO7+iQ==; 7:HQKgeWHpIrcUc/XJBkvnNfYR+3nEHE7jXrZKgvOThOFGmQh5xZBQgIH98HLFkdDnBj6w7xZ9vItNVmmxESvIfdLwuFnfHcYxM8/hKtDoNcrl6MM2q88h8C1ALex8GaPQ6qliFxxicMrKYEf1VLtiew== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 032429a8-7e05-4327-8a86-08d67710f183 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(2017052603328)(7153060)(7193020); SRVR:BYAPR12MB3621; x-ms-traffictypediagnostic: BYAPR12MB3621: x-microsoft-antispam-prvs: x-forefront-prvs: 0913EA1D60 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(376002)(136003)(366004)(346002)(13464003)(43544003)(199004)(189003)(93886005)(81166006)(68736007)(478600001)(6116002)(110136005)(6246003)(14454004)(6436002)(81156014)(55016002)(74316002)(966005)(54906003)(53936002)(86362001)(6306002)(106356001)(5660300001)(316002)(66066001)(476003)(33656002)(105586002)(2501003)(3846002)(7696005)(97736004)(486006)(99286004)(305945005)(256004)(2906002)(446003)(53546011)(6506007)(8676002)(11346002)(102836004)(26005)(76176011)(186003)(71190400001)(71200400001)(8936002)(229853002)(7736002)(9686003)(14444005)(4326008)(25786009); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR12MB3621; H:BYAPR12MB2743.namprd12.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nvidia.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: NafcM5Y/gDkDQCUtit005xs9G0X5FdY/oNPge2uyRYdBbQSW4SiKbs4vgEyhgQT78Y/cRXg02z9rByc50skYivXkcXf+JZ1XtOaVT3+pK2oMutdHKHDxyAlE5HhvTGI/jrdUkzwwKR+oD7jObyAmDezIByoz61HseORjEKf6usbYxIu9PrF3JKi+wiQSKjnN6j9HM8gSHszPPI2/QExGbTAoNUTejnGlKSM/r368XNw6U3xUlFo6YGmUmKCnB8ExaFlrHmFg4gdZRdosZmos4MxspGnQRluPqZOqXdoTPYAHlJ9shy36HWnAasFFwmWk spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 032429a8-7e05-4327-8a86-08d67710f183 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2019 15:33:17.3354 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3621 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1547134405; bh=FCtO4aBP+MlQaEPJZI4tDzM067M0k55lQyHf8ljtqpk=; h=X-PGP-Universal:From:To:CC:Subject:Thread-Topic:Thread-Index:Date: Message-ID:References:In-Reply-To:Accept-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:msip_labels:authentication-results: x-originating-ip:x-ms-publictraffictype: x-microsoft-exchange-diagnostics: x-ms-exchange-antispam-srfa-diagnostics: x-ms-office365-filtering-correlation-id:x-microsoft-antispam: x-ms-traffictypediagnostic:x-microsoft-antispam-prvs: x-forefront-prvs:x-forefront-antispam-report:received-spf: x-ms-exchange-senderadcheck:x-microsoft-antispam-message-info: spamdiagnosticoutput:spamdiagnosticmetadata:MIME-Version: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg: Content-Language:Content-Type:Content-Transfer-Encoding; b=hFSsmjtp7j8F9jESwj4dIhrrt0GDKWNCb5ibZyOquhfWj6DszcKIzOs9+S49J7els 7BrFxUKCcI3VPpiIBd0GBpa0RDCD6DiPJcWQtuZr4YNfpKCirNcnxy8dBNTlDCuY8X Su6+/tqk2y9IAP/9yUm6vtx576vrP9hDY6ydKWwGc0pFU4IqokUs2Ji8nl9ZpF0xGj My478+M5l36K5keXgt0QkGm6rqkvFIi+rEDU/nRS820vw9V/5U01NvbLfuL6UU5BYE NA0zbFSebQRoAx7+YX2nRExx6tDMGjr3aEyj+pHOWZ96vjS04HROr4/5a8+AQnBody NwB4fpyb263fg== Subject: Re: [PATCH v4 0/2] Provide UEFILib functions for protocol uninstallation X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jan 2019 15:33:29 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Liming. I have files BZ: https://bugzilla.tianocore.org/show_bug.cgi= ?id=3D1444 to update UEFI drivers to use new APIs. I have not assigned it t= o anyone as there are many drivers across packages that need to be looked a= t. I would try to fix the ones I hit an issue with. Over the weekend Siyuan approved the patch from PATCH v2 which is exactly s= ame as in PATCH v4. Thanks Ashish -----Original Message----- From: Gao, Liming =20 Sent: Thursday, January 10, 2019 8:23 AM To: Ashish Singhal ; Kinney, Michael D ; edk2-devel@lists.01.org Cc: Fu, Siyuan ; Wu, Jiaxin Subject: RE: [PATCH v4 0/2] Provide UEFILib functions for protocol uninstal= lation Ashish: The MdePkg change is good to me. Reviewed-by: Liming Gao Please help submit another BZ to update UefiDriver to uninstall protocol = when failure with new APIs.=20 =20 If Siyuan/Jiaxin has no other comments, I will help push this patch set.= =20 Thanks Liming > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of=20 > Ashish Singhal > Sent: Thursday, January 10, 2019 9:19 AM > To: Kinney, Michael D ;=20 > edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Wu, Jiaxin=20 > ; Gao, Liming > Subject: Re: [edk2] [PATCH v4 0/2] Provide UEFILib functions for=20 > protocol uninstallation >=20 > Thanks Mike. Hope to see the patches merged soon. Please let me know if y= ou want me to file the BZ. >=20 > Hi Liming, >=20 > Please let me know if you need me to take care of anything in the patch b= efore you push it. >=20 > Hi Siyuan/Jiaxin, >=20 > I think you reviewed the changes in PATCH v2 which is same as in PATCH v4= . Please let me know if you have any issues with this going in. >=20 > Thanks > Ashish >=20 > -----Original Message----- > From: Kinney, Michael D > Sent: Wednesday, January 9, 2019 5:56 PM > To: Ashish Singhal ; edk2-devel@lists.01.org;=20 > Kinney, Michael D > Cc: Gao, Liming ; Fu, Siyuan=20 > ; Wu, Jiaxin > Subject: RE: [PATCH v4 0/2] Provide UEFILib functions for protocol=20 > uninstallation >=20 > Hi Ashish, >=20 > This V4 version of the patch produces the expected size results for platf= orm and driver builds. >=20 > There are some very minor issues with some extra carriage returns, but=20 > those can be handled by Liming when the patch series is committed. >=20 > I may be good to have an additional BZ to use these new APIs from all=20 > UEFI Driver Model drivers that have failure paths in their entry point or= support the unload feature. > Those updates can be done later. >=20 > Thanks, >=20 > Mike >=20 > > -----Original Message----- > > From: Ashish Singhal [mailto:ashishsingha@nvidia.com] > > Sent: Wednesday, January 9, 2019 12:59 PM > > To: edk2-devel@lists.01.org > > Cc: Kinney, Michael D ; Gao, Liming=20 > > ; Fu, Siyuan ; Wu, Jiaxin=20 > > ; Ashish Singhal > > Subject: [PATCH v4 0/2] Provide UEFILib functions for protocol=20 > > uninstallation > > > > An issue was seen in IScsiDxe in NetworkPkg where driver cleanup=20 > > after initialization failure was not done right. Bug 1428 was filed=20 > > in this regard. > > As per discussions with Mike, it was also discussed that having=20 > > UEFILib provide protocol uninstallation abstraction would help to=20 > > avoid these issues in the future. Bug 1429 was found to track this. > > These 2 patches > > take care of this. > > > > > > Ashish Singhal (2): > > MdePkg/UefiLib: Abstract driver model protocol uninstallation > > NetworkPkg/IScsiDxe: Use UEFILib APIs to uninstall protocols. > > > > MdePkg/Include/Library/UefiLib.h | 103 ++++ > > MdePkg/Library/UefiLib/UefiDriverModel.c | 972 > > ++++++++++++++++++++++++++++++- > > NetworkPkg/IScsiDxe/IScsiDriver.c | 31 +- > > 3 files changed, 1085 insertions(+), 21 deletions(-) > > > > -- > > 2.7.4 >=20 > ---------------------------------------------------------------------- > ------------- This email message is for the sole use of the intended=20 > recipient(s) and may contain confidential information. Any=20 > unauthorized review, use, disclosure or distribution is prohibited. =20 > If you are not the intended recipient, please contact the sender by=20 > reply email and destroy all copies of the original message. > ---------------------------------------------------------------------- > ------------- _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel