From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=203.18.50.4; helo=nat-hk.nvidia.com; envelope-from=ashishsingha@nvidia.com; receiver=edk2-devel@lists.01.org Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 82E41211ADA2D for ; Thu, 10 Jan 2019 07:40:37 -0800 (PST) Received: from hkpgpgate101.nvidia.com (Not Verified[10.18.92.9]) by nat-hk.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 10 Jan 2019 23:40:35 +0800 Received: from HKMAIL101.nvidia.com ([10.18.16.10]) by hkpgpgate101.nvidia.com (PGP Universal service); Thu, 10 Jan 2019 07:40:35 -0800 X-PGP-Universal: processed; by hkpgpgate101.nvidia.com on Thu, 10 Jan 2019 07:40:35 -0800 Received: from HKMAIL104.nvidia.com (10.18.16.13) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 10 Jan 2019 15:40:33 +0000 Received: from NAM03-BY2-obe.outbound.protection.outlook.com (104.47.42.51) by HKMAIL104.nvidia.com (10.18.16.13) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Thu, 10 Jan 2019 15:40:34 +0000 Received: from BYAPR12MB2743.namprd12.prod.outlook.com (20.177.125.220) by BYAPR12MB2648.namprd12.prod.outlook.com (20.176.255.213) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1495.9; Thu, 10 Jan 2019 15:40:30 +0000 Received: from BYAPR12MB2743.namprd12.prod.outlook.com ([fe80::d51a:3dbb:3b90:178b]) by BYAPR12MB2743.namprd12.prod.outlook.com ([fe80::d51a:3dbb:3b90:178b%5]) with mapi id 15.20.1495.011; Thu, 10 Jan 2019 15:40:30 +0000 From: Ashish Singhal To: "Gao, Liming" , "Kinney, Michael D" , "edk2-devel@lists.01.org" CC: "Fu, Siyuan" , "Wu, Jiaxin" Thread-Topic: [PATCH v4 0/2] Provide UEFILib functions for protocol uninstallation Thread-Index: AQHUqF4gwIjNzS3FxUyzKNqwGG70X6Wnra6AgAAFrHCAAOyLAIAAAnOQgAACKoCAAABZUA== Date: Thu, 10 Jan 2019 15:40:30 +0000 Message-ID: References: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3AF073@SHSMSX152.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E3AF0D0@SHSMSX152.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3AF0D0@SHSMSX152.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Enabled=True; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SiteId=43083d15-7273-40c1-b7db-39efd9ccc17a; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Owner=ashishsingha@nvidia.com; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SetDate=2019-01-10T15:40:29.1164169Z; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Name=Unrestricted; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Application=Microsoft Azure Information Protection; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Extended_MSFT_Method=Automatic; Sensitivity=Unrestricted authentication-results: spf=none (sender IP is ) smtp.mailfrom=ashishsingha@nvidia.com; x-originating-ip: [216.228.112.21] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BYAPR12MB2648; 6:m1Hen62YKnDbsn9yPluJG5qOxI9YvzTthd1ze4h7C4R4SYEJCh7F/R/zzkqr8x4Ty1msPV4Mrp4uVwPCFZ6AFCDRwEKEHP1AgIl525Z9LNDITKxl1HfCQIOE8TrlF3uNQ412rgVnSF/jg5ig3cf6wGR39YFVBzBaI/ztFI3ivWzSLBvyHhBWJKhIDb4+3gG7sTRmH6E4OtwCJ2MKkjLrIdweHsATDZikCJ1aQzhUKbqdxoREfN7g8l7s0gfbCaeNaiVupslke9M85280CEQ5DYa3wymQ5gACeoD8OkqzBM5ePlCiugKEz2gK0vB4tdbZkEPLdg/BNaKoLC2w7Oz0WwPga/wePjub92vVoetqhJvZ+hqKiH/GOGYfaxOm9WzgCnqecxazSt5l0pVb1zh8dEdpU6cMdBJ7z/SWexWG/AmOv9F0x6xPwyanNL0QYO+6VnVoLS2f4OzSwyQwQp+gOg==; 5:MSTeVJjOfQUqM4lcIi+BTcvWcEKBUhmePwJTEokzZxK6fCziCeDbVOo0AslJm+3Lt2j1+nMr+KSV8GAkKNWTAJB8yTPMDjLfqNQU2FNDjN4w5/uEJi2olLgON9diiOobELCH4Ams8xrv1ZbS9nSFtC4L9LCWzY5uka1qaRT81WkaiHtTJbvE4jtVtDvznFynyG8XyUC8LF4PaudgjO0Wfw==; 7:V76/DREaOs1Tkq73y+ke+DuMuGS2vOsfGKYnYdINFedEFeri15vVZwUP4/Z5rRINmHvTmOhTkQC5ae+khT9jd2zwy8F/wOdNJ97eTVe8dAWRgF/VaHvdbRmZcg1s4YRZ00TwdwkJTVEuvp2OrQcY9A== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 5b833db5-87a9-49f3-182b-08d67711f39c x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(2017052603328)(7153060)(7193020); SRVR:BYAPR12MB2648; x-ms-traffictypediagnostic: BYAPR12MB2648: x-microsoft-antispam-prvs: x-forefront-prvs: 0913EA1D60 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(396003)(39860400002)(366004)(136003)(43544003)(199004)(189003)(13464003)(478600001)(446003)(68736007)(26005)(476003)(11346002)(74316002)(105586002)(2906002)(71200400001)(86362001)(186003)(97736004)(3846002)(6306002)(6436002)(305945005)(7736002)(106356001)(71190400001)(9686003)(6116002)(8676002)(66066001)(6506007)(81166006)(76176011)(81156014)(33656002)(486006)(54906003)(316002)(5660300001)(110136005)(14454004)(14444005)(53936002)(256004)(966005)(4326008)(7696005)(53546011)(2501003)(6246003)(99286004)(55016002)(102836004)(8936002)(229853002)(25786009)(93886005); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR12MB2648; H:BYAPR12MB2743.namprd12.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nvidia.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: LeYAjXakr2Mm8n+dSIOOlIPLzDGW59JhVrPdq6aF58rnrhNTgTATLAr5zzVYff/39Dkpv/m0QK1MikbzxgP/Q8K1y41PfLFGVwOYha9iadgOvvXahA0OrDyRamyBQIyrhdCsn2G47tgYZFNgn2MY2vOWWDPfovl8cs+zr64mgQccQSFizIVu+1EmgI42K5N/JpOWGWJ0fQ9ojz7T2pjJljJyccVTGFvPReEjjBXzoBTklO5bm+SCrq5AopsD6I/UqSgZs9McBMxlf2K/toL3KuMptqCX+XNBFjLTjsiAbZgzPwodkJprdmM4W+EgPy2B spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 5b833db5-87a9-49f3-182b-08d67711f39c X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2019 15:40:30.3245 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2648 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1547134835; bh=unySEEFtNkD5JjELTbV/1z49XjV7XLOmXY+/0ULXKK8=; h=X-PGP-Universal:From:To:CC:Subject:Thread-Topic:Thread-Index:Date: Message-ID:References:In-Reply-To:Accept-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:msip_labels:authentication-results: x-originating-ip:x-ms-publictraffictype: x-microsoft-exchange-diagnostics: x-ms-exchange-antispam-srfa-diagnostics: x-ms-office365-filtering-correlation-id:x-microsoft-antispam: x-ms-traffictypediagnostic:x-microsoft-antispam-prvs: x-forefront-prvs:x-forefront-antispam-report:received-spf: x-ms-exchange-senderadcheck:x-microsoft-antispam-message-info: spamdiagnosticoutput:spamdiagnosticmetadata:MIME-Version: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg: Content-Language:Content-Type:Content-Transfer-Encoding; b=aWgUWN43M6CWNmt8lKb6fJb7CBwSPXv7h97nruL+tqstGZuRMPFBX6AhnNqsIt0AY 3oPDdRvfCLVwhUJzopofwK2iCoXjNGQPf6QYWE71eP6Rm2V6JWS2oegxB/VPXBZKWz 2GFrDD6XvRPH66ZjhZQ/o1PpVVdVEc3s7aHC705RAaG2f6BgttuFh3DRAXtdQWynMP RGGidAZjCxyGOMS/lW5SjBgeSRyyrTDR6Kqvrzw1s8n1XoFO3OhDZa0QuHRLkkm27Y wBhbTaAQBAfoaMjf2EQYrAebUqm5U13OCDYkwn1XoWLVEJQezkPlMk4ELcRnlI36TE rcSA6gtzE3gcA== Subject: Re: [PATCH v4 0/2] Provide UEFILib functions for protocol uninstallation X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jan 2019 15:40:38 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks everyone. -----Original Message----- From: Gao, Liming =20 Sent: Thursday, January 10, 2019 8:39 AM To: Ashish Singhal ; Kinney, Michael D ; edk2-devel@lists.01.org Cc: Fu, Siyuan ; Wu, Jiaxin Subject: RE: [PATCH v4 0/2] Provide UEFILib functions for protocol uninstal= lation Pushed them at 0290fca..15666b > -----Original Message----- > From: Ashish Singhal [mailto:ashishsingha@nvidia.com] > Sent: Thursday, January 10, 2019 11:33 PM > To: Gao, Liming ; Kinney, Michael D ; edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Wu, Jiaxin > Subject: RE: [PATCH v4 0/2] Provide UEFILib functions for protocol uninst= allation >=20 > Thanks Liming. I have files BZ: https://bugzilla.tianocore.org/show_bug.c= gi?id=3D1444 to update UEFI drivers to use new APIs. I have not > assigned it to anyone as there are many drivers across packages that need= to be looked at. I would try to fix the ones I hit an issue with. >=20 > Over the weekend Siyuan approved the patch from PATCH v2 which is exactly= same as in PATCH v4. >=20 > Thanks > Ashish >=20 > -----Original Message----- > From: Gao, Liming > Sent: Thursday, January 10, 2019 8:23 AM > To: Ashish Singhal ; Kinney, Michael D ; edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Wu, Jiaxin > Subject: RE: [PATCH v4 0/2] Provide UEFILib functions for protocol uninst= allation >=20 > Ashish: > The MdePkg change is good to me. Reviewed-by: Liming Gao > Please help submit another BZ to update UefiDriver to uninstall protoco= l when failure with new APIs. >=20 > If Siyuan/Jiaxin has no other comments, I will help push this patch set= . >=20 > Thanks > Liming > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > Ashish Singhal > > Sent: Thursday, January 10, 2019 9:19 AM > > To: Kinney, Michael D ; > > edk2-devel@lists.01.org > > Cc: Fu, Siyuan ; Wu, Jiaxin > > ; Gao, Liming > > Subject: Re: [edk2] [PATCH v4 0/2] Provide UEFILib functions for > > protocol uninstallation > > > > Thanks Mike. Hope to see the patches merged soon. Please let me know if= you want me to file the BZ. > > > > Hi Liming, > > > > Please let me know if you need me to take care of anything in the patch= before you push it. > > > > Hi Siyuan/Jiaxin, > > > > I think you reviewed the changes in PATCH v2 which is same as in PATCH = v4. Please let me know if you have any issues with this going > in. > > > > Thanks > > Ashish > > > > -----Original Message----- > > From: Kinney, Michael D > > Sent: Wednesday, January 9, 2019 5:56 PM > > To: Ashish Singhal ; edk2-devel@lists.01.org; > > Kinney, Michael D > > Cc: Gao, Liming ; Fu, Siyuan > > ; Wu, Jiaxin > > Subject: RE: [PATCH v4 0/2] Provide UEFILib functions for protocol > > uninstallation > > > > Hi Ashish, > > > > This V4 version of the patch produces the expected size results for pla= tform and driver builds. > > > > There are some very minor issues with some extra carriage returns, but > > those can be handled by Liming when the patch series is committed. > > > > I may be good to have an additional BZ to use these new APIs from all > > UEFI Driver Model drivers that have failure paths in their entry point = or support the unload feature. > > Those updates can be done later. > > > > Thanks, > > > > Mike > > > > > -----Original Message----- > > > From: Ashish Singhal [mailto:ashishsingha@nvidia.com] > > > Sent: Wednesday, January 9, 2019 12:59 PM > > > To: edk2-devel@lists.01.org > > > Cc: Kinney, Michael D ; Gao, Liming > > > ; Fu, Siyuan ; Wu, Jiaxin > > > ; Ashish Singhal > > > Subject: [PATCH v4 0/2] Provide UEFILib functions for protocol > > > uninstallation > > > > > > An issue was seen in IScsiDxe in NetworkPkg where driver cleanup > > > after initialization failure was not done right. Bug 1428 was filed > > > in this regard. > > > As per discussions with Mike, it was also discussed that having > > > UEFILib provide protocol uninstallation abstraction would help to > > > avoid these issues in the future. Bug 1429 was found to track this. > > > These 2 patches > > > take care of this. > > > > > > > > > Ashish Singhal (2): > > > MdePkg/UefiLib: Abstract driver model protocol uninstallation > > > NetworkPkg/IScsiDxe: Use UEFILib APIs to uninstall protocols. > > > > > > MdePkg/Include/Library/UefiLib.h | 103 ++++ > > > MdePkg/Library/UefiLib/UefiDriverModel.c | 972 > > > ++++++++++++++++++++++++++++++- > > > NetworkPkg/IScsiDxe/IScsiDriver.c | 31 +- > > > 3 files changed, 1085 insertions(+), 21 deletions(-) > > > > > > -- > > > 2.7.4 > > > > ---------------------------------------------------------------------- > > ------------- This email message is for the sole use of the intended > > recipient(s) and may contain confidential information. Any > > unauthorized review, use, disclosure or distribution is prohibited. > > If you are not the intended recipient, please contact the sender by > > reply email and destroy all copies of the original message. > > ---------------------------------------------------------------------- > > ------------- _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel