Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Correcting EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT definition

["Paul" <paul.grimes@amd.com>]

[AMD Public Use]

Thanks, Liming.  I'll proceed with the commit.

Thanks,
Paul

-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn> 
Sent: Thursday, August 27, 2020 5:58 PM
To: devel@edk2.groups.io; Grimes, Paul <Paul.Grimes@amd.com>; 'Leif Lindholm' <leif@nuviainc.com>; 'Laszlo Ersek' <lersek@redhat.com>; afish@apple.com; 'Michael D Kinney' <michael.d.kinney@intel.com>
Cc: 'Michael D Kinney' <michael.d.kinney@intel.com>; 'Zhiguang Liu' <zhiguang.liu@intel.com>
Subject: 回复: [edk2-devel] [PATCH v1 1/1] MdePkg: Correcting EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT definition

[CAUTION: External Email]

Paul:
  This is a clear issue. Thanks for your reporting it. I would like to catch the fix into this stable tag 202008.
  Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+64705+4905953+8761045@groups.io
> <bounce+27952+64705+4905953+8761045@groups.io> 代表 Paul
> 发送时间: 2020年8月28日 4:41
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao 
> <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>
> 主题: [edk2-devel] [PATCH v1 1/1] MdePkg: Correcting 
> EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT definition
>
> In Acpi10.h, EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT is defined as 0x10, but 
> should be 0x02 per the ACPI Specification.
>
> REF:https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2F
> bugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2937&amp;data=02%7C01%7Cp
> aul.grimes%40amd.com%7Cd9425d4573104c573b5208d84aed6531%7C3dd8961fe488
> 4e608e11a82d994e183d%7C0%7C0%7C637341730767115023&amp;sdata=lVaJUuzXpm
> 91Ezi8phhdMxts8l4x9vTly0NIQsLV8%2FA%3D&amp;reserved=0
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Signed-off-by: Paul G <paul.grimes@amd.com>
> ---
>  MdePkg/Include/IndustryStandard/Acpi10.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdePkg/Include/IndustryStandard/Acpi10.h
> b/MdePkg/Include/IndustryStandard/Acpi10.h
> index fa06eefbb6e6..adeb5ae8c219 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi10.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi10.h
> @@ -358,7 +358,7 @@ typedef struct {
>  #define EFI_ACPI_DMA_TRANSFER_TYPE_MASK                 0x03
>
>
>  #define   EFI_ACPI_DMA_TRANSFER_TYPE_8_BIT              0x00
>
>
>  #define   EFI_ACPI_DMA_TRANSFER_TYPE_8_BIT_AND_16_BIT   0x01
>
>
> -#define   EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT             0x10
>
>
> +#define   EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT             0x02
>
>
>
>
>
>  //
>
>
>  // IO Information
>
>
> --
> 2.21.0
>
>
>