Hi Jeremiah,
I have some questions for this change.
1. Will there be a PlatformBuild.py in any platform as your design? For example there will be a PlatformBuild.py in MdeModulePkg, EmulatorPkg and etc. And this PlatformBuild.py can be seen as a template?
2. The original build options can be set either from PlatformBuild.py CommonPlatform class or set from command line, is it right?
3. There is another build scripts edk2-platforms\Platform\Intel\build_bios.py for build Min-Platforms. Can PlatformBuild.py work together with it?
4. Dose the pytools support clang on windows?
5. I tried this patch on my local machines, but build failed with pytools and your change.
1) One windows machine only installed VS2015, vswhere can't detect VS2015.
2) Another windows machine installed VS2015 and VS2017, vswhere can find VS2017, but build failed with the messages
build.py...
INFO - : error 7000: Failed to execute command
INFO - Vc\bin\nmake.exe
3) I have a Ubuntu 18.04 machine, build failed at the step of "stuart_update -c OvmfPkg/PlatformBuild.py" with the error messages:
File "/home/bobfeng/PythonVenv1/lib/python3.6/site-packages/edk2toolext/environment/extdeptypes/nuget_dependency.py", line 180, in fetch
if self._fetch_from_cache(package_name):
File "/home/bobfeng/PythonVenv1/lib/python3.6/site-packages/edk2toolext/environment/extdeptypes/nuget_dependency.py", line 113, in _fetch_from_cache
if not os.path.isdir(NugetDependency.global_cache_path):
File "/usr/lib/python3.6/genericpath.py", line 42, in isdir
st = os.stat(s)
Thanks,
Bob
-----Original Message-----
From: devel@edk2.groups.io [
mailto:devel@edk2.groups.io] On Behalf Of Laszlo Ersek
Sent: Wednesday, November 27, 2019 5:29 PM
To: devel@edk2.groups.io; jerecox@microsoft.com
Subject: Re: [edk2-devel] Seeking feedback: example of building OvmfPkg with Pytools
Hi Jeremiah,
On 11/27/19 01:03, Jeremiah Cox via Groups.Io wrote:
> All,
> I created an example of how to build OvmfPkg using the Pytools build environment (
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2-pytool-extensions&data=02%7C01%7Cjerecox%40microsoft.com%7Cb73016ada4ec4ab091c208d77476eb6c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637105926421631531&sdata=cEITDGTog5kBjBA8HQDRt%2FyVem9xpqtbnC%2FitE8eyTE%3D&reserved=0
).
> It is available for your feedback on GitHub:
>
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fout0xb2%2Fedk2%2Fpull%2F3%2Ffiles&data=02%7C01%7Cjerecox%40microsoft.com%7Cb73016ada4ec4ab091c208d77476eb6c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637105926421631531&sdata=SHlSuJMKDf8GOWwH8KrNIf6MtC%2FnjhRRZ1htdQT8%2Fvc%3D&reserved=0
>
> Looking for your thoughts on integrating this example into EDK2.
This patch set seems to target the edk2 repository, and at least in part OvmfPkg. Please submit the patch set to the list for review.
Thanks
Laszlo