From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web12.696.1570584802928361190 for ; Tue, 08 Oct 2019 18:33:23 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: prince.agyeman@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Oct 2019 18:33:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,273,1566889200"; d="scan'208";a="223422405" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga002.fm.intel.com with ESMTP; 08 Oct 2019 18:33:22 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 8 Oct 2019 18:33:21 -0700 Received: from FMSMSX110.amr.corp.intel.com ([169.254.14.36]) by fmsmsx120.amr.corp.intel.com ([169.254.15.63]) with mapi id 14.03.0439.000; Tue, 8 Oct 2019 18:33:21 -0700 From: "Agyeman, Prince" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Wei, David Y" Subject: Re: [edk2-platforms][PATCH V1 14/17] SimicsOpenBoardPkg/BoardX58Ich10: Relocate DSC includes Thread-Topic: [edk2-platforms][PATCH V1 14/17] SimicsOpenBoardPkg/BoardX58Ich10: Relocate DSC includes Thread-Index: AQHVfZetweHJffcgM0OuAuGcrxJGS6dRh8nw Date: Wed, 9 Oct 2019 01:33:21 +0000 Message-ID: References: <20191008051645.22052-1-michael.a.kubacki@intel.com> <20191008051645.22052-15-michael.a.kubacki@intel.com> In-Reply-To: <20191008051645.22052-15-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.1.200.108] MIME-Version: 1.0 Return-Path: prince.agyeman@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Prince Agyeman -----Original Message----- From: Kubacki, Michael A=20 Sent: Monday, October 7, 2019 10:17 PM To: devel@edk2.groups.io Cc: Agyeman, Prince ; Wei, David Y Subject: [edk2-platforms][PATCH V1 14/17] SimicsOpenBoardPkg/BoardX58Ich10:= Relocate DSC includes This change moves the following DSC file includes to the top of the OpenBoa= rdPkg.dsc file. This is to improve visibility and align placement of the in= clude with other board DSC files. * OpenBoardPkgConfig.dsc * OpenBoardPkgPcd.dsc * CorePeiLib.dsc * CoreDxeLib.dsc Cc: Agyeman Prince Cc: Wei David Y Signed-off-by: Michael Kubacki --- Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc | 21 ++++= +++------------- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.d= sc b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc index 59e13154a7..be29737c16 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc +++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc @@ -39,7 +39,11 @@ DEFINE NETWORK_TLS_ENABLE =3D FALSE DEFINE NETWORK_ISCSI_ENABLE =3D FALSE DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS =3D TRUE + + !include $(BOARD_PKG)/$(BOARD_NAME)/OpenBoardPkgConfig.dsc + !include $(BOARD_PKG)/$(BOARD_NAME)/OpenBoardPkgPcd.dsc !include NetworkPkg/NetworkDefines.dsc.inc + ##########################################################################= ###### # # SKU Identification section - list of all SKU IDs supported by this Platf= orm. @@ -54,12 +58,9 @@ # ##########################################################################= ###### =20 -[PcdsFeatureFlag] - # - # Platform On/Off features are defined here - # - !include $(BOARD_PKG)/$(BOARD_NAME)/OpenBoardPkgConfig.dsc !include MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc + !include MinPlatformPkg/Include/Dsc/CorePeiLib.dsc + !include MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc !include $(PCH_PKG)/IchCommonLib.dsc =20 [LibraryClasses] @@ -76,17 +77,13 @@ SiliconPolicyInitLib|$(BOARD_PKG)/Policy/Library/SiliconPolicyInitLib/Si= liconPolicyInitLib.inf SiliconPolicyUpdateLib|$(BOARD_PKG)/Policy/Library/SiliconPolicyUpdateLi= b/SiliconPolicyUpdateLib.inf PciSegmentInfoLib|MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/Pci= SegmentInfoLibSimple.inf - - !include MinPlatformPkg/Include/Dsc/CorePeiLib.dsc - S3BootScriptLib|MdeModulePkg/Library/PiDxeS3BootScriptLib/DxeS3BootScrip= tLib.inf AslUpdateLib|MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslUpdateLib= .inf LogoLib|$(BOARD_PKG)/Library/DxeLogoLib/DxeLogoLib.inf + [LibraryClasses.common.SEC] ExtractGuidedSectionLib|MdePkg/Library/BaseExtractGuidedSectionLib/BaseE= xtractGuidedSectionLib.inf =20 -[LibraryClasses.common.PEI_CORE] - [LibraryClasses.common.PEIM] PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiRe= sourcePublicationLib.inf MpInitLib|UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf @@ -97,16 +94,12 @@ !endif TestPointLib|MinPlatformPkg/Test/Library/TestPointLib/PeiTestPointLib.in= f =20 - !include MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc - [LibraryClasses.common.DXE_DRIVER] PlatformBootManagerLib|$(BOARD_PKG)/Library/PlatformBootManagerLib/Platf= ormBootManagerLib.inf =20 [LibraryClasses.common.DXE_SMM_DRIVER] SpiFlashCommonLib|$(PCH_PKG)/Library/SmmSpiFlashCommonLib/SmmSpiFlashCom= monLib.inf =20 - !include $(BOARD_PKG)/$(BOARD_NAME)/OpenBoardPkgPcd.dsc - [Components.IA32] $(BOARD_PKG)/SecCore/SecMain.inf { -- 2.16.2.windows.1