From: "Zhang, Shenglei" <shenglei.zhang@intel.com>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
Andrew Fish <afish@apple.com>, Laszlo Ersek <lersek@redhat.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [PATCH 1/3] Maintainers.txt: Remove EdkShellPkg and EkdShellBinPkg
Date: Thu, 1 Nov 2018 06:03:22 +0000 [thread overview]
Message-ID: <C0706E73DB8C124D9B9C38AA364E5D5E04BAAFD7@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20181031110157.cw3rytphr4ajc5fe@bivouac.eciton.net>
Hi Leif,
Thanks for your comments. Actually there is a cover letter.
https://lists.01.org/pipermail/edk2-devel/2018-October/031666.html
It may not be needed to rework but I 'll push the patches in order according to
the comments you mentioned.
Thanks,
Shenglei
> -----Original Message-----
> From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> Sent: Wednesday, October 31, 2018 7:02 PM
> To: Zhang, Shenglei <shenglei.zhang@intel.com>
> Cc: edk2-devel@lists.01.org; Andrew Fish <afish@apple.com>; Laszlo Ersek
> <lersek@redhat.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: Re: [PATCH 1/3] Maintainers.txt: Remove EdkShellPkg and
> EkdShellBinPkg
>
> Hi Shenglei,
>
> I am happy with this change, but I think the deletion from
> Maintainers.txt should come last (as 3/3).
> Could you rework and resubmit, and add a cover letter (0/3)?
>
> Best Regards,
>
> Leif
>
> On Wed, Oct 31, 2018 at 02:05:23PM +0800, shenglei wrote:
> > Given that EdkShellPkg and EkdShellBinPkg will be removed,
> > information about them in Maintainers.txt should also be
> > deleted.
> > https://bugzilla.tianocore.org/show_bug.cgi?id=1107
> > https://bugzilla.tianocore.org/show_bug.cgi?id=1108
> >
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: shenglei <shenglei.zhang@intel.com>
> > ---
> > Maintainers.txt | 6 ------
> > 1 file changed, 6 deletions(-)
> >
> > diff --git a/Maintainers.txt b/Maintainers.txt
> > index 36c6689afd..98f104b674 100644
> > --- a/Maintainers.txt
> > +++ b/Maintainers.txt
> > @@ -114,12 +114,6 @@ EdkCompatibilityPkg
> > W:
> https://github.com/tianocore/tianocore.github.io/wiki/EdkCompatibilityPkg
> > M: Liming Gao <liming.gao@intel.com>
> >
> > -EdkShellPkg, EdkShellBinPkg
> > -W: https://github.com/tianocore/tianocore.github.io/wiki/EdkShellPkg
> > -M: Ruiyu Ni <ruiyu.ni@intel.com>
> > -T: svn - https://svn.code.sf.net/p/efi-shell/code/trunk/Shell/
> > -S: Obsolete (Use ShellPkg & ShellBinPkg instead)
> > -
> > EmbeddedPkg
> > W: https://github.com/tianocore/tianocore.github.io/wiki/EmbeddedPkg
> > M: Leif Lindholm <leif.lindholm@linaro.org>
> > --
> > 2.18.0.windows.1
> >
next prev parent reply other threads:[~2018-11-01 6:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 6:05 [PATCH 0/3] Remove EdkShellBinPkg and EdkShellPkg shenglei
2018-10-31 6:05 ` [PATCH 1/3] Maintainers.txt: Remove EdkShellPkg and EkdShellBinPkg shenglei
2018-10-31 9:08 ` Ni, Ruiyu
2018-10-31 11:01 ` Leif Lindholm
2018-11-01 6:03 ` Zhang, Shenglei [this message]
2018-11-01 11:31 ` Leif Lindholm
2018-11-05 16:52 ` Laszlo Ersek
2018-11-05 17:20 ` Carsey, Jaben
2018-10-31 6:05 ` [PATCH 2/3] EdkShellBinPkg: Remove EdkShellBinPkg shenglei
2018-10-31 6:05 ` [PATCH 3/3] EdkShellPkg: Remove EdkShellPkg shenglei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C0706E73DB8C124D9B9C38AA364E5D5E04BAAFD7@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox