From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.136; helo=mga12.intel.com; envelope-from=shenglei.zhang@intel.com; receiver=edk2-devel@lists.01.org Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8120721188C4F for ; Wed, 31 Oct 2018 23:03:27 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Oct 2018 23:03:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,451,1534834800"; d="scan'208";a="104334800" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga001.fm.intel.com with ESMTP; 31 Oct 2018 23:03:27 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 31 Oct 2018 23:03:25 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 31 Oct 2018 23:03:25 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.84]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.214]) with mapi id 14.03.0415.000; Thu, 1 Nov 2018 14:03:24 +0800 From: "Zhang, Shenglei" To: Leif Lindholm CC: "edk2-devel@lists.01.org" , Andrew Fish , Laszlo Ersek , "Kinney, Michael D" Thread-Topic: [PATCH 1/3] Maintainers.txt: Remove EdkShellPkg and EkdShellBinPkg Thread-Index: AQHUcQkyNRoK+3KkPkOvxrb4Eu88IqU6barw Date: Thu, 1 Nov 2018 06:03:22 +0000 Message-ID: References: <20181031060525.16696-1-shenglei.zhang@intel.com> <20181031060525.16696-2-shenglei.zhang@intel.com> <20181031110157.cw3rytphr4ajc5fe@bivouac.eciton.net> In-Reply-To: <20181031110157.cw3rytphr4ajc5fe@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 1/3] Maintainers.txt: Remove EdkShellPkg and EkdShellBinPkg X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Nov 2018 06:03:27 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Leif, Thanks for your comments. Actually there is a cover letter.=20 https://lists.01.org/pipermail/edk2-devel/2018-October/031666.html It may not be needed to rework but I 'll push the patches in order accordin= g to the comments you mentioned. Thanks, Shenglei > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: Wednesday, October 31, 2018 7:02 PM > To: Zhang, Shenglei > Cc: edk2-devel@lists.01.org; Andrew Fish ; Laszlo Ersek > ; Kinney, Michael D > Subject: Re: [PATCH 1/3] Maintainers.txt: Remove EdkShellPkg and > EkdShellBinPkg >=20 > Hi Shenglei, >=20 > I am happy with this change, but I think the deletion from > Maintainers.txt should come last (as 3/3). > Could you rework and resubmit, and add a cover letter (0/3)? >=20 > Best Regards, >=20 > Leif >=20 > On Wed, Oct 31, 2018 at 02:05:23PM +0800, shenglei wrote: > > Given that EdkShellPkg and EkdShellBinPkg will be removed, > > information about them in Maintainers.txt should also be > > deleted. > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1107 > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1108 > > > > Cc: Andrew Fish > > Cc: Laszlo Ersek > > Cc: Leif Lindholm > > Cc: Michael D Kinney > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: shenglei > > --- > > Maintainers.txt | 6 ------ > > 1 file changed, 6 deletions(-) > > > > diff --git a/Maintainers.txt b/Maintainers.txt > > index 36c6689afd..98f104b674 100644 > > --- a/Maintainers.txt > > +++ b/Maintainers.txt > > @@ -114,12 +114,6 @@ EdkCompatibilityPkg > > W: > https://github.com/tianocore/tianocore.github.io/wiki/EdkCompatibilityPkg > > M: Liming Gao > > > > -EdkShellPkg, EdkShellBinPkg > > -W: https://github.com/tianocore/tianocore.github.io/wiki/EdkShellPkg > > -M: Ruiyu Ni > > -T: svn - https://svn.code.sf.net/p/efi-shell/code/trunk/Shell/ > > -S: Obsolete (Use ShellPkg & ShellBinPkg instead) > > - > > EmbeddedPkg > > W: https://github.com/tianocore/tianocore.github.io/wiki/EmbeddedPkg > > M: Leif Lindholm > > -- > > 2.18.0.windows.1 > >