From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=shenglei.zhang@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 19CE2211A2D98 for ; Thu, 13 Dec 2018 22:17:19 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Dec 2018 22:17:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,351,1539673200"; d="scan'208";a="302105107" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga006.fm.intel.com with ESMTP; 13 Dec 2018 22:17:18 -0800 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 13 Dec 2018 22:17:18 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 13 Dec 2018 22:17:17 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.182]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.59]) with mapi id 14.03.0415.000; Fri, 14 Dec 2018 14:17:16 +0800 From: "Zhang, Shenglei" To: Leif Lindholm CC: "edk2-devel@lists.01.org" , "Kinney, Michael D" , "Gao, Liming" Thread-Topic: [edk2] [PATCH 0/2] Add two public functions Thread-Index: AQHUkr7ZIuNClzQRZ0qIgpcEpYgGeqV7+BiAgAHK66A= Date: Fri, 14 Dec 2018 06:17:15 +0000 Message-ID: References: <20181213083439.28716-1-shenglei.zhang@intel.com> <20181213105149.qmycz7eshvai67r7@bivouac.eciton.net> In-Reply-To: <20181213105149.qmycz7eshvai67r7@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 0/2] Add two public functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Dec 2018 06:17:19 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Leif Thanks for your constructive guide. I 'll improve my later patches. Thanks, Shenglei > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: Thursday, December 13, 2018 6:52 PM > To: Zhang, Shenglei > Cc: edk2-devel@lists.01.org; Kinney, Michael D > ; Gao, Liming > Subject: Re: [edk2] [PATCH 0/2] Add two public functions >=20 > Please let the subject line give some sort of hint of what is being > done, and to what. "Add two functions" is not substantially more > descriptive than "add 572 characters". >=20 > In this case, your're moving previously internal string helper functions > to BaseLib. >=20 > On Thu, Dec 13, 2018 at 04:34:37PM +0800, Shenglei Zhang wrote: > > Add two public functions,CharToUpper and AsciiToUpper,and > > remove the same functional functions,InternalCharToUpper > > and InternalBaseLibAsciiToUpper. > > > > Cc: Michael D Kinney > > Cc: Liming Gao > > Cc: Bob Feng > > Cc: Yonghong Zhu > > Shenglei Zhang (2): > > MdePkg/BaseLib: Add two public functions > > BaseTools/Common: Remove InternalCharToUpper > > > > BaseTools/Source/C/Common/CommonLib.c | 16 ++------- > > BaseTools/Source/C/Common/CommonLib.h | 4 --- > > MdePkg/Include/Library/BaseLib.h | 40 +++++++++++++++++++++ > > MdePkg/Library/BaseLib/BaseLibInternals.h | 42 ----------------------- > > MdePkg/Library/BaseLib/SafeString.c | 8 ++--- > > MdePkg/Library/BaseLib/String.c | 35 ++++--------------- > > 6 files changed, 53 insertions(+), 92 deletions(-) > > > > -- > > 2.18.0.windows.1 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel