From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=shenglei.zhang@intel.com; receiver=edk2-devel@lists.01.org Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0E57B211CC3A8 for ; Mon, 25 Feb 2019 17:47:54 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Feb 2019 17:47:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,413,1544515200"; d="scan'208,217";a="119070824" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga006.jf.intel.com with ESMTP; 25 Feb 2019 17:47:53 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 25 Feb 2019 17:47:53 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 25 Feb 2019 17:47:53 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.207]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.194]) with mapi id 14.03.0415.000; Tue, 26 Feb 2019 09:47:51 +0800 From: "Zhang, Shenglei" To: krishnaLee , "Carsey, Jaben" CC: "edk2-devel@lists.01.org" Thread-Topic: Re:[edk2] [PATCH] ShellPkg: Correct a parameter's name Thread-Index: AQHUyYTFEA/7idsbn0KzuiEHxg3gZKXo+T6AgAhcVwA= Date: Tue, 26 Feb 2019 01:47:50 +0000 Message-ID: References: <20190221012807.16740-1-shenglei.zhang@intel.com> <1b9465c6.35dc.1690dc837ed.Coremail.sssky307@163.com> In-Reply-To: <1b9465c6.35dc.1690dc837ed.Coremail.sssky307@163.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [PATCH] ShellPkg: Correct a parameter's name X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Feb 2019 01:47:55 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Jaben, Do you have any opinion on "fs-path" rename to "file-full-path-name"? Thanks, Shenglei From: krishnaLee [mailto:sssky307@163.com] Sent: Thursday, February 21, 2019 10:00 AM To: Zhang, Shenglei Cc: edk2-devel@lists.01.org Subject: Re:[edk2] [PATCH] ShellPkg: Correct a parameter's name Hi Shenglei, I am confused some times,see UEFI_Shell_specification_2_2,chapter-3.7: 3.7 File Names The UEFI Shell supports file names and paths with the following format: fs-path :=3D [fs-map-name] [fs-divider][fs-dirs][fs-name] May be if the define name "fs-path" rename to "file-full-path-name" is more= clear,:) thanks, krishna. At 2019-02-21 09:28:07, "Shenglei Zhang" > wrote: >The parameter FilePath of ShellOpenFileByName defined in >ShellLib.h is incorrect. It should be FileName. >https://bugzilla.tianocore.org/show_bug.cgi?id=3D1221 > >Cc: Jaben Carsey > >Cc: Ruiyu Ni > >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: shenglei > >--- > ShellPkg/Include/Library/ShellLib.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/ShellPkg/Include/Library/ShellLib.h b/ShellPkg/Include/Librar= y/ShellLib.h >index 2ecc5ee006..78bdcc8c53 100644 >--- a/ShellPkg/Include/Library/ShellLib.h >+++ b/ShellPkg/Include/Library/ShellLib.h >@@ -161,7 +161,7 @@ ShellOpenFileByDevicePath( > otherwise, the Filehandle is NULL. Attributes is valid only for > EFI_FILE_MODE_CREATE. > >- @param[in] FilePath The pointer to file name. >+ @param[in] FileName The pointer to file name. > @param[out] FileHandle The pointer to the file handle. > @param[in] OpenMode The mode to open the file with. > @param[in] Attributes The file's file attributes. >@@ -186,7 +186,7 @@ ShellOpenFileByDevicePath( > EFI_STATUS > EFIAPI > ShellOpenFileByName( >- IN CONST CHAR16 *FilePath, >+ IN CONST CHAR16 *FileName, > OUT SHELL_FILE_HANDLE *FileHandle, > IN UINT64 OpenMode, > IN UINT64 Attributes >-- >2.18.0.windows.1 > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel