From: "Zhang, Shenglei" <shenglei.zhang@intel.com>
To: "Yao, Jiewen" <jiewen.yao@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [PATCH 1/3] MdePkg/MdePkg.uni: Add the prompt and help information
Date: Mon, 11 Mar 2019 02:41:22 +0000 [thread overview]
Message-ID: <C0706E73DB8C124D9B9C38AA364E5D5E04C093E3@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503F55E8FC@shsmsx102.ccr.corp.intel.com>
Sorry that's my mistake. I'll fix the error in v2.
Thanks,
Shenglei
> -----Original Message-----
> From: Yao, Jiewen
> Sent: Monday, March 11, 2019 9:49 AM
> To: Zhang, Shenglei <shenglei.zhang@intel.com>; edk2-devel@lists.01.org
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>
> Subject: RE: [edk2] [PATCH 1/3] MdePkg/MdePkg.uni: Add the prompt and
> help information
>
> HI
> I am confused why the help info is " Indicates the maximum length of
> Unicode string used in the following " ?
>
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > Shenglei Zhang
> > Sent: Monday, March 11, 2019 8:55 AM
> > To: edk2-devel@lists.01.org
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> > <liming.gao@intel.com>
> > Subject: [edk2] [PATCH 1/3] MdePkg/MdePkg.uni: Add the prompt and
> help
> > information
> >
> > The prompt and help information are missing in MdePkg.uni.
> > https://bugzilla.tianocore.org/show_bug.cgi?id=1600
> >
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> > ---
> > MdePkg/MdePkg.uni | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/MdePkg/MdePkg.uni b/MdePkg/MdePkg.uni
> > index 863a68d025..4f86432eb2 100644
> > --- a/MdePkg/MdePkg.uni
> > +++ b/MdePkg/MdePkg.uni
> > @@ -148,6 +148,13 @@
> >
> > "0 - No length check for unicode string.<BR>\n"
> >
> > ">0 - Maximum length of unicode string.<BR>"
> >
> > +#string
> >
> STR_gEfiMdePkgTokenSpaceGuid_PcdControlFlowEnforcementPropertyMas
> > k_PROMPT #language en-US "Maximum Length of Unicode String."
> > +
> > +#string
> >
> STR_gEfiMdePkgTokenSpaceGuid_PcdControlFlowEnforcementPropertyMas
> > k_HELP #language en-US "Indicates the maximum length of unicode
> > string used in the following\n"
> > +
> > "BaseLib functions: StrLen(), StrSize(), StrCmp(), StrnCmp(), StrCpy(),
> > StrnCpy()<BR><BR>\n"
> > +
> > "0 - No length check for unicode string.<BR>\n"
> > +
> > ">0 - Maximum length of unicode string.<BR>"
> > +
> > #string
> >
> STR_gEfiMdePkgTokenSpaceGuid_PcdMaximumAsciiStringLength_PROMPT
> > #language en-US "Maximum Length of Ascii String"
> >
> > #string
> > STR_gEfiMdePkgTokenSpaceGuid_PcdMaximumAsciiStringLength_HELP
> > #language en-US "Sets the maximum number of ASCII characters used for
> > string functions. This affects the following BaseLib functions: AsciiStrLen(),
> > AsciiStrSize(), AsciiStrCmp(), AsciiStrnCmp(), AsciiStrCpy(), AsciiStrnCpy().
> > <BR><BR>\n"
> > --
> > 2.18.0.windows.1
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2019-03-11 2:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 0:55 [PATCH 0/3] Add the prompt and help information in .uni files Shenglei Zhang
2019-03-11 0:55 ` [PATCH 1/3] MdePkg/MdePkg.uni: Add the prompt and help information Shenglei Zhang
2019-03-11 1:48 ` Yao, Jiewen
2019-03-11 2:41 ` Zhang, Shenglei [this message]
2019-03-11 0:55 ` [PATCH 2/3] SecurityPkg/SecurityPkg.uni: " Shenglei Zhang
2019-03-11 0:55 ` [PATCH 3/3] UefiCpuPkg/UefiCpuPkg.uni: " Shenglei Zhang
2019-03-11 1:15 ` Dong, Eric
2019-03-12 14:18 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C0706E73DB8C124D9B9C38AA364E5D5E04C093E3@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox