public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: shenglei.zhang@intel.com
To: "Gao, Liming" <liming.gao@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [edk2] [PATCH] SourceLevelDebugPkg/DebugAgent: Remove AsmFuncs.S in INF
Date: Thu, 4 Apr 2019 03:15:30 +0000	[thread overview]
Message-ID: <C0706E73DB8C124D9B9C38AA364E5D5E04C1BC0F@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E41EA35@SHSMSX104.ccr.corp.intel.com>

A commit(50cb4b90311fa5353df921fce42de5ad188da658) has been pushed to fix the build failure.

Thanks,
Shenglei

> -----Original Message-----
> From: Gao, Liming
> Sent: Wednesday, April 3, 2019 7:31 PM
> To: Zhang, Shenglei <shenglei.zhang@intel.com>
> Subject: RE: [edk2] [PATCH] SourceLevelDebugPkg/DebugAgent: Remove
> AsmFuncs.S in INF
> 
> Do you check CI result?
> 
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> shenglei
> > Sent: Wednesday, April 3, 2019 2:32 PM
> > To: edk2-devel@lists.01.org
> > Cc: Wu, Hao A <hao.a.wu@intel.com>
> > Subject: [edk2] [PATCH] SourceLevelDebugPkg/DebugAgent: Remove
> AsmFuncs.S in INF
> >
> > AsmFuncs.S is removed at c7d22535f7dc90b8fef70153ef98549228569680.
> > And also it should be removed in SecPeiDebugAgentLib.inf and
> > SmmDebugAgentLib.inf.
> >
> > Cc: Hao Wu <hao.a.wu@intel.com>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> > ---
> >  SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf | 2 -
> -
> >  SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf    | 2 -
> -
> >  2 files changed, 4 deletions(-)
> >
> > diff --git
> a/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf
> > b/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf
> > index 03ebbb6e74..8b81795d96 100644
> > --- a/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf
> > +++
> b/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf
> > @@ -39,14 +39,12 @@
> >    DebugAgentCommon/DebugMp.h
> >
> >  [Sources.Ia32]
> > -  DebugAgentCommon/Ia32/AsmFuncs.S
> >    DebugAgentCommon/Ia32/AsmFuncs.nasm
> >    DebugAgentCommon/Ia32/ArchDebugSupport.h
> >    DebugAgentCommon/Ia32/ArchDebugSupport.c
> >    DebugAgentCommon/Ia32/DebugException.h
> >
> >  [Sources.X64]
> > -  DebugAgentCommon/X64/AsmFuncs.S
> >    DebugAgentCommon/X64/AsmFuncs.nasm
> >    DebugAgentCommon/X64/ArchDebugSupport.h
> >    DebugAgentCommon/X64/ArchDebugSupport.c
> > diff --git
> a/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf
> > b/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf
> > index 08ed1777be..f1b32daab3 100644
> > --- a/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf
> > +++ b/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf
> > @@ -39,14 +39,12 @@
> >    DebugAgentCommon/DebugMp.h
> >
> >  [Sources.Ia32]
> > -  DebugAgentCommon/Ia32/AsmFuncs.S
> >    DebugAgentCommon/Ia32/AsmFuncs.nasm
> >    DebugAgentCommon/Ia32/ArchDebugSupport.h
> >    DebugAgentCommon/Ia32/ArchDebugSupport.c
> >    DebugAgentCommon/Ia32/DebugException.h
> >
> >  [Sources.X64]
> > -  DebugAgentCommon/X64/AsmFuncs.S
> >    DebugAgentCommon/X64/AsmFuncs.nasm
> >    DebugAgentCommon/X64/ArchDebugSupport.h
> >    DebugAgentCommon/X64/ArchDebugSupport.c
> > --
> > 2.18.0.windows.1
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel

      parent reply	other threads:[~2019-04-04  3:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-03  6:31 [PATCH] SourceLevelDebugPkg/DebugAgent: Remove AsmFuncs.S in INF shenglei
2019-04-03  7:26 ` Wu, Hao A
2019-04-03  7:30   ` Wu, Hao A
     [not found] ` <4A89E2EF3DFEDB4C8BFDE51014F606A14E41EA35@SHSMSX104.ccr.corp.intel.com>
2019-04-04  3:15   ` shenglei.zhang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C0706E73DB8C124D9B9C38AA364E5D5E04C1BC0F@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox