Re: [edk2-devel] [PATCH 1/3] MdeModulePkg: Add missing header files in INF files

["Zhang, Shenglei" <shenglei.zhang@intel.com>]

> -----Original Message-----
> From: Wu, Hao A
> Sent: Monday, August 12, 2019 10:00 AM
> To: devel@edk2.groups.io; Zhang, Shenglei <shenglei.zhang@intel.com>
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming
> <liming.gao@intel.com>
> Subject: RE: [edk2-devel] [PATCH 1/3] MdeModulePkg: Add missing header
> files in INF files
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Zhang, Shenglei
> > Sent: Thursday, August 08, 2019 2:25 PM
> > To: devel@edk2.groups.io
> > Cc: Wang, Jian J; Wu, Hao A; Gao, Liming
> > Subject: [edk2-devel] [PATCH 1/3] MdeModulePkg: Add missing header
> files
> > in INF files
> >
> > The header files are used but missing in INF,which causes
> > generating warning message when building them.
> >
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> > ---
> >  MdeModulePkg/Universal/CapsulePei/CapsulePei.inf    | 1 +
> >  MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf | 7 +++++++
> >  2 files changed, 8 insertions(+)
> >
> > diff --git a/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf
> > b/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf
> > index 786c41163304..adf9f1502d69 100644
> > --- a/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf
> > +++ b/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf
> > @@ -33,6 +33,7 @@ [Sources]
> >    UefiCapsule.c
> >    Capsule.h
> >    Common/CapsuleCoalesce.c
> > +  Common/CommonHeader.h
> 
> 
> File 'Common/CapsuleCoalesce.c' is referring the header
> 'Common/CommonHeader.h'.
> 
> The patch updates CapsulePei.inf, but there is a similar case in
> CapsuleX64.inf as well.
> 
> Could you help to check whether such change is needed there?
> 
Good point! Indeed it looks strange to add 'Common/CommonHeader.h' only
in CapsulePei.inf but not in CapsuleX64.inf. I'll add it in v2 patch.

> 
> >
> >  [Packages]
> >    MdePkg/MdePkg.dec
> > diff --git a/MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf
> > b/MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf
> > index af002bd98e99..2a4e256063a6 100644
> > --- a/MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf
> > +++ b/MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf
> > @@ -28,6 +28,13 @@ [Sources]
> >    EbcDebugger/EdbCommon.h
> >    EbcDebugger/EdbSupportString.c
> >    EbcDebugger/EdbSupport.h
> > +  EbcDebugger/EdbCommand.h
> > +  EbcDebugger/EdbHook.h
> > +  EbcDebugger/Edb.h
> > +  EbcDebugger/EdbDisasmSupport.h
> > +  EbcDebugger/EdbDisasm.h
> > +  EbcDebugger/EdbSymbol.h
> > +  EbcDebuggerHook.h
> 
> 
> Could you help to check whether the below 3 INF files within
> MdeModulePkg/Universal/EbcDxe have listed all used files in them?

I'll check them. Potential changes will be included in v2 patch.

Thanks,
Shenglei

> 
> (At least, I think there might be something missing in EbcDxe.inf)
> 
> Best Regards,
> Hao Wu
> 
> 
> >
> >  [Packages]
> >    MdePkg/MdePkg.dec
> > --
> > 2.18.0.windows.1
> >
> >
> >