From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: shenglei.zhang@intel.com) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by groups.io with SMTP; Sun, 11 Aug 2019 22:19:11 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Aug 2019 22:19:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,376,1559545200"; d="scan'208";a="375114963" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga005.fm.intel.com with ESMTP; 11 Aug 2019 22:19:11 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 11 Aug 2019 22:19:10 -0700 Received: from shsmsx106.ccr.corp.intel.com ([169.254.10.204]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.139]) with mapi id 14.03.0439.000; Mon, 12 Aug 2019 13:19:09 +0800 From: "Zhang, Shenglei" To: "Wu, Hao A" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH 1/3] MdeModulePkg: Add missing header files in INF files Thread-Topic: [edk2-devel] [PATCH 1/3] MdeModulePkg: Add missing header files in INF files Thread-Index: AQHVTbILpeTrDDLUz06jN0gsACYBAab2xWNggAA47jA= Date: Mon, 12 Aug 2019 05:19:08 +0000 Message-ID: References: <20190808062456.6116-1-shenglei.zhang@intel.com> <20190808062456.6116-2-shenglei.zhang@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: shenglei.zhang@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Wu, Hao A > Sent: Monday, August 12, 2019 10:00 AM > To: devel@edk2.groups.io; Zhang, Shenglei > Cc: Wang, Jian J ; Gao, Liming > > Subject: RE: [edk2-devel] [PATCH 1/3] MdeModulePkg: Add missing header > files in INF files >=20 > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Zhang, Shenglei > > Sent: Thursday, August 08, 2019 2:25 PM > > To: devel@edk2.groups.io > > Cc: Wang, Jian J; Wu, Hao A; Gao, Liming > > Subject: [edk2-devel] [PATCH 1/3] MdeModulePkg: Add missing header > files > > in INF files > > > > The header files are used but missing in INF,which causes > > generating warning message when building them. > > > > Cc: Jian J Wang > > Cc: Hao A Wu > > Cc: Liming Gao > > Signed-off-by: Shenglei Zhang > > --- > > MdeModulePkg/Universal/CapsulePei/CapsulePei.inf | 1 + > > MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf | 7 +++++++ > > 2 files changed, 8 insertions(+) > > > > diff --git a/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf > > b/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf > > index 786c41163304..adf9f1502d69 100644 > > --- a/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf > > +++ b/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf > > @@ -33,6 +33,7 @@ [Sources] > > UefiCapsule.c > > Capsule.h > > Common/CapsuleCoalesce.c > > + Common/CommonHeader.h >=20 >=20 > File 'Common/CapsuleCoalesce.c' is referring the header > 'Common/CommonHeader.h'. >=20 > The patch updates CapsulePei.inf, but there is a similar case in > CapsuleX64.inf as well. >=20 > Could you help to check whether such change is needed there? >=20 Good point! Indeed it looks strange to add 'Common/CommonHeader.h' only in CapsulePei.inf but not in CapsuleX64.inf. I'll add it in v2 patch. >=20 > > > > [Packages] > > MdePkg/MdePkg.dec > > diff --git a/MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf > > b/MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf > > index af002bd98e99..2a4e256063a6 100644 > > --- a/MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf > > +++ b/MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf > > @@ -28,6 +28,13 @@ [Sources] > > EbcDebugger/EdbCommon.h > > EbcDebugger/EdbSupportString.c > > EbcDebugger/EdbSupport.h > > + EbcDebugger/EdbCommand.h > > + EbcDebugger/EdbHook.h > > + EbcDebugger/Edb.h > > + EbcDebugger/EdbDisasmSupport.h > > + EbcDebugger/EdbDisasm.h > > + EbcDebugger/EdbSymbol.h > > + EbcDebuggerHook.h >=20 >=20 > Could you help to check whether the below 3 INF files within > MdeModulePkg/Universal/EbcDxe have listed all used files in them? I'll check them. Potential changes will be included in v2 patch. Thanks, Shenglei >=20 > (At least, I think there might be something missing in EbcDxe.inf) >=20 > Best Regards, > Hao Wu >=20 >=20 > > > > [Packages] > > MdePkg/MdePkg.dec > > -- > > 2.18.0.windows.1 > > > > > >=20