From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: shenglei.zhang@intel.com) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by groups.io with SMTP; Fri, 16 Aug 2019 00:51:19 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Aug 2019 00:51:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,391,1559545200"; d="scan'208";a="206174959" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga002.fm.intel.com with ESMTP; 16 Aug 2019 00:51:18 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 16 Aug 2019 00:51:18 -0700 Received: from shsmsx106.ccr.corp.intel.com ([169.254.10.204]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.15]) with mapi id 14.03.0439.000; Fri, 16 Aug 2019 15:51:16 +0800 From: "Zhang, Shenglei" To: "Gao, Zhichao" , "devel@edk2.groups.io" CC: "Carsey, Jaben" , "Ni, Ray" Subject: Re: [PATCH v2 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace shift logical left Thread-Topic: [PATCH v2 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace shift logical left Thread-Index: AQHVU/lVmhP+ijzs0E6EQvehkLI+g6b9TP0QgAAZQPA= Date: Fri, 16 Aug 2019 07:51:15 +0000 Message-ID: References: <20190816061034.23528-1-shenglei.zhang@intel.com> <3CE959C139B4C44DBEA1810E3AA6F9000B8231AC@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <3CE959C139B4C44DBEA1810E3AA6F9000B8231AC@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: shenglei.zhang@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi All, This is patch to fix build failure. I'd like the patch to be checked in bef= ore this stable tag. Thanks, Shenglei > -----Original Message----- > From: Gao, Zhichao > Sent: Friday, August 16, 2019 2:19 PM > To: Zhang, Shenglei ; devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray > Subject: RE: [PATCH v2 1/1] ShellPkg/UefiShellAcpiViewCommandLib: > Replace shift logical left >=20 > Reviewed-by: Zhichao Gao >=20 > Thanks, > Zhichao >=20 > > -----Original Message----- > > From: Zhang, Shenglei > > Sent: Friday, August 16, 2019 2:11 PM > > To: devel@edk2.groups.io > > Cc: Carsey, Jaben ; Ni, Ray ; > > Gao, Zhichao > > Subject: [PATCH v2 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace > > shift logical left > > > > Replace the operation to shift logical left with the function LShiftU64= , which > > has the same functionality. > > The original code causes ShellPkg build failure with build target"-b NO= OPT". > > > > Cc: Jaben Carsey > > Cc: Ray Ni > > Cc: Zhichao Gao > > Signed-off-by: Shenglei Zhang > > --- > > v2: There is no return target from LShiftU64 in v1 patch. > > So update code to "Val =3D LShiftU64(Val,32)". > > > > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c > > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c > > index 94bafa22ef4c..a569c3c55406 100644 > > --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c > > +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c > > @@ -294,7 +294,7 @@ DumpUint64 ( > > > > Val =3D *(UINT32*)(Ptr + sizeof (UINT32)); > > > > - Val <<=3D 32; > > + Val =3D LShiftU64(Val,32); > > Val |=3D (UINT64)*(UINT32*)Ptr; > > > > Print (Format, Val); > > -- > > 2.18.0.windows.1