From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: shenglei.zhang@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Fri, 16 Aug 2019 00:57:28 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Aug 2019 00:56:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,391,1559545200"; d="scan'208";a="167984616" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga007.jf.intel.com with ESMTP; 16 Aug 2019 00:56:31 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 16 Aug 2019 00:56:31 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 16 Aug 2019 00:56:31 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 16 Aug 2019 00:56:30 -0700 Received: from shsmsx106.ccr.corp.intel.com ([169.254.10.204]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.15]) with mapi id 14.03.0439.000; Fri, 16 Aug 2019 15:56:29 +0800 From: "Zhang, Shenglei" To: "Wang, Jian J" , "devel@edk2.groups.io" CC: "Ye, Ting" Subject: Re: [PATCH 1/1] CryptoPkg: Fix coding style Thread-Topic: [PATCH 1/1] CryptoPkg: Fix coding style Thread-Index: AQHVU/9hZA9xFFuQfU+xf7XgrJsG7ab9XXnggAAJw1A= Date: Fri, 16 Aug 2019 07:56:28 +0000 Message-ID: References: <20190816065350.21680-1-shenglei.zhang@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: shenglei.zhang@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi All, This patch has little impact. So I think it's ok to be checked in before co= de freeze. Thanks, Shenglei > -----Original Message----- > From: Wang, Jian J > Sent: Friday, August 16, 2019 3:18 PM > To: Zhang, Shenglei ; devel@edk2.groups.io > Cc: Ye, Ting > Subject: RE: [PATCH 1/1] CryptoPkg: Fix coding style >=20 >=20 > Reviewed-by: Jian J Wang >=20 >=20 > > -----Original Message----- > > From: Zhang, Shenglei > > Sent: Friday, August 16, 2019 2:54 PM > > To: devel@edk2.groups.io > > Cc: Wang, Jian J ; Ye, Ting > > Subject: [PATCH 1/1] CryptoPkg: Fix coding style > > > > Update attribute "Out" to "out". > > The original "Out" can not pass ECC check. > > > > Cc: Jian Wang > > Cc: Ting Ye > > Signed-off-by: Shenglei Zhang > > --- > > CryptoPkg/Library/BaseCryptLib/Kdf/CryptHkdf.c | 2 +- > > CryptoPkg/Library/BaseCryptLib/Kdf/CryptHkdfNull.c | 2 +- > > CryptoPkg/Include/Library/BaseCryptLib.h | 2 +- > > 3 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/CryptoPkg/Library/BaseCryptLib/Kdf/CryptHkdf.c > > b/CryptoPkg/Library/BaseCryptLib/Kdf/CryptHkdf.c > > index f0fcef211d3f..3a827dadfcbd 100644 > > --- a/CryptoPkg/Library/BaseCryptLib/Kdf/CryptHkdf.c > > +++ b/CryptoPkg/Library/BaseCryptLib/Kdf/CryptHkdf.c > > @@ -19,7 +19,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > @param[in] SaltSize Salt size in bytes. > > @param[in] Info Pointer to the application specific in= fo. > > @param[in] InfoSize Info size in bytes. > > - @param[Out] Out Pointer to buffer to receive hkdf valu= e. > > + @param[out] Out Pointer to buffer to receive hkdf valu= e. > > @param[in] OutSize Size of hkdf bytes to generate. > > > > @retval TRUE Hkdf generated successfully. > > diff --git a/CryptoPkg/Library/BaseCryptLib/Kdf/CryptHkdfNull.c > > b/CryptoPkg/Library/BaseCryptLib/Kdf/CryptHkdfNull.c > > index 73deb5bc3614..19d795a4cc16 100644 > > --- a/CryptoPkg/Library/BaseCryptLib/Kdf/CryptHkdfNull.c > > +++ b/CryptoPkg/Library/BaseCryptLib/Kdf/CryptHkdfNull.c > > @@ -18,7 +18,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > @param[in] SaltSize Salt size in bytes. > > @param[in] Info Pointer to the application specific in= fo. > > @param[in] InfoSize Info size in bytes. > > - @param[Out] Out Pointer to buffer to receive hkdf valu= e. > > + @param[out] Out Pointer to buffer to receive hkdf valu= e. > > @param[in] OutSize Size of hkdf bytes to generate. > > > > @retval TRUE Hkdf generated successfully. > > diff --git a/CryptoPkg/Include/Library/BaseCryptLib.h > > b/CryptoPkg/Include/Library/BaseCryptLib.h > > index da32bb2444fd..8fe303a0b390 100644 > > --- a/CryptoPkg/Include/Library/BaseCryptLib.h > > +++ b/CryptoPkg/Include/Library/BaseCryptLib.h > > @@ -3135,7 +3135,7 @@ RandomBytes ( > > @param[in] SaltSize Salt size in bytes. > > @param[in] Info Pointer to the application specific in= fo. > > @param[in] InfoSize Info size in bytes. > > - @param[Out] Out Pointer to buffer to receive hkdf valu= e. > > + @param[out] Out Pointer to buffer to receive hkdf valu= e. > > @param[in] OutSize Size of hkdf bytes to generate. > > > > @retval TRUE Hkdf generated successfully. > > -- > > 2.18.0.windows.1