Re: [edk2-platform PATCH 1/2] Platform/SmbiosBasicDxe: Add a missing header file in INF

["Zhang, Shenglei" <shenglei.zhang@intel.com>]

Actually we didn't do that. SmbiosBasic.h is only used by c files in its directory and not used in other packages.

Thanks,
Shenglei

> -----Original Message-----
> From: Chaganty, Rangasai V
> Sent: Saturday, August 24, 2019 2:12 AM
> To: Zhang, Shenglei <shenglei.zhang@intel.com>; devel@edk2.groups.io
> Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Gao, Liming
> <liming.gao@intel.com>
> Subject: RE: [edk2-platform PATCH 1/2] Platform/SmbiosBasicDxe: Add a
> missing header file in INF
> 
> Have you tried adding the path in AdvancedFeaturePkg.dec under [Includes]
> section?
> 
> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Wednesday, August 21, 2019 1:01 AM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [edk2-platform PATCH 1/2] Platform/SmbiosBasicDxe: Add a missing
> header file in INF
> 
> The header file is used but missing in INF,which causes warning message when
> building them.
> https://bugzilla.tianocore.org/show_bug.cgi?id=2037
> 
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  .../AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf  | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git
> a/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicD
> xe.inf
> b/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicD
> xe.inf
> index 69e930dd..bbac1d5c 100644
> ---
> a/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicD
> xe.inf
> +++
> b/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasi
> +++ cDxe.inf
> @@ -23,6 +23,7 @@
> 
>  [Sources]
>    SmbiosBasicEntryPoint.c
> +  SmbiosBasic.h
>    Type0BiosVendorFunction.c
>    Type1SystemManufacturerFunction.c
>    Type2BaseBoardManufacturerFunction.c
> --
> 2.18.0.windows.1