From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: shenglei.zhang@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by groups.io with SMTP; Mon, 26 Aug 2019 18:31:08 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Aug 2019 18:31:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,435,1559545200"; d="scan'208";a="204783093" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga004.fm.intel.com with ESMTP; 26 Aug 2019 18:31:07 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 26 Aug 2019 18:31:07 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 26 Aug 2019 18:31:07 -0700 Received: from shsmsx106.ccr.corp.intel.com ([169.254.10.204]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.62]) with mapi id 14.03.0439.000; Tue, 27 Aug 2019 09:31:04 +0800 From: "Zhang, Shenglei" To: "Chaganty, Rangasai V" , "devel@edk2.groups.io" CC: "Kubacki, Michael A" , "Gao, Liming" Subject: Re: [edk2-platform PATCH 1/2] Platform/SmbiosBasicDxe: Add a missing header file in INF Thread-Topic: [edk2-platform PATCH 1/2] Platform/SmbiosBasicDxe: Add a missing header file in INF Thread-Index: AQHVV/acIuNlQpBpV0m1YrLb/wS89KcJDAdwgAUxUrA= Date: Tue, 27 Aug 2019 01:31:04 +0000 Message-ID: References: <20190821080108.1736-1-shenglei.zhang@intel.com> <20190821080108.1736-2-shenglei.zhang@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzE5MmMwODItMjU1Zi00Nzk3LTk1ZGUtYTNmMmZmNTlkNWQyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidWtmTnM3bTdCTTRwZ1dBMzhBZUVIQ2lvUk8wUjJoTllPa0IyOTVzVzk0KzZmcUVcL21SNGJSMlNUNGMycEMxZ0gifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: shenglei.zhang@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Actually we didn't do that. SmbiosBasic.h is only used by c files in its di= rectory and not used in other packages. Thanks, Shenglei > -----Original Message----- > From: Chaganty, Rangasai V > Sent: Saturday, August 24, 2019 2:12 AM > To: Zhang, Shenglei ; devel@edk2.groups.io > Cc: Kubacki, Michael A ; Gao, Liming > > Subject: RE: [edk2-platform PATCH 1/2] Platform/SmbiosBasicDxe: Add a > missing header file in INF >=20 > Have you tried adding the path in AdvancedFeaturePkg.dec under [Includes] > section? >=20 > -----Original Message----- > From: Zhang, Shenglei > Sent: Wednesday, August 21, 2019 1:01 AM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chaganty, Rangasai = V > ; Gao, Liming > Subject: [edk2-platform PATCH 1/2] Platform/SmbiosBasicDxe: Add a missing > header file in INF >=20 > The header file is used but missing in INF,which causes warning message w= hen > building them. > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2037 >=20 > Cc: Michael Kubacki > Cc: Sai Chaganty > Cc: Liming Gao > Signed-off-by: Shenglei Zhang > --- > .../AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git > a/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicD > xe.inf > b/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicD > xe.inf > index 69e930dd..bbac1d5c 100644 > --- > a/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicD > xe.inf > +++ > b/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasi > +++ cDxe.inf > @@ -23,6 +23,7 @@ >=20 > [Sources] > SmbiosBasicEntryPoint.c > + SmbiosBasic.h > Type0BiosVendorFunction.c > Type1SystemManufacturerFunction.c > Type2BaseBoardManufacturerFunction.c > -- > 2.18.0.windows.1