Re: [edk2-devel] [PATCH V2 0/3] MdeModulePkg/TerminalConsole: Extend the support terminal types

["Zhang, Shenglei" <shenglei.zhang@intel.com>]

Hi Ard,

That's my mistake to push the broken patch(0d85e67714e31e0dbe4241ab2ebb7c423aba174d).
This patch only updates the file guid, which I thought has no risk. So I didn’t check the build result. 
I should double check the new guid used in the file. Liming has help send a patch to fix this issue. 

Thanks,
Shenglei

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Ard Biesheuvel
> Sent: Tuesday, September 17, 2019 2:29 PM
> To: Gao, Zhichao <zhichao.gao@intel.com>
> Cc: edk2-devel-groups-io <devel@edk2.groups.io>; Wang, Jian J
> <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray
> <ray.ni@intel.com>; Laszlo Ersek <lersek@redhat.com>; Gao, Liming
> <liming.gao@intel.com>
> Subject: Re: [edk2-devel] [PATCH V2 0/3] MdeModulePkg/TerminalConsole:
> Extend the support terminal types
> 
> On Tue, 17 Sep 2019 at 07:22, Gao, Zhichao <zhichao.gao@intel.com> wrote:
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2186
> >
> > Putty is a very popular terminal tool in windows. So add the whole support
> > terminal keyboard type for it. The new introduced type is Linux, XtermR6,
> > VT400 and SCO. And enhance the support for VT100+.
> > This patch set only add the support of function key. Refer to the link:
> > https://www.ssh.com/ssh/putty/putty-
> manuals/0.68/Chapter4.html#config-funkeys
> >
> > V2:
> > Fix typo.
> > Merge the type guid defination into TtyTerm.h.
> >
> 
> Hello Zhichao,
> 
> Since you already pushed the broken patch, you should really be
> posting an updated patch with just the fix.
> 
> In any case, this makes me wonder how you tested this code, since it
> won't even build. Could you elaborate?
> 
> --
> Ard.
> 
> 
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Signed-of-by: Zhichao Gao <zhichao.gao@intel.com>
> >
> > Zhichao Gao (3):
> >   MdeModulePkg: Extend the support keyboard type of Terminal console
> >   MdeModulePkg/TerminalDxe: Extend the terminal console support types
> >   MdeModulePkg/BM_UI: Add the new terminal types to related menu
> >
> >  MdeModulePkg/Include/Guid/TtyTerm.h           |  13 +
> >  .../BootMaintenanceManager.h                  |  12 +-
> >  .../BootMaintenanceManagerStrings.uni         |  10 +-
> >  .../ConsoleOption.c                           |  35 +--
> >  .../BootMaintenanceManagerUiLib/Data.c        |  16 +-
> >  MdeModulePkg/MdeModulePkg.dec                 |   4 +
> >  .../Universal/Console/TerminalDxe/Terminal.c  |  17 +-
> >  .../Universal/Console/TerminalDxe/Terminal.h  |  37 ++-
> >  .../Console/TerminalDxe/TerminalConIn.c       | 281 ++++++++++++++++--
> >  .../Console/TerminalDxe/TerminalConOut.c      |   4 +
> >  .../Console/TerminalDxe/TerminalDxe.inf       |   6 +-
> >  11 files changed, 375 insertions(+), 60 deletions(-)
> >
> > --
> > 2.21.0.windows.1
> >
> >
> >
> >
> 
>