From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: shenglei.zhang@intel.com) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by groups.io with SMTP; Sun, 22 Sep 2019 23:58:16 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Sep 2019 23:58:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,539,1559545200"; d="scan'208";a="213230403" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga004.fm.intel.com with ESMTP; 22 Sep 2019 23:58:14 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 22 Sep 2019 23:58:14 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 22 Sep 2019 23:58:14 -0700 Received: from shsmsx106.ccr.corp.intel.com ([169.254.10.86]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.23]) with mapi id 14.03.0439.000; Mon, 23 Sep 2019 14:58:12 +0800 From: "Zhang, Shenglei" To: "devel@edk2.groups.io" CC: "Gao, Liming" , "Dong, Eric" Subject: Re: [PATCH v2] DebugFeaturePkg: Remove white space and update the ending format Thread-Topic: [PATCH v2] DebugFeaturePkg: Remove white space and update the ending format Thread-Index: AQHVZNbdJXu3Ni1gNE6WlkFR37eGz6cig1XAgBZqm+A= Date: Mon, 23 Sep 2019 06:58:11 +0000 Message-ID: References: <20190906171622.25128-1-shenglei.zhang@intel.com> <20190906171622.25128-3-shenglei.zhang@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: shenglei.zhang@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable For this patch, I'll update the file format of AcpiDebug.c to Dos format wh= en pushing the patch. Thanks, Shenglei > -----Original Message----- > From: Dong, Eric > Sent: Monday, September 9, 2019 8:36 AM > To: Zhang, Shenglei ; devel@edk2.groups.io > Cc: Gao, Liming > Subject: RE: [PATCH v2] DebugFeaturePkg: Remove white space and update > the ending format >=20 > Reviewed-by: Eric Dong >=20 > > -----Original Message----- > > From: Zhang, Shenglei > > Sent: Saturday, September 7, 2019 1:16 AM > > To: devel@edk2.groups.io > > Cc: Dong, Eric ; Gao, Liming > > Subject: [PATCH v2] DebugFeaturePkg: Remove white space and update > the > > ending format > > > > Remove white space in AcpiDebug.c. > > The original end of last line in DebugFeaturePkg.dsc is '/r'. > > Now update it to '/r/n'. > > > > Cc: Eric Dong > > Cc: Liming Gao > > Signed-off-by: Shenglei Zhang > > --- > > v2: In v1 the patch remove the '/r'. In v2 it is updated to '/r/n'. > > The v1 patch is "DebugFeaturePkg: Remove white space and white > ending > > line". > > > > Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c | 3 +-- > > Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc | 2 +- > > 2 files changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c > > b/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c > > index f9cd8bcb..5ad8d259 100644 > > --- a/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c > > +++ b/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c > > @@ -487,7 +487,7 @@ InitializeAcpiDebugSmm ( > > if (EFI_ERROR (Status)) { > > return Status; > > } > > - > > + > > Status =3D SmmBase2->InSmm (SmmBase2, &InSmm); > > ASSERT_EFI_ERROR (Status); > > if (EFI_ERROR (Status)) { > > @@ -519,4 +519,3 @@ InitializeAcpiDebugSmm ( > > > > return Status; > > } > > - > > diff --git a/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc > > b/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc > > index 30f57d5d..8e5ff4c9 100644 > > --- a/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc > > +++ b/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc > > @@ -98,4 +98,4 @@ > > DebugFeaturePkg/AcpiDebug/AcpiDebugSmm.inf > > > > [BuildOptions] > > - *_*_*_CC_FLAGS =3D -D DISABLE_NEW_DEPRECATED_INTERFACES \ No > > newline at end of file > > + *_*_*_CC_FLAGS =3D -D DISABLE_NEW_DEPRECATED_INTERFACES > > -- > > 2.18.0.windows.1