From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web12.3593.1571061766104133679 for ; Mon, 14 Oct 2019 07:02:46 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: shenglei.zhang@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Oct 2019 07:02:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,295,1566889200"; d="scan'208";a="201474030" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by FMSMGA003.fm.intel.com with ESMTP; 14 Oct 2019 07:02:45 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 14 Oct 2019 07:02:45 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 14 Oct 2019 07:02:45 -0700 Received: from shsmsx106.ccr.corp.intel.com ([169.254.10.119]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.33]) with mapi id 14.03.0439.000; Mon, 14 Oct 2019 22:02:43 +0800 From: "Zhang, Shenglei" To: =?utf-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= , "devel@edk2.groups.io" CC: "Fu, Siyuan" , "Wu, Jiaxin" , Laszlo Ersek Subject: Re: [edk2-devel] [PATCH v2] NetworkPkg/IScsiDxe: Fix the index of array TargetUrlp[] Thread-Topic: [edk2-devel] [PATCH v2] NetworkPkg/IScsiDxe: Fix the index of array TargetUrlp[] Thread-Index: AQHVgnKjrb9EC1dqKkmULcO/GLEVQKdaKI5A Date: Mon, 14 Oct 2019 14:02:42 +0000 Message-ID: References: <20191014031432.15984-1-shenglei.zhang@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: shenglei.zhang@intel.com Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 SGkgUGhpbGlwcGUsDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogUGhp bGlwcGUgTWF0aGlldS1EYXVkw6kgW21haWx0bzpwaGlsbWRAcmVkaGF0LmNvbV0NCj4gU2VudDog TW9uZGF5LCBPY3RvYmVyIDE0LCAyMDE5IDU6MzUgUE0NCj4gVG86IGRldmVsQGVkazIuZ3JvdXBz LmlvOyBaaGFuZywgU2hlbmdsZWkgPHNoZW5nbGVpLnpoYW5nQGludGVsLmNvbT4NCj4gQ2M6IEZ1 LCBTaXl1YW4gPHNpeXVhbi5mdUBpbnRlbC5jb20+OyBXdSwgSmlheGluIDxqaWF4aW4ud3VAaW50 ZWwuY29tPjsNCj4gTGFzemxvIEVyc2VrIDxsZXJzZWtAcmVkaGF0LmNvbT4NCj4gU3ViamVjdDog UmU6IFtlZGsyLWRldmVsXSBbUEFUQ0ggdjJdIE5ldHdvcmtQa2cvSVNjc2lEeGU6IEZpeCB0aGUg aW5kZXggb2YNCj4gYXJyYXkgVGFyZ2V0VXJscFtdDQo+IA0KPiBIaSBaaGFuZywNCj4gDQo+IE9u IDEwLzE0LzE5IDU6MTQgQU0sIFpoYW5nLCBTaGVuZ2xlaSB3cm90ZToNCj4gPiBBZnRlciB0aGUg ZXhwcmVzc2lvbiwNCj4gPiAnQ29weU1lbSAoJkNvbmZpZ052RGF0YS0+VGFyZ2V0VXJsLCBGaWVs ZC0+U3RyLCBGaWVsZC0+TGVuKTsnLA0KPiA+IHRoZSAnXDAnIHNob3VsZCBiZSBzZXQgdG8gVGFy Z2V0VXJsW0ZpZWxkLT5MZW5dIHJhdGhlciB0aGFuDQo+ID4gVGFyZ2V0VXJsW0ZpZWxkLT5MZW4g KyAxXS4NCj4gDQo+IF4gVGhpcyBpcyBvbmUgY2hhbmdlLCAuLi4NCj4gDQo+ID4gQmVzaWRlcyB0 aGUgYm91bmRhcnkgY2hlY2sgc2hvdWxkIGJlIG1vcmUgc3RyaWN0Lg0KPiA+IEZpZWxkLT5MZW4g c2hvdWxkIHJhbmdlIGZyb20gMC0yNTQgcmF0aGVyIHRoYW4gMC0yNTUuDQo+IA0KPiBeIC4uLiBh bmQgaGVyZSB3ZSBoYXZlIGFub3RoZXIgY2hhbmdlLg0KPiANCj4gQ2FuIHlvdSBzcGxpdCB0aGlz IGluIDIgcGF0Y2hlcz8NCg0KSSB0aGluayB0aGVzZSB0d28gY2hhbmdlcyBzaG91bGQgYmUgaW5j bHVkZWQgaW4gb25lIHBhdGNoLg0KVGhleSBhcmUgYm90aCBhYm91dCB0aGUgdmFyaWFibGUgJyBG aWVsZC0+TGVuICcuIElmIG9uZSBjaGFuZ2UgcHVzaGVkIGFuZCB0aGUgb3RoZXIgb25lIHVuY2hh bmdlZCwNClRoZSBsb2dpYyBpcyB0aGVuIHdyb25nLg0KDQo+IA0KPiA+IENjOiBTaXl1YW4gRnUg PHNpeXVhbi5mdUBpbnRlbC5jb20+DQo+ID4gQ2M6IEppYXhpbiBXdSA8amlheGluLnd1QGludGVs LmNvbT4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBTaGVuZ2xlaSBaaGFuZyA8c2hlbmdsZWkuemhhbmdA aW50ZWwuY29tPg0KPiA+IC0tLQ0KPiA+DQo+ID4gdjI6IEFkZCBtaXNzaW5nICcpJyB3aGljaCBj YXVzZXMgYnVpbGQgZmFpbHVyZS4NCj4gPg0KPiA+ICAgTmV0d29ya1BrZy9JU2NzaUR4ZS9JU2Nz aURoY3AuYyAgfCA3ICsrKystLS0NCj4gPiAgIE5ldHdvcmtQa2cvSVNjc2lEeGUvSVNjc2lEaGNw Ni5jIHwgNyArKysrLS0tDQo+ID4gICAyIGZpbGVzIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwg NiBkZWxldGlvbnMoLSkNCj4gPg0KPiA+IGRpZmYgLS1naXQgYS9OZXR3b3JrUGtnL0lTY3NpRHhl L0lTY3NpRGhjcC5jDQo+IGIvTmV0d29ya1BrZy9JU2NzaUR4ZS9JU2NzaURoY3AuYw0KPiA+IGlu ZGV4IGQ4YzlmZmY2YzY1ZC4uZWFjNWIzOTk5MWI3IDEwMDY0NA0KPiA+IC0tLSBhL05ldHdvcmtQ a2cvSVNjc2lEeGUvSVNjc2lEaGNwLmMNCj4gPiArKysgYi9OZXR3b3JrUGtnL0lTY3NpRHhlL0lT Y3NpRGhjcC5jDQo+ID4gQEAgLTEyMiwxMSArMTIyLDEyIEBAIElTY3NpRGhjcEV4dHJhY3RSb290 UGF0aCAoDQo+ID4gICAgIC8vDQo+ID4gICAgIGlmICgoIU5FVF9JU19ESUdJVCAoKihGaWVsZC0+ U3RyKSkpICYmICgqKEZpZWxkLT5TdHIpICE9ICdbJykpIHsNCj4gPiAgICAgICBDb25maWdOdkRh dGEtPkRuc01vZGUgPSBUUlVFOw0KPiA+IC0gICAgaWYgKEZpZWxkLT5MZW4gPiBzaXplb2YgKENv bmZpZ052RGF0YS0+VGFyZ2V0VXJsKSkgew0KPiA+IC0gICAgICByZXR1cm4gRUZJX0lOVkFMSURf UEFSQU1FVEVSOw0KPiA+ICsgICAgaWYgKEZpZWxkLT5MZW4gPj0gc2l6ZW9mIChDb25maWdOdkRh dGEtPlRhcmdldFVybCkpIHsNCj4gPiArICAgICAgU3RhdHVzID0gRUZJX0lOVkFMSURfUEFSQU1F VEVSOw0KPiA+ICsgICAgICBnb3RvIE9OX0VYSVQ7DQo+IA0KPiBUaGlzIGlzIGEgY2hhbmdlIGlu IHRoZSBjb2RlIGZsb3cuIFNvIG5vdyB3ZSBmcmVlIGhlIGFsbG9jYXRlZCBUbXBTdHIuDQo+IFRo aXMgaXMgY29ycmVjdCwgYnV0IHlvdSBkaWQgbm90IGNvbW1lbnRlZCB0aGF0IGNoYW5nZSBpbiB0 aGUNCj4gZGVzY3JpcHRpb24uIFNvIHdlIGN1cnJlbnRseSBoYXZlIGEgbWVtb3J5IGxlYWsuIFBs ZWFzZSBkbyBub3QgaGlkZSB0aGF0DQo+IGtpbmQgb2YgaW5mb3JtYXRpb24gaW4gcGF0Y2hlcy4N Cg0KWWVzIHRoZSBjb21taXQgbWVzc2FnZSBzaG91bGQgY29udGFpbiB0aGlzIGNoYW5nZS4NCg0K PiANCj4gPiAgICAgICB9DQo+ID4gICAgICAgQ29weU1lbSAoJkNvbmZpZ052RGF0YS0+VGFyZ2V0 VXJsLCBGaWVsZC0+U3RyLCBGaWVsZC0+TGVuKTsNCj4gPiAtICAgIENvbmZpZ052RGF0YS0+VGFy Z2V0VXJsW0ZpZWxkLT5MZW4gKyAxXSA9ICdcMCc7DQo+ID4gKyAgICBDb25maWdOdkRhdGEtPlRh cmdldFVybFtGaWVsZC0+TGVuXSA9ICdcMCc7DQo+IA0KPiBBbmQgaGVyZSB3ZSBoYXZlIDEgYnl0 ZSBvZiBtZW1vcnkgaW5mbyBsZWFrLg0KPiANCj4gQXJlIHlvdSBmaXhpbmcgYSBTZWN1cml0eSBC Wj8NCg0KTm8sIEkgZm91bmQgdGhpcyBpc3N1ZSBieSBteSBsb2NhbCB0b29sLiBUaGVyZSBpcyBu byBCWiBmb3IgdGhpcy4NCg0KVGhhbmtzLA0KU2hlbmdsZWkNCg0KPiANCj4gPiAgICAgfSBlbHNl IHsNCj4gPiAgICAgICBDb25maWdOdkRhdGEtPkRuc01vZGUgPSBGQUxTRTsNCj4gPiAgICAgICBa ZXJvTWVtKENvbmZpZ052RGF0YS0+VGFyZ2V0VXJsLCBzaXplb2YgKENvbmZpZ052RGF0YS0+VGFy Z2V0VXJsKSk7DQo+ID4gZGlmZiAtLWdpdCBhL05ldHdvcmtQa2cvSVNjc2lEeGUvSVNjc2lEaGNw Ni5jDQo+IGIvTmV0d29ya1BrZy9JU2NzaUR4ZS9JU2NzaURoY3A2LmMNCj4gPiBpbmRleCA4NmE4 NzJhZGVjY2MuLmJlNjZlNjY4NGEwZSAxMDA2NDQNCj4gPiAtLS0gYS9OZXR3b3JrUGtnL0lTY3Np RHhlL0lTY3NpRGhjcDYuYw0KPiA+ICsrKyBiL05ldHdvcmtQa2cvSVNjc2lEeGUvSVNjc2lEaGNw Ni5jDQo+ID4gQEAgLTE2MSwxMSArMTYxLDEyIEBAIElTY3NpRGhjcDZFeHRyYWN0Um9vdFBhdGgg KA0KPiA+ICAgICAvLyBTZXJ2ZXIgbmFtZSBpcyBleHByZXNzZWQgYXMgZG9tYWluIG5hbWUsIGp1 c3Qgc2F2ZSBpdC4NCj4gPiAgICAgLy8NCj4gPiAgICAgaWYgKENvbmZpZ052RGF0YS0+RG5zTW9k ZSkgew0KPiA+IC0gICAgaWYgKEZpZWxkLT5MZW4gPiBzaXplb2YgKENvbmZpZ052RGF0YS0+VGFy Z2V0VXJsKSkgew0KPiA+IC0gICAgICByZXR1cm4gRUZJX0lOVkFMSURfUEFSQU1FVEVSOw0KPiA+ ICsgICAgaWYgKEZpZWxkLT5MZW4gPj0gc2l6ZW9mIChDb25maWdOdkRhdGEtPlRhcmdldFVybCkp IHsNCj4gPiArICAgICAgU3RhdHVzID0gRUZJX0lOVkFMSURfUEFSQU1FVEVSOw0KPiA+ICsgICAg ICBnb3RvIE9OX0VYSVQ7DQo+ID4gICAgICAgfQ0KPiA+ICAgICAgIENvcHlNZW0gKCZDb25maWdO dkRhdGEtPlRhcmdldFVybCwgRmllbGQtPlN0ciwgRmllbGQtPkxlbik7DQo+ID4gLSAgICBDb25m aWdOdkRhdGEtPlRhcmdldFVybFtGaWVsZC0+TGVuICsgMV0gPSAnXDAnOw0KPiA+ICsgICAgQ29u ZmlnTnZEYXRhLT5UYXJnZXRVcmxbRmllbGQtPkxlbl0gPSAnXDAnOw0KPiA+ICAgICB9IGVsc2Ug ew0KPiA+ICAgICAgIFplcm9NZW0oJkNvbmZpZ052RGF0YS0+VGFyZ2V0VXJsLCBzaXplb2YgKENv bmZpZ052RGF0YS0NCj4gPlRhcmdldFVybCkpOw0KPiA+ICAgICAgIFN0YXR1cyA9IElTY3NpQXNj aWlTdHJUb0lwIChGaWVsZC0+U3RyLCBJcE1vZGUsICZJcCk7DQo+ID4NCg==