* [PATCH] CryptoPkg: ECC issue.
@ 2020-02-25 1:53 GuoMinJ
2020-03-04 8:29 ` [edk2-devel] " Zhang, Shenglei
0 siblings, 1 reply; 2+ messages in thread
From: GuoMinJ @ 2020-02-25 1:53 UTC (permalink / raw)
To: devel; +Cc: GuoMinJ
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2552
Some issue is reported by ECC tool, correct it.
Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
---
.../Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c | 9 +++++++++
CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf | 2 +-
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
index 34d5f410b0..b503a5708b 100644
--- a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
+++ b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
@@ -32,6 +32,15 @@ GetCryptoServices (
return (VOID *)mCryptoProtocol;
}
+/**
+ Locate the valid Crypto Protocol.
+
+ @param ImageHandle The firmware allocated handle for the EFI image.
+ @param SystemTable A pointer to the EFI System Table.
+
+ @retval EFI_SUCCESS The constructor executed correctly.
+ @retval EFI_NOT_FOUND Found no valid Crypto Protocol.
+**/
EFI_STATUS
EFIAPI
DxeCryptLibConstructor (
diff --git a/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf b/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
index b4d8675ddd..046320353b 100644
--- a/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
+++ b/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
@@ -17,7 +17,7 @@
FILE_GUID = B1E566DD-DE7C-4F04-BDA0-B1295D3BE927
MODULE_TYPE = BASE
VERSION_STRING = 1.0
- LIBRARY_CLASS = BaseHashApiLib
+ LIBRARY_CLASS = HashApiLib
#
# The following information is for reference only and not required by the build tools.
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [edk2-devel] [PATCH] CryptoPkg: ECC issue.
2020-02-25 1:53 [PATCH] CryptoPkg: ECC issue GuoMinJ
@ 2020-03-04 8:29 ` Zhang, Shenglei
0 siblings, 0 replies; 2+ messages in thread
From: Zhang, Shenglei @ 2020-03-04 8:29 UTC (permalink / raw)
To: devel@edk2.groups.io, newexplorerj@gmail.com
Hi Guomin,
Please update the subject and let us know the brief change through it.
The details could be placed in commit message.
When sending a patch of next version, you can update the subject prefix like
"[PATCH v2] CryptoPkg: *** ".
Thanks,
Shenglei
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> GuoMinJ
> Sent: Tuesday, February 25, 2020 9:53 AM
> To: devel@edk2.groups.io
> Cc: GuoMinJ <newexplorerj@gmail.com>
> Subject: [edk2-devel] [PATCH] CryptoPkg: ECC issue.
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2552
>
> Some issue is reported by ECC tool, correct it.
>
> Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
> ---
> .../Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c | 9 +++++++++
> CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf | 2 +-
> 2 files changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
> b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
> index 34d5f410b0..b503a5708b 100644
> --- a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
> +++ b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
> @@ -32,6 +32,15 @@ GetCryptoServices (
> return (VOID *)mCryptoProtocol;
> }
>
> +/**
> + Locate the valid Crypto Protocol.
> +
> + @param ImageHandle The firmware allocated handle for the EFI image.
> + @param SystemTable A pointer to the EFI System Table.
> +
> + @retval EFI_SUCCESS The constructor executed correctly.
> + @retval EFI_NOT_FOUND Found no valid Crypto Protocol.
> +**/
> EFI_STATUS
> EFIAPI
> DxeCryptLibConstructor (
> diff --git a/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
> b/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
> index b4d8675ddd..046320353b 100644
> --- a/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
> +++ b/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
> @@ -17,7 +17,7 @@
> FILE_GUID = B1E566DD-DE7C-4F04-BDA0-B1295D3BE927
> MODULE_TYPE = BASE
> VERSION_STRING = 1.0
> - LIBRARY_CLASS = BaseHashApiLib
> + LIBRARY_CLASS = HashApiLib
>
> #
> # The following information is for reference only and not required by the
> build tools.
> --
> 2.17.1
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-04 8:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-25 1:53 [PATCH] CryptoPkg: ECC issue GuoMinJ
2020-03-04 8:29 ` [edk2-devel] " Zhang, Shenglei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox