From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web09.8459.1583310601288917049 for ; Wed, 04 Mar 2020 00:30:01 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: shenglei.zhang@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Mar 2020 00:30:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,513,1574150400"; d="scan'208";a="287280023" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by FMSMGA003.fm.intel.com with ESMTP; 04 Mar 2020 00:30:00 -0800 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 4 Mar 2020 00:30:00 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 4 Mar 2020 00:30:00 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.206]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.155]) with mapi id 14.03.0439.000; Wed, 4 Mar 2020 16:29:58 +0800 From: "Zhang, Shenglei" To: "devel@edk2.groups.io" , "newexplorerj@gmail.com" Subject: Re: [edk2-devel] [PATCH] CryptoPkg: ECC issue. Thread-Topic: [edk2-devel] [PATCH] CryptoPkg: ECC issue. Thread-Index: AQHV6351y91Nyprc9UKqaya7Vpw/Qqg4JbPw Date: Wed, 4 Mar 2020 08:29:57 +0000 Message-ID: References: <76a4ba530dea866c743b2f8f85a1672a34a35e52.1582595594.git.newexplorerj@gmail.com> In-Reply-To: <76a4ba530dea866c743b2f8f85a1672a34a35e52.1582595594.git.newexplorerj@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: shenglei.zhang@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Guomin, Please update the subject and let us know the brief change through it. The details could be placed in commit message. When sending a patch of next version, you can update the subject prefix l= ike "[PATCH v2] CryptoPkg: *** ". Thanks, Shenglei > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > GuoMinJ > Sent: Tuesday, February 25, 2020 9:53 AM > To: devel@edk2.groups.io > Cc: GuoMinJ > Subject: [edk2-devel] [PATCH] CryptoPkg: ECC issue. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2552 >=20 > Some issue is reported by ECC tool, correct it. >=20 > Signed-off-by: GuoMinJ > --- > .../Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c | 9 +++++++++ > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf | 2 +- > 2 files changed, 10 insertions(+), 1 deletion(-) >=20 > diff --git a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c > b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c > index 34d5f410b0..b503a5708b 100644 > --- a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c > +++ b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c > @@ -32,6 +32,15 @@ GetCryptoServices ( > return (VOID *)mCryptoProtocol; > } >=20 > +/** > + Locate the valid Crypto Protocol. > + > + @param ImageHandle The firmware allocated handle for the EFI image= . > + @param SystemTable A pointer to the EFI System Table. > + > + @retval EFI_SUCCESS The constructor executed correctly. > + @retval EFI_NOT_FOUND Found no valid Crypto Protocol. > +**/ > EFI_STATUS > EFIAPI > DxeCryptLibConstructor ( > diff --git a/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf > b/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf > index b4d8675ddd..046320353b 100644 > --- a/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf > +++ b/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf > @@ -17,7 +17,7 @@ > FILE_GUID =3D B1E566DD-DE7C-4F04-BDA0-B1295D3BE9= 27 > MODULE_TYPE =3D BASE > VERSION_STRING =3D 1.0 > - LIBRARY_CLASS =3D BaseHashApiLib > + LIBRARY_CLASS =3D HashApiLib >=20 > # > # The following information is for reference only and not required by t= he > build tools. > -- > 2.17.1 >=20 >=20 >=20