Re: [edk2-devel] [PATCH] UefiCpuPkg: ECC issue.

["Zhang, Shenglei" <shenglei.zhang@intel.com>]

Same comments  with mail thread " CryptoPkg: ECC issue. "

Thanks,
Shenglei

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> GuoMinJ
> Sent: Tuesday, February 25, 2020 9:33 AM
> To: devel@edk2.groups.io
> Cc: GuoMinJ <newexplorerj@gmail.com>
> Subject: [edk2-devel] [PATCH] UefiCpuPkg: ECC issue.
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2553
> 
> The comment haven't indicate the output attribute.
> 
> Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
> ---
>  UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 2 +-
>  UefiCpuPkg/Library/MpInitLib/MpLib.h    | 2 +-
>  UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
> b/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
> index a987c32109..096d1c9b4b 100644
> --- a/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
> +++ b/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
> @@ -821,7 +821,7 @@ MpInitLibEnableDisableAP (
>    This funtion will try to invoke platform specific microcode shadow logic to
>    relocate microcode update patches into memory.
> 
> -  @param[in] CpuMpData  The pointer to CPU MP Data structure.
> +  @param[in, out] CpuMpData  The pointer to CPU MP Data structure.
> 
>    @retval EFI_SUCCESS              Shadow microcode success.
>    @retval EFI_OUT_OF_RESOURCES     No enough resource to complete the
> operation.
> diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h
> b/UefiCpuPkg/Library/MpInitLib/MpLib.h
> index 455cb3f09a..06556197c3 100644
> --- a/UefiCpuPkg/Library/MpInitLib/MpLib.h
> +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h
> @@ -658,7 +658,7 @@ GetProcessorNumber (
>    This funtion will try to invoke platform specific microcode shadow logic to
>    relocate microcode update patches into memory.
> 
> -  @param[in] CpuMpData  The pointer to CPU MP Data structure.
> +  @param[in, out] CpuMpData  The pointer to CPU MP Data structure.
> 
>    @retval EFI_SUCCESS              Shadow microcode success.
>    @retval EFI_OUT_OF_RESOURCES     No enough resource to complete the
> operation.
> diff --git a/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
> b/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
> index 17b60903c5..a548fed23f 100644
> --- a/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
> +++ b/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
> @@ -644,7 +644,7 @@ MpInitLibEnableDisableAP (
>    This funtion will try to invoke platform specific microcode shadow logic to
>    relocate microcode update patches into memory.
> 
> -  @param[in] CpuMpData  The pointer to CPU MP Data structure.
> +  @param[in, out] CpuMpData  The pointer to CPU MP Data structure.
> 
>    @retval EFI_SUCCESS              Shadow microcode success.
>    @retval EFI_OUT_OF_RESOURCES     No enough resource to complete the
> operation.
> --
> 2.17.1
> 
> 
>