From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.8499.1583310720892254539 for ; Wed, 04 Mar 2020 00:32:00 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: shenglei.zhang@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Mar 2020 00:32:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,513,1574150400"; d="scan'208";a="263526794" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga004.fm.intel.com with ESMTP; 04 Mar 2020 00:32:00 -0800 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 4 Mar 2020 00:32:00 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 4 Mar 2020 00:32:00 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.206]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.155]) with mapi id 14.03.0439.000; Wed, 4 Mar 2020 16:31:57 +0800 From: "Zhang, Shenglei" To: "devel@edk2.groups.io" , "newexplorerj@gmail.com" Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg: ECC issue. Thread-Topic: [edk2-devel] [PATCH] UefiCpuPkg: ECC issue. Thread-Index: AQHV63uX9y51mYkRBEqY13X4Ti1KEag4J2Og Date: Wed, 4 Mar 2020 08:31:56 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: shenglei.zhang@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Same comments with mail thread " CryptoPkg: ECC issue. " Thanks, Shenglei > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > GuoMinJ > Sent: Tuesday, February 25, 2020 9:33 AM > To: devel@edk2.groups.io > Cc: GuoMinJ > Subject: [edk2-devel] [PATCH] UefiCpuPkg: ECC issue. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2553 >=20 > The comment haven't indicate the output attribute. >=20 > Signed-off-by: GuoMinJ > --- > UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 2 +- > UefiCpuPkg/Library/MpInitLib/MpLib.h | 2 +- > UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c > b/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c > index a987c32109..096d1c9b4b 100644 > --- a/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c > +++ b/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c > @@ -821,7 +821,7 @@ MpInitLibEnableDisableAP ( > This funtion will try to invoke platform specific microcode shadow lo= gic to > relocate microcode update patches into memory. >=20 > - @param[in] CpuMpData The pointer to CPU MP Data structure. > + @param[in, out] CpuMpData The pointer to CPU MP Data structure. >=20 > @retval EFI_SUCCESS Shadow microcode success. > @retval EFI_OUT_OF_RESOURCES No enough resource to complete the > operation. > diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h > b/UefiCpuPkg/Library/MpInitLib/MpLib.h > index 455cb3f09a..06556197c3 100644 > --- a/UefiCpuPkg/Library/MpInitLib/MpLib.h > +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h > @@ -658,7 +658,7 @@ GetProcessorNumber ( > This funtion will try to invoke platform specific microcode shadow lo= gic to > relocate microcode update patches into memory. >=20 > - @param[in] CpuMpData The pointer to CPU MP Data structure. > + @param[in, out] CpuMpData The pointer to CPU MP Data structure. >=20 > @retval EFI_SUCCESS Shadow microcode success. > @retval EFI_OUT_OF_RESOURCES No enough resource to complete the > operation. > diff --git a/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c > b/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c > index 17b60903c5..a548fed23f 100644 > --- a/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c > +++ b/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c > @@ -644,7 +644,7 @@ MpInitLibEnableDisableAP ( > This funtion will try to invoke platform specific microcode shadow lo= gic to > relocate microcode update patches into memory. >=20 > - @param[in] CpuMpData The pointer to CPU MP Data structure. > + @param[in, out] CpuMpData The pointer to CPU MP Data structure. >=20 > @retval EFI_SUCCESS Shadow microcode success. > @retval EFI_OUT_OF_RESOURCES No enough resource to complete the > operation. > -- > 2.17.1 >=20 >=20 >=20