From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web12.8307.1583384712495628060 for ; Wed, 04 Mar 2020 21:05:12 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: shenglei.zhang@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Mar 2020 21:05:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,516,1574150400"; d="scan'208";a="232842322" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga007.fm.intel.com with ESMTP; 04 Mar 2020 21:05:10 -0800 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 4 Mar 2020 21:05:09 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.206]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.235]) with mapi id 14.03.0439.000; Thu, 5 Mar 2020 13:05:07 +0800 From: "Zhang, Shenglei" To: "devel@edk2.groups.io" , "newexplorerj@gmail.com" Subject: Re: [edk2-devel] [PATCH] IntelSiliconPkg: Issue reported by ECC in edk2-platforms. Thread-Topic: [edk2-devel] [PATCH] IntelSiliconPkg: Issue reported by ECC in edk2-platforms. Thread-Index: AQHV5IP2aiVOPHtz5U2KjdX7KNadLag5jYwg Date: Thu, 5 Mar 2020 05:05:07 +0000 Message-ID: References: <77612c8b6fcf7c752e0fac21d114e6ab9e7ebeb6.1581828141.git.newexplorerj@gmail.com> In-Reply-To: <77612c8b6fcf7c752e0fac21d114e6ab9e7ebeb6.1581828141.git.newexplorerj@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: shenglei.zhang@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Please update the subject. " IntelSiliconPkg: Add periods in comments" With this updated, Reviewed-by: Shenglei Zhang Thanks, Shenglei > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > GuoMinJ > Sent: Sunday, February 16, 2020 12:43 PM > To: devel@edk2.groups.io > Cc: GuoMinJ > Subject: [edk2-devel] [PATCH] IntelSiliconPkg: Issue reported by ECC in = edk2- > platforms. >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2518 >=20 > ECC need '.' character at the end of line. >=20 > Signed-off-by: GuoMinJ > --- > .../Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h | 6 +++--- > .../Library/BaseConfigBlockLib/BaseConfigBlockLib.c | 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLi= b.h > b/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h > index 99b8ae4b5a..37a3968168 100644 > --- a/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h > +++ b/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h > @@ -10,7 +10,7 @@ > #define _CONFIG_BLOCK_LIB_H_ >=20 > /** > - Create config block table > + Create config block table. >=20 > @param[in] TotalSize - Max size to be allocate= d for the Config > Block Table > @param[out] ConfigBlockTableAddress - On return, points to a = pointer > to the beginning of Config Block Table Address > @@ -27,7 +27,7 @@ CreateConfigBlockTable ( > ); >=20 > /** > - Add config block into config block table structure > + Add config block into config block table structure. >=20 > @param[in] ConfigBlockTableAddress - A pointer to the beginn= ing of > Config Block Table Address > @param[out] ConfigBlockAddress - On return, points to a = pointer to > the beginning of Config Block Address > @@ -44,7 +44,7 @@ AddConfigBlock ( > ); >=20 > /** > - Retrieve a specific Config Block data by GUID > + Retrieve a specific Config Block data by GUID. >=20 > @param[in] ConfigBlockTableAddress - A pointer to the begin= ning of > Config Block Table Address > @param[in] ConfigBlockGuid - A pointer to the GUID = uses to > search specific Config Block > diff --git > a/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigBlo= ckLi > b.c > b/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigBlo= ckLi > b.c > index 33e0c81e9d..c89699ea46 100644 > --- > a/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigBlo= ckLi > b.c > +++ > b/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigBlo= ckLi > b.c > @@ -12,7 +12,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > #include >=20 > /** > - Create config block table > + Create config block table. >=20 > @param[in] TotalSize - Max size to be allocate= d for the Config > Block Table > @param[out] ConfigBlockTableAddress - On return, points to a = pointer > to the beginning of Config Block Table Address > @@ -51,7 +51,7 @@ CreateConfigBlockTable ( > } >=20 > /** > - Add config block into config block table structure > + Add config block into config block table structure. >=20 > @param[in] ConfigBlockTableAddress - A pointer to the beginn= ing of > Config Block Table Address > @param[out] ConfigBlockAddress - On return, points to a = pointer to > the beginning of Config Block Address > @@ -94,7 +94,7 @@ AddConfigBlock ( > } >=20 > /** > - Retrieve a specific Config Block data by GUID > + Retrieve a specific Config Block data by GUID. >=20 > @param[in] ConfigBlockTableAddress - A pointer to the begin= ning of > Config Block Table Address > @param[in] ConfigBlockGuid - A pointer to the GUID = uses to > search specific Config Block > -- > 2.17.1 >=20 >=20 >=20