public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Zhang, Shenglei" <shenglei.zhang@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"newexplorerj@gmail.com" <newexplorerj@gmail.com>
Subject: Re: [edk2-devel] [edk2-platform][PATCH v2] IntelSiliconPkg: Add periods in comments
Date: Mon, 9 Mar 2020 01:21:25 +0000	[thread overview]
Message-ID: <C0706E73DB8C124D9B9C38AA364E5D5E060431B7@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <77c905ac53e7ea3cf113a223cb0a47dc6beaef9b.1583387221.git.newexplorerj@gmail.com>

Reviewed-By: Shenglei Zhang <shenglei.zhang@intel.com>

Thanks,
Shenglei

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> GuoMinJ
> Sent: Thursday, March 5, 2020 1:47 PM
> To: devel@edk2.groups.io
> Cc: GuoMinJ <newexplorerj@gmail.com>
> Subject: [edk2-devel] [edk2-platform][PATCH v2] IntelSiliconPkg: Add
> periods in comments
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=2518
> 
> ECC need '.' character at the end of line.
> 
> Ray Ni <ray.ni@intel.com>
> Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
> ---
>  .../Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h  | 6 +++---
>  .../Library/BaseConfigBlockLib/BaseConfigBlockLib.c         | 6 +++---
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h
> b/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h
> index 99b8ae4b5a..37a3968168 100644
> --- a/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h
> +++ b/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h
> @@ -10,7 +10,7 @@
>  #define _CONFIG_BLOCK_LIB_H_
> 
>  /**
> -  Create config block table
> +  Create config block table.
> 
>    @param[in]     TotalSize                    - Max size to be allocated for the Config
> Block Table
>    @param[out]    ConfigBlockTableAddress      - On return, points to a pointer
> to the beginning of Config Block Table Address
> @@ -27,7 +27,7 @@ CreateConfigBlockTable (
>    );
> 
>  /**
> -  Add config block into config block table structure
> +  Add config block into config block table structure.
> 
>    @param[in]     ConfigBlockTableAddress      - A pointer to the beginning of
> Config Block Table Address
>    @param[out]    ConfigBlockAddress           - On return, points to a pointer to
> the beginning of Config Block Address
> @@ -44,7 +44,7 @@ AddConfigBlock (
>    );
> 
>  /**
> -  Retrieve a specific Config Block data by GUID
> +  Retrieve a specific Config Block data by GUID.
> 
>    @param[in]      ConfigBlockTableAddress      - A pointer to the beginning of
> Config Block Table Address
>    @param[in]      ConfigBlockGuid              - A pointer to the GUID uses to
> search specific Config Block
> diff --git
> a/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigBlockLi
> b.c
> b/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigBlockLi
> b.c
> index 33e0c81e9d..c89699ea46 100644
> ---
> a/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigBlockLi
> b.c
> +++
> b/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigBlockLi
> b.c
> @@ -12,7 +12,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>  #include <Library/DebugLib.h>
> 
>  /**
> -  Create config block table
> +  Create config block table.
> 
>    @param[in]     TotalSize                    - Max size to be allocated for the Config
> Block Table
>    @param[out]    ConfigBlockTableAddress      - On return, points to a pointer
> to the beginning of Config Block Table Address
> @@ -51,7 +51,7 @@ CreateConfigBlockTable (
>  }
> 
>  /**
> -  Add config block into config block table structure
> +  Add config block into config block table structure.
> 
>    @param[in]     ConfigBlockTableAddress      - A pointer to the beginning of
> Config Block Table Address
>    @param[out]    ConfigBlockAddress           - On return, points to a pointer to
> the beginning of Config Block Address
> @@ -94,7 +94,7 @@ AddConfigBlock (
>  }
> 
>  /**
> -  Retrieve a specific Config Block data by GUID
> +  Retrieve a specific Config Block data by GUID.
> 
>    @param[in]      ConfigBlockTableAddress      - A pointer to the beginning of
> Config Block Table Address
>    @param[in]      ConfigBlockGuid              - A pointer to the GUID uses to
> search specific Config Block
> --
> 2.17.1
> 
> 
> 


  reply	other threads:[~2020-03-09  1:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-05  5:47 [edk2-platform][PATCH v2] IntelSiliconPkg: Add periods in comments GuoMinJ
2020-03-09  1:21 ` Zhang, Shenglei [this message]
2020-03-23  6:15   ` [edk2-devel] " Guomin Jiang
2020-03-23  6:56     ` Chaganty, Rangasai V

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C0706E73DB8C124D9B9C38AA364E5D5E060431B7@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox