From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.47931.1583716889439010905 for ; Sun, 08 Mar 2020 18:21:29 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: shenglei.zhang@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Mar 2020 18:21:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,530,1574150400"; d="scan'208";a="235449091" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga008.fm.intel.com with ESMTP; 08 Mar 2020 18:21:28 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 8 Mar 2020 18:21:28 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 8 Mar 2020 18:21:27 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.206]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.86]) with mapi id 14.03.0439.000; Mon, 9 Mar 2020 09:21:25 +0800 From: "Zhang, Shenglei" To: "devel@edk2.groups.io" , "newexplorerj@gmail.com" Subject: Re: [edk2-devel] [edk2-platform][PATCH v2] IntelSiliconPkg: Add periods in comments Thread-Topic: [edk2-devel] [edk2-platform][PATCH v2] IntelSiliconPkg: Add periods in comments Thread-Index: AQHV8rHR1WlgIWlu2UmhfQ6Ju38bo6g/fH6w Date: Mon, 9 Mar 2020 01:21:25 +0000 Message-ID: References: <77c905ac53e7ea3cf113a223cb0a47dc6beaef9b.1583387221.git.newexplorerj@gmail.com> In-Reply-To: <77c905ac53e7ea3cf113a223cb0a47dc6beaef9b.1583387221.git.newexplorerj@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: shenglei.zhang@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-By: Shenglei Zhang Thanks, Shenglei > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > GuoMinJ > Sent: Thursday, March 5, 2020 1:47 PM > To: devel@edk2.groups.io > Cc: GuoMinJ > Subject: [edk2-devel] [edk2-platform][PATCH v2] IntelSiliconPkg: Add > periods in comments >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2518 >=20 > ECC need '.' character at the end of line. >=20 > Ray Ni > Rangasai V Chaganty > Signed-off-by: GuoMinJ > --- > .../Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h | 6 +++--- > .../Library/BaseConfigBlockLib/BaseConfigBlockLib.c | 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLi= b.h > b/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h > index 99b8ae4b5a..37a3968168 100644 > --- a/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h > +++ b/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h > @@ -10,7 +10,7 @@ > #define _CONFIG_BLOCK_LIB_H_ >=20 > /** > - Create config block table > + Create config block table. >=20 > @param[in] TotalSize - Max size to be allocate= d for the Config > Block Table > @param[out] ConfigBlockTableAddress - On return, points to a = pointer > to the beginning of Config Block Table Address > @@ -27,7 +27,7 @@ CreateConfigBlockTable ( > ); >=20 > /** > - Add config block into config block table structure > + Add config block into config block table structure. >=20 > @param[in] ConfigBlockTableAddress - A pointer to the beginn= ing of > Config Block Table Address > @param[out] ConfigBlockAddress - On return, points to a = pointer to > the beginning of Config Block Address > @@ -44,7 +44,7 @@ AddConfigBlock ( > ); >=20 > /** > - Retrieve a specific Config Block data by GUID > + Retrieve a specific Config Block data by GUID. >=20 > @param[in] ConfigBlockTableAddress - A pointer to the begin= ning of > Config Block Table Address > @param[in] ConfigBlockGuid - A pointer to the GUID = uses to > search specific Config Block > diff --git > a/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigBlo= ckLi > b.c > b/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigBlo= ckLi > b.c > index 33e0c81e9d..c89699ea46 100644 > --- > a/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigBlo= ckLi > b.c > +++ > b/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigBlo= ckLi > b.c > @@ -12,7 +12,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > #include >=20 > /** > - Create config block table > + Create config block table. >=20 > @param[in] TotalSize - Max size to be allocate= d for the Config > Block Table > @param[out] ConfigBlockTableAddress - On return, points to a = pointer > to the beginning of Config Block Table Address > @@ -51,7 +51,7 @@ CreateConfigBlockTable ( > } >=20 > /** > - Add config block into config block table structure > + Add config block into config block table structure. >=20 > @param[in] ConfigBlockTableAddress - A pointer to the beginn= ing of > Config Block Table Address > @param[out] ConfigBlockAddress - On return, points to a = pointer to > the beginning of Config Block Address > @@ -94,7 +94,7 @@ AddConfigBlock ( > } >=20 > /** > - Retrieve a specific Config Block data by GUID > + Retrieve a specific Config Block data by GUID. >=20 > @param[in] ConfigBlockTableAddress - A pointer to the begin= ning of > Config Block Table Address > @param[in] ConfigBlockGuid - A pointer to the GUID = uses to > search specific Config Block > -- > 2.17.1 >=20 >=20 >=20