* [edk2-platform][PATCH v2] IntelSiliconPkg: Add periods in comments @ 2020-03-05 5:47 GuoMinJ 2020-03-09 1:21 ` [edk2-devel] " Zhang, Shenglei 0 siblings, 1 reply; 4+ messages in thread From: GuoMinJ @ 2020-03-05 5:47 UTC (permalink / raw) To: devel; +Cc: GuoMinJ https://bugzilla.tianocore.org/show_bug.cgi?id=2518 ECC need '.' character at the end of line. Ray Ni <ray.ni@intel.com> Rangasai V Chaganty <rangasai.v.chaganty@intel.com> Signed-off-by: GuoMinJ <newexplorerj@gmail.com> --- .../Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h | 6 +++--- .../Library/BaseConfigBlockLib/BaseConfigBlockLib.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h b/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h index 99b8ae4b5a..37a3968168 100644 --- a/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h +++ b/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h @@ -10,7 +10,7 @@ #define _CONFIG_BLOCK_LIB_H_ /** - Create config block table + Create config block table. @param[in] TotalSize - Max size to be allocated for the Config Block Table @param[out] ConfigBlockTableAddress - On return, points to a pointer to the beginning of Config Block Table Address @@ -27,7 +27,7 @@ CreateConfigBlockTable ( ); /** - Add config block into config block table structure + Add config block into config block table structure. @param[in] ConfigBlockTableAddress - A pointer to the beginning of Config Block Table Address @param[out] ConfigBlockAddress - On return, points to a pointer to the beginning of Config Block Address @@ -44,7 +44,7 @@ AddConfigBlock ( ); /** - Retrieve a specific Config Block data by GUID + Retrieve a specific Config Block data by GUID. @param[in] ConfigBlockTableAddress - A pointer to the beginning of Config Block Table Address @param[in] ConfigBlockGuid - A pointer to the GUID uses to search specific Config Block diff --git a/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigBlockLib.c b/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigBlockLib.c index 33e0c81e9d..c89699ea46 100644 --- a/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigBlockLib.c +++ b/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigBlockLib.c @@ -12,7 +12,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include <Library/DebugLib.h> /** - Create config block table + Create config block table. @param[in] TotalSize - Max size to be allocated for the Config Block Table @param[out] ConfigBlockTableAddress - On return, points to a pointer to the beginning of Config Block Table Address @@ -51,7 +51,7 @@ CreateConfigBlockTable ( } /** - Add config block into config block table structure + Add config block into config block table structure. @param[in] ConfigBlockTableAddress - A pointer to the beginning of Config Block Table Address @param[out] ConfigBlockAddress - On return, points to a pointer to the beginning of Config Block Address @@ -94,7 +94,7 @@ AddConfigBlock ( } /** - Retrieve a specific Config Block data by GUID + Retrieve a specific Config Block data by GUID. @param[in] ConfigBlockTableAddress - A pointer to the beginning of Config Block Table Address @param[in] ConfigBlockGuid - A pointer to the GUID uses to search specific Config Block -- 2.17.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [edk2-platform][PATCH v2] IntelSiliconPkg: Add periods in comments 2020-03-05 5:47 [edk2-platform][PATCH v2] IntelSiliconPkg: Add periods in comments GuoMinJ @ 2020-03-09 1:21 ` Zhang, Shenglei 2020-03-23 6:15 ` Guomin Jiang 0 siblings, 1 reply; 4+ messages in thread From: Zhang, Shenglei @ 2020-03-09 1:21 UTC (permalink / raw) To: devel@edk2.groups.io, newexplorerj@gmail.com Reviewed-By: Shenglei Zhang <shenglei.zhang@intel.com> Thanks, Shenglei > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > GuoMinJ > Sent: Thursday, March 5, 2020 1:47 PM > To: devel@edk2.groups.io > Cc: GuoMinJ <newexplorerj@gmail.com> > Subject: [edk2-devel] [edk2-platform][PATCH v2] IntelSiliconPkg: Add > periods in comments > > https://bugzilla.tianocore.org/show_bug.cgi?id=2518 > > ECC need '.' character at the end of line. > > Ray Ni <ray.ni@intel.com> > Rangasai V Chaganty <rangasai.v.chaganty@intel.com> > Signed-off-by: GuoMinJ <newexplorerj@gmail.com> > --- > .../Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h | 6 +++--- > .../Library/BaseConfigBlockLib/BaseConfigBlockLib.c | 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h > b/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h > index 99b8ae4b5a..37a3968168 100644 > --- a/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h > +++ b/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h > @@ -10,7 +10,7 @@ > #define _CONFIG_BLOCK_LIB_H_ > > /** > - Create config block table > + Create config block table. > > @param[in] TotalSize - Max size to be allocated for the Config > Block Table > @param[out] ConfigBlockTableAddress - On return, points to a pointer > to the beginning of Config Block Table Address > @@ -27,7 +27,7 @@ CreateConfigBlockTable ( > ); > > /** > - Add config block into config block table structure > + Add config block into config block table structure. > > @param[in] ConfigBlockTableAddress - A pointer to the beginning of > Config Block Table Address > @param[out] ConfigBlockAddress - On return, points to a pointer to > the beginning of Config Block Address > @@ -44,7 +44,7 @@ AddConfigBlock ( > ); > > /** > - Retrieve a specific Config Block data by GUID > + Retrieve a specific Config Block data by GUID. > > @param[in] ConfigBlockTableAddress - A pointer to the beginning of > Config Block Table Address > @param[in] ConfigBlockGuid - A pointer to the GUID uses to > search specific Config Block > diff --git > a/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigBlockLi > b.c > b/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigBlockLi > b.c > index 33e0c81e9d..c89699ea46 100644 > --- > a/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigBlockLi > b.c > +++ > b/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigBlockLi > b.c > @@ -12,7 +12,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > #include <Library/DebugLib.h> > > /** > - Create config block table > + Create config block table. > > @param[in] TotalSize - Max size to be allocated for the Config > Block Table > @param[out] ConfigBlockTableAddress - On return, points to a pointer > to the beginning of Config Block Table Address > @@ -51,7 +51,7 @@ CreateConfigBlockTable ( > } > > /** > - Add config block into config block table structure > + Add config block into config block table structure. > > @param[in] ConfigBlockTableAddress - A pointer to the beginning of > Config Block Table Address > @param[out] ConfigBlockAddress - On return, points to a pointer to > the beginning of Config Block Address > @@ -94,7 +94,7 @@ AddConfigBlock ( > } > > /** > - Retrieve a specific Config Block data by GUID > + Retrieve a specific Config Block data by GUID. > > @param[in] ConfigBlockTableAddress - A pointer to the beginning of > Config Block Table Address > @param[in] ConfigBlockGuid - A pointer to the GUID uses to > search specific Config Block > -- > 2.17.1 > > > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [edk2-platform][PATCH v2] IntelSiliconPkg: Add periods in comments 2020-03-09 1:21 ` [edk2-devel] " Zhang, Shenglei @ 2020-03-23 6:15 ` Guomin Jiang 2020-03-23 6:56 ` Chaganty, Rangasai V 0 siblings, 1 reply; 4+ messages in thread From: Guomin Jiang @ 2020-03-23 6:15 UTC (permalink / raw) To: devel@edk2.groups.io, Zhang, Shenglei, newexplorerj@gmail.com Cc: Ni, Ray, Chaganty, Rangasai V Hi Ray, Rangasai, Could you help review the patch. Thanks. > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zhang, Shenglei > Sent: Monday, March 9, 2020 9:21 AM > To: devel@edk2.groups.io; newexplorerj@gmail.com > Subject: Re: [edk2-devel] [edk2-platform][PATCH v2] IntelSiliconPkg: Add > periods in comments > > Reviewed-By: Shenglei Zhang <shenglei.zhang@intel.com> > > Thanks, > Shenglei > > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > GuoMinJ > > Sent: Thursday, March 5, 2020 1:47 PM > > To: devel@edk2.groups.io > > Cc: GuoMinJ <newexplorerj@gmail.com> > > Subject: [edk2-devel] [edk2-platform][PATCH v2] IntelSiliconPkg: Add > > periods in comments > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=2518 > > > > ECC need '.' character at the end of line. > > > > Ray Ni <ray.ni@intel.com> > > Rangasai V Chaganty <rangasai.v.chaganty@intel.com> > > Signed-off-by: GuoMinJ <newexplorerj@gmail.com> > > --- > > .../Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h | 6 +++--- > > .../Library/BaseConfigBlockLib/BaseConfigBlockLib.c | 6 +++--- > > 2 files changed, 6 insertions(+), 6 deletions(-) > > > > diff --git > > a/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h > > b/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h > > index 99b8ae4b5a..37a3968168 100644 > > --- a/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h > > +++ b/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h > > @@ -10,7 +10,7 @@ > > #define _CONFIG_BLOCK_LIB_H_ > > > > /** > > - Create config block table > > + Create config block table. > > > > @param[in] TotalSize - Max size to be allocated for the Config > > Block Table > > @param[out] ConfigBlockTableAddress - On return, points to a > pointer > > to the beginning of Config Block Table Address @@ -27,7 +27,7 @@ > > CreateConfigBlockTable ( > > ); > > > > /** > > - Add config block into config block table structure > > + Add config block into config block table structure. > > > > @param[in] ConfigBlockTableAddress - A pointer to the beginning of > > Config Block Table Address > > @param[out] ConfigBlockAddress - On return, points to a pointer > to > > the beginning of Config Block Address > > @@ -44,7 +44,7 @@ AddConfigBlock ( > > ); > > > > /** > > - Retrieve a specific Config Block data by GUID > > + Retrieve a specific Config Block data by GUID. > > > > @param[in] ConfigBlockTableAddress - A pointer to the beginning of > > Config Block Table Address > > @param[in] ConfigBlockGuid - A pointer to the GUID uses to > > search specific Config Block > > diff --git > > a/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigB > > lockLi > > b.c > > b/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigB > > lockLi > > b.c > > index 33e0c81e9d..c89699ea46 100644 > > --- > > a/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigB > > lockLi > > b.c > > +++ > > b/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigB > > lockLi > > b.c > > @@ -12,7 +12,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > #include <Library/DebugLib.h> > > > > /** > > - Create config block table > > + Create config block table. > > > > @param[in] TotalSize - Max size to be allocated for the Config > > Block Table > > @param[out] ConfigBlockTableAddress - On return, points to a > pointer > > to the beginning of Config Block Table Address @@ -51,7 +51,7 @@ > > CreateConfigBlockTable ( } > > > > /** > > - Add config block into config block table structure > > + Add config block into config block table structure. > > > > @param[in] ConfigBlockTableAddress - A pointer to the beginning of > > Config Block Table Address > > @param[out] ConfigBlockAddress - On return, points to a pointer > to > > the beginning of Config Block Address > > @@ -94,7 +94,7 @@ AddConfigBlock ( > > } > > > > /** > > - Retrieve a specific Config Block data by GUID > > + Retrieve a specific Config Block data by GUID. > > > > @param[in] ConfigBlockTableAddress - A pointer to the beginning of > > Config Block Table Address > > @param[in] ConfigBlockGuid - A pointer to the GUID uses to > > search specific Config Block > > -- > > 2.17.1 > > > > > > > > > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [edk2-platform][PATCH v2] IntelSiliconPkg: Add periods in comments 2020-03-23 6:15 ` Guomin Jiang @ 2020-03-23 6:56 ` Chaganty, Rangasai V 0 siblings, 0 replies; 4+ messages in thread From: Chaganty, Rangasai V @ 2020-03-23 6:56 UTC (permalink / raw) To: Jiang, Guomin, devel@edk2.groups.io, Zhang, Shenglei, newexplorerj@gmail.com Cc: Ni, Ray Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com> -----Original Message----- From: Jiang, Guomin <guomin.jiang@intel.com> Sent: Sunday, March 22, 2020 11:15 PM To: devel@edk2.groups.io; Zhang, Shenglei <shenglei.zhang@intel.com>; newexplorerj@gmail.com Cc: Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com> Subject: RE: [edk2-devel] [edk2-platform][PATCH v2] IntelSiliconPkg: Add periods in comments Hi Ray, Rangasai, Could you help review the patch. Thanks. > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zhang, Shenglei > Sent: Monday, March 9, 2020 9:21 AM > To: devel@edk2.groups.io; newexplorerj@gmail.com > Subject: Re: [edk2-devel] [edk2-platform][PATCH v2] IntelSiliconPkg: > Add periods in comments > > Reviewed-By: Shenglei Zhang <shenglei.zhang@intel.com> > > Thanks, > Shenglei > > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf > > Of GuoMinJ > > Sent: Thursday, March 5, 2020 1:47 PM > > To: devel@edk2.groups.io > > Cc: GuoMinJ <newexplorerj@gmail.com> > > Subject: [edk2-devel] [edk2-platform][PATCH v2] IntelSiliconPkg: Add > > periods in comments > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=2518 > > > > ECC need '.' character at the end of line. > > > > Ray Ni <ray.ni@intel.com> > > Rangasai V Chaganty <rangasai.v.chaganty@intel.com> > > Signed-off-by: GuoMinJ <newexplorerj@gmail.com> > > --- > > .../Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h | 6 +++--- > > .../Library/BaseConfigBlockLib/BaseConfigBlockLib.c | 6 +++--- > > 2 files changed, 6 insertions(+), 6 deletions(-) > > > > diff --git > > a/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h > > b/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h > > index 99b8ae4b5a..37a3968168 100644 > > --- a/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h > > +++ b/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h > > @@ -10,7 +10,7 @@ > > #define _CONFIG_BLOCK_LIB_H_ > > > > /** > > - Create config block table > > + Create config block table. > > > > @param[in] TotalSize - Max size to be allocated for the Config > > Block Table > > @param[out] ConfigBlockTableAddress - On return, points to a > pointer > > to the beginning of Config Block Table Address @@ -27,7 +27,7 @@ > > CreateConfigBlockTable ( > > ); > > > > /** > > - Add config block into config block table structure > > + Add config block into config block table structure. > > > > @param[in] ConfigBlockTableAddress - A pointer to the beginning of > > Config Block Table Address > > @param[out] ConfigBlockAddress - On return, points to a pointer > to > > the beginning of Config Block Address @@ -44,7 +44,7 @@ > > AddConfigBlock ( > > ); > > > > /** > > - Retrieve a specific Config Block data by GUID > > + Retrieve a specific Config Block data by GUID. > > > > @param[in] ConfigBlockTableAddress - A pointer to the beginning of > > Config Block Table Address > > @param[in] ConfigBlockGuid - A pointer to the GUID uses to > > search specific Config Block > > diff --git > > a/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfi > > gB > > lockLi > > b.c > > b/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfi > > gB > > lockLi > > b.c > > index 33e0c81e9d..c89699ea46 100644 > > --- > > a/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfi > > gB > > lockLi > > b.c > > +++ > > b/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfi > > gB > > lockLi > > b.c > > @@ -12,7 +12,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > #include <Library/DebugLib.h> > > > > /** > > - Create config block table > > + Create config block table. > > > > @param[in] TotalSize - Max size to be allocated for the Config > > Block Table > > @param[out] ConfigBlockTableAddress - On return, points to a > pointer > > to the beginning of Config Block Table Address @@ -51,7 +51,7 @@ > > CreateConfigBlockTable ( } > > > > /** > > - Add config block into config block table structure > > + Add config block into config block table structure. > > > > @param[in] ConfigBlockTableAddress - A pointer to the beginning of > > Config Block Table Address > > @param[out] ConfigBlockAddress - On return, points to a pointer > to > > the beginning of Config Block Address @@ -94,7 +94,7 @@ > > AddConfigBlock ( } > > > > /** > > - Retrieve a specific Config Block data by GUID > > + Retrieve a specific Config Block data by GUID. > > > > @param[in] ConfigBlockTableAddress - A pointer to the beginning of > > Config Block Table Address > > @param[in] ConfigBlockGuid - A pointer to the GUID uses to > > search specific Config Block > > -- > > 2.17.1 > > > > > > > > > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-23 6:57 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-03-05 5:47 [edk2-platform][PATCH v2] IntelSiliconPkg: Add periods in comments GuoMinJ 2020-03-09 1:21 ` [edk2-devel] " Zhang, Shenglei 2020-03-23 6:15 ` Guomin Jiang 2020-03-23 6:56 ` Chaganty, Rangasai V
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox