From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web10.4486.1583992511443028937 for ; Wed, 11 Mar 2020 22:55:11 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: shenglei.zhang@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Mar 2020 22:55:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,543,1574150400"; d="scan'208";a="234924761" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga007.fm.intel.com with ESMTP; 11 Mar 2020 22:55:10 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 11 Mar 2020 22:55:10 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 11 Mar 2020 22:55:09 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 11 Mar 2020 22:55:09 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.206]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.155]) with mapi id 14.03.0439.000; Thu, 12 Mar 2020 13:49:15 +0800 From: "Zhang, Shenglei" To: "devel@edk2.groups.io" , "newexplorerj@gmail.com" CC: "Wang, Jian J" , "Lu, XiaoyuX" Subject: Re: [edk2-devel] [PATCH v2 1/2] CryptoPkg/BaseCryptLibOnProtocolPpi: Add missing comments Thread-Topic: [edk2-devel] [PATCH v2 1/2] CryptoPkg/BaseCryptLibOnProtocolPpi: Add missing comments Thread-Index: AQHV8rkqx7CiYfK52k2Amjs/tt6GoKhEfkTQ Date: Thu, 12 Mar 2020 05:49:15 +0000 Message-ID: References: <2731dd841ca22bf605f0c115ff779cb1e6f7b926.1583390439.git.newexplorerj@gmail.com> In-Reply-To: <2731dd841ca22bf605f0c115ff779cb1e6f7b926.1583390439.git.newexplorerj@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: shenglei.zhang@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Shenglei Zhang > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > GuoMinJ > Sent: Thursday, March 5, 2020 2:41 PM > To: devel@edk2.groups.io > Cc: GuoMinJ ; Wang, Jian J > ; Lu, XiaoyuX > Subject: [edk2-devel] [PATCH v2 1/2] CryptoPkg/BaseCryptLibOnProtocolPpi= : > Add missing comments >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2552 >=20 > DxeCryptLibConstructor have no comments for it, add comments for it. >=20 > Cc: Jian J Wang > Cc: Xiaoyu Lu > Signed-off-by: GuoMinJ > --- > .../Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c | 9 +++++++++ > 1 file changed, 9 insertions(+) >=20 > diff --git a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c > b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c > index 34d5f410b0..b503a5708b 100644 > --- a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c > +++ b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c > @@ -32,6 +32,15 @@ GetCryptoServices ( > return (VOID *)mCryptoProtocol; > } >=20 > +/** > + Locate the valid Crypto Protocol. > + > + @param ImageHandle The firmware allocated handle for the EFI image= . > + @param SystemTable A pointer to the EFI System Table. > + > + @retval EFI_SUCCESS The constructor executed correctly. > + @retval EFI_NOT_FOUND Found no valid Crypto Protocol. > +**/ > EFI_STATUS > EFIAPI > DxeCryptLibConstructor ( > -- > 2.17.1 >=20 >=20 >=20