public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Zhang, Shenglei" <shenglei.zhang@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"newexplorerj@gmail.com" <newexplorerj@gmail.com>
Cc: "Wang, Jian J" <jian.j.wang@intel.com>,
	"Lu, XiaoyuX" <xiaoyux.lu@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 2/2] CryptoPkg/BaseHashApiLib: Rename BaseHashApiLib by HashApiLib
Date: Thu, 12 Mar 2020 05:53:19 +0000	[thread overview]
Message-ID: <C0706E73DB8C124D9B9C38AA364E5D5E060447D1@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <bc1af978c4bebee6a49fc1e77898b77f3b586798.1583390439.git.newexplorerj@gmail.com>

Reviewed-by: Shenglei Zhang <shenglei.zhang@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> GuoMinJ
> Sent: Thursday, March 5, 2020 2:41 PM
> To: devel@edk2.groups.io
> Cc: GuoMinJ <newexplorerj@gmail.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Lu, XiaoyuX <xiaoyux.lu@intel.com>
> Subject: [edk2-devel] [PATCH v2 2/2] CryptoPkg/BaseHashApiLib: Rename
> BaseHashApiLib by HashApiLib
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2552
> 
> According to CryptoPkg.dsc, the library class only have HashApiLib, so i
> think the BaseHashApiLib should be considered as base name rather than
> library class.
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
> ---
>  CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
> b/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
> index b4d8675ddd..046320353b 100644
> --- a/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
> +++ b/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
> @@ -17,7 +17,7 @@
>    FILE_GUID                      = B1E566DD-DE7C-4F04-BDA0-B1295D3BE927
>    MODULE_TYPE                    = BASE
>    VERSION_STRING                 = 1.0
> -  LIBRARY_CLASS                  = BaseHashApiLib
> +  LIBRARY_CLASS                  = HashApiLib
> 
>  #
>  # The following information is for reference only and not required by the
> build tools.
> --
> 2.17.1
> 
> 
> 


  reply	other threads:[~2020-03-12  5:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-05  6:40 [PATCH v2 1/2] CryptoPkg/BaseCryptLibOnProtocolPpi: Add missing comments GuoMinJ
2020-03-05  6:40 ` [PATCH v2 2/2] CryptoPkg/BaseHashApiLib: Rename BaseHashApiLib by HashApiLib GuoMinJ
2020-03-12  5:53   ` Zhang, Shenglei [this message]
2020-03-17  0:16     ` [edk2-devel] " Liming Gao
2020-03-27  9:23   ` Xiaoyu Lu
2020-03-12  5:49 ` [edk2-devel] [PATCH v2 1/2] CryptoPkg/BaseCryptLibOnProtocolPpi: Add missing comments Zhang, Shenglei
2020-03-17  0:14   ` Liming Gao
2020-03-27  9:23 ` Xiaoyu Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C0706E73DB8C124D9B9C38AA364E5D5E060447D1@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox