public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* How to add ignore "IgnoreFiles" for CharEncodingCheck
@ 2020-03-31 15:52 Zhang, Shenglei
  2020-04-01  0:30 ` [edk2-devel] " Sean
  0 siblings, 1 reply; 2+ messages in thread
From: Zhang, Shenglei @ 2020-03-31 15:52 UTC (permalink / raw)
  To: Sean Brogan, devel@edk2.groups.io
  Cc: Kinney, Michael D, Gao, Liming, Zhang, Shenglei

[-- Attachment #1: Type: text/plain, Size: 621 bytes --]

Hi Sean,

I am introducing third party project oniguruma as submodule into edk2, and want to skip CharEncodingCheck for certain files in oniguruma.
I tried to add changes like below, but CI build failed.
"CharEncodingCheck": {
"IgnoreFiles": [[(MdeModulePkg/Universal/RegularExpressionDxe/oniguruma/test/testc.c),(MdeModulePkg/Universal/RegularExpressionDxe/oniguruma/windows/testc.c)]
}

So what should I do in CharEncodingCheck_plug_in.yaml? Or how do you handle this kind of case like openssl?

I see you add this to edk2 and hope you could resolve my query. Thanks in advance.

Best Regards,
Shenglei


[-- Attachment #2: Type: text/html, Size: 3551 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [edk2-devel] How to add ignore "IgnoreFiles" for CharEncodingCheck
  2020-03-31 15:52 How to add ignore "IgnoreFiles" for CharEncodingCheck Zhang, Shenglei
@ 2020-04-01  0:30 ` Sean
  0 siblings, 0 replies; 2+ messages in thread
From: Sean @ 2020-04-01  0:30 UTC (permalink / raw)
  To: Zhang, Shenglei, devel

[-- Attachment #1: Type: text/plain, Size: 598 bytes --]

On Tue, Mar 31, 2020 at 08:52 AM, Zhang, Shenglei wrote:

> 
> 
> 
> "CharEncodingCheck": {
> 
> 
> 
> "IgnoreFiles":
> [[(MdeModulePkg/Universal/RegularExpressionDxe/oniguruma/test/testc.c),(MdeModulePkg/Universal/RegularExpressionDxe/oniguruma/windows/testc.c)]
> 
> 
> 
> 
> }
> 
> 

This syntax works for me.  The logic isn't very complex as it is just a case sensitive string match.

"CharEncodingCheck": {
"IgnoreFiles": ["MdeModulePkg/Universal/RegularExpressionDxe/oniguruma/test/testc.c", "MdeModulePkg/Universal/RegularExpressionDxe/oniguruma/windows/testc.c"]
}

[-- Attachment #2: Type: text/html, Size: 874 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-04-01  0:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-31 15:52 How to add ignore "IgnoreFiles" for CharEncodingCheck Zhang, Shenglei
2020-04-01  0:30 ` [edk2-devel] " Sean

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox