From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.9848.1586755425115744770 for ; Sun, 12 Apr 2020 22:23:45 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: shenglei.zhang@intel.com) IronPort-SDR: sOfGovSl+p+YDGvjNTpTpD1lQHl5gwNuxq7fkgsV4OA9J1pXwGBSmyKMhZo/+xPwF6i6+o45g2 IYvM2NpaTDLQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2020 22:23:44 -0700 IronPort-SDR: /U37cWQTsyMhnrCrLpBj1/b3l5bJFoTODbfZa1721XJ2yLnSD9XP6+w1FqGnJBEl+1l9ieq7TS uhhvyaLwQ7Bw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,377,1580803200"; d="scan'208";a="331742018" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga001.jf.intel.com with ESMTP; 12 Apr 2020 22:23:36 -0700 Received: from fmsmsx162.amr.corp.intel.com (10.18.125.71) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 12 Apr 2020 22:23:36 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx162.amr.corp.intel.com (10.18.125.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 12 Apr 2020 22:23:35 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.225]) by shsmsx102.ccr.corp.intel.com ([169.254.2.138]) with mapi id 14.03.0439.000; Mon, 13 Apr 2020 13:23:33 +0800 From: "Zhang, Shenglei" To: "devel@edk2.groups.io" CC: "Gao, Liming" , "Zhang, Shenglei" Subject: Re: [PATCH v2] MdeModulePkg/RegularExpressionDxe: Make oniguruma a submodule in edk2. Thread-Topic: [PATCH v2] MdeModulePkg/RegularExpressionDxe: Make oniguruma a submodule in edk2. Thread-Index: AQHV9eRQ4lCiX5Q1hESS1it54nVCJahES4DQgDJuDCA= Date: Mon, 13 Apr 2020 05:23:33 +0000 Message-ID: References: <20200309072747.20316-1-shenglei.zhang@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: shenglei.zhang@intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable Hi all, With this patch checked in, you may meet build failure with MdeModulePkg. = Because the components in oniguruma can=1B$B!G=1B(Bt be found. Please try command " git submodule update --init" to check out the source c= ode before you build the package. Thanks, Shenglei > -----Original Message----- > From: Gao, Liming > Sent: Thursday, March 12, 2020 11:12 AM > To: Zhang, Shenglei ; devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A > Subject: RE: [PATCH v2] MdeModulePkg/RegularExpressionDxe: Make > oniguruma a submodule in edk2. >=20 > Reviewed-by: Liming Gao >=20 > -----Original Message----- > From: Zhang, Shenglei > Sent: 2020=1B$BG/=1B(B3=1B$B7n=1B(B9=1B$BF|=1B(B 15:28 > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Gao, Liming > Subject: [PATCH v2] MdeModulePkg/RegularExpressionDxe: Make > oniguruma a submodule in edk2. >=20 > Use submodule way to access oniguruma. And upgrade oniguruma > version from v6.9.3 to v6.9.4_mark1. > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2073 >=20 > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Liming Gao > Signed-off-by: Shenglei Zhang > --- >=20 > v2: Include wrapper files in RegularExpressionDxe.inf. > Patch link: https://github.com/shenglei10/edk2/commits/oniguruma >=20 > .../Oniguruma/OnigurumaUefiPort.c | 26 - > .../RegularExpressionDxe/Oniguruma/ascii.c | 118 - > .../Oniguruma/onig_init.c | 45 - > .../RegularExpressionDxe/Oniguruma/regcomp.c | 6972 ---- > .../RegularExpressionDxe/Oniguruma/regenc.c | 1029 - > .../RegularExpressionDxe/Oniguruma/regerror.c | 402 - > .../RegularExpressionDxe/Oniguruma/regexec.c | 5874 --- > .../RegularExpressionDxe/Oniguruma/reggnu.c | 131 - > .../RegularExpressionDxe/Oniguruma/regparse.c | 8461 ----- > .../Oniguruma/regposerr.c | 108 - > .../RegularExpressionDxe/Oniguruma/regposix.c | 304 - > .../Oniguruma/regsyntax.c | 336 - > .../RegularExpressionDxe/Oniguruma/regtrav.c | 76 - > .../Oniguruma/regversion.c | 57 - > .../RegularExpressionDxe/Oniguruma/st.c | 588 - > .../RegularExpressionDxe/Oniguruma/unicode.c | 1152 - > .../Oniguruma/unicode_egcb_data.c | 1374 - > .../Oniguruma/unicode_fold1_key.c | 2995 -- > .../Oniguruma/unicode_fold2_key.c | 222 - > .../Oniguruma/unicode_fold3_key.c | 133 - > .../Oniguruma/unicode_fold_data.c | 1522 - > .../Oniguruma/unicode_property_data.c | 30388 ---------------- > .../Oniguruma/unicode_property_data_posix.c | 5347 --- > .../Oniguruma/unicode_unfold_key.c | 3299 -- > .../Oniguruma/unicode_wb_data.c | 1023 - > .../RegularExpressionDxe/Oniguruma/utf16_le.c | 309 - > .../{Oniguruma =3D> }/OnigurumaIntrinsics.c | 1 + > .../RegularExpressionDxe/OnigurumaUefiPort.c | 90 + > .gitmodules | 3 + > .../RegularExpressionDxe/Oniguruma/AUTHORS | 1 - > .../RegularExpressionDxe/Oniguruma/COPYING | 26 - > .../RegularExpressionDxe/Oniguruma/README | 195 - > .../RegularExpressionDxe/Oniguruma/oniggnu.h | 87 - > .../Oniguruma/onigposix.h | 172 - > .../Oniguruma/oniguruma.h | 1014 - > .../RegularExpressionDxe/Oniguruma/regenc.h | 279 - > .../RegularExpressionDxe/Oniguruma/regint.h | 1117 - > .../RegularExpressionDxe/Oniguruma/regparse.h | 455 - > .../RegularExpressionDxe/Oniguruma/st.h | 69 - > .../{Oniguruma =3D> }/OnigurumaUefiPort.h | 44 +- > .../RegularExpressionDxe.h | 3 +- > .../RegularExpressionDxe.inf | 73 +- > .../Universal/RegularExpressionDxe/config.h | 9 + > .../Universal/RegularExpressionDxe/oniguruma | 1 + > .../Universal/RegularExpressionDxe/stdarg.h | 9 + > .../Universal/RegularExpressionDxe/stddef.h | 9 + > .../Universal/RegularExpressionDxe/stdio.h | 9 + > .../Universal/RegularExpressionDxe/stdlib.h | 9 + > .../Universal/RegularExpressionDxe/string.h | 9 + > 49 files changed, 230 insertions(+), 75745 deletions(-) > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/OnigurumaUe > fiPort.c > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/ascii.c > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/onig_init.c > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regcomp.c > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regenc.c > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regerror.c > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regexec.c > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/reggnu.c > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regparse.c > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regposerr.c > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regposix.c > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regsyntax.c > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regtrav.c > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regversion.c > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/st.c > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/unicode.c > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/unicode_egcb > _data.c > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/unicode_fold > 1_key.c > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/unicode_fold > 2_key.c > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/unicode_fold > 3_key.c > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/unicode_fold > _data.c > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/unicode_prop > erty_data.c > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/unicode_prop > erty_data_posix.c > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/unicode_unfo > ld_key.c > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/unicode_wb_ > data.c > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/utf16_le.c > rename MdeModulePkg/Universal/RegularExpressionDxe/{Oniguruma > =3D> }/OnigurumaIntrinsics.c (91%) > create mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/AUTHORS > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/COPYING > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/README > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/oniggnu.h > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/onigposix.h > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/oniguruma.h > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regenc.h > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regint.h > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regparse.h > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/st.h > rename MdeModulePkg/Universal/RegularExpressionDxe/{Oniguruma > =3D> }/OnigurumaUefiPort.h (62%) > create mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/config.h > create mode 160000 > MdeModulePkg/Universal/RegularExpressionDxe/oniguruma > create mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/stdarg.h > create mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/stddef.h > create mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/stdio.h > create mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/stdlib.h > create mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/string.h