From: "Zhang, Shenglei" <shenglei.zhang@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"ard.biesheuvel@arm.com" <ard.biesheuvel@arm.com>
Cc: "Gao, Liming" <liming.gao@intel.com>,
"Wang, Jian J" <jian.j.wang@intel.com>,
"Wu, Hao A" <hao.a.wu@intel.com>,
"Feng, Bob C" <bob.c.feng@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 0/2] Use submodule way to access brotli
Date: Mon, 20 Apr 2020 05:40:17 +0000 [thread overview]
Message-ID: <C0706E73DB8C124D9B9C38AA364E5D5E06060B5C@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <4ed0b0fd-ae8d-8571-e562-1a143280382f@arm.com>
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Ard Biesheuvel
> Sent: Thursday, April 16, 2020 5:37 PM
> To: devel@edk2.groups.io; Zhang, Shenglei <shenglei.zhang@intel.com>
> Cc: Gao, Liming <liming.gao@intel.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Feng, Bob C
> <bob.c.feng@intel.com>
> Subject: Re: [edk2-devel] [PATCH v2 0/2] Use submodule way to access brotli
>
> On 4/1/20 10:31 AM, Zhang, Shenglei via Groups.Io wrote:
> > Currently brotli is used and customized by edk2 in BaseTools
> > and MdeModulePkg. These two patches make brotli a submodule in
> > edk2.
> > https://bugzilla.tianocore.org/show_bug.cgi?id=2558
> > https://bugzilla.tianocore.org/show_bug.cgi?id=2559
> >
> > v2: Add submodule path in CISettings.py
> >
>
> So with this changes, we have two copies of the entire brotli repository
> in the source directory? Is that really necessary?
Yes, we have two copies. For now it is necessary, one for BaseTools and the other for MdeModulePkg.
Thanks,
Shenglei
>
>
>
next prev parent reply other threads:[~2020-04-20 5:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 8:31 [PATCH v2 0/2] Use submodule way to access brotli Zhang, Shenglei
2020-04-01 8:31 ` [PATCH v2 1/2] MdeModulePkg/BrotliCustomDecompressLib: Make brotli a submodule Zhang, Shenglei
2020-04-01 8:31 ` [PATCH v2 2/2] BaseTools: " Zhang, Shenglei
2020-04-03 4:37 ` [PATCH v2 0/2] Use submodule way to access brotli Liming Gao
2020-04-16 9:36 ` [edk2-devel] " Ard Biesheuvel
2020-04-20 5:40 ` Zhang, Shenglei [this message]
[not found] <1601A4F69BE77D29.8187@groups.io>
2020-04-16 2:04 ` Zhang, Shenglei
-- strict thread matches above, loose matches on Subject: below --
2020-03-09 6:32 Zhang, Shenglei
2020-03-12 3:23 ` [edk2-devel] " Bob Feng
[not found] ` <15FB703CEE67698D.25226@groups.io>
2020-03-17 0:27 ` Liming Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C0706E73DB8C124D9B9C38AA364E5D5E06060B5C@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox