From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-in25.apple.com (mail-out25.apple.com [17.171.2.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AF0CB20958BC0 for ; Wed, 6 Sep 2017 08:28:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; d=apple.com; s=mailout2048s; c=relaxed/simple; q=dns/txt; i=@apple.com; t=1504711860; h=From:Sender:Reply-To:Subject:Date:Message-id:To:Cc:MIME-version:Content-type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-reply-to:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ls6CVW6JXV5hC/54aJ3DgdgYuUXU4lh9I+SZy1h6lWQ=; b=gPyEcVdHOGpQt+bfhaSfznIzLkS6A+82/y2kvzmd51FzUYdLCn2MLE0EnsBJ0OSR bFeR5L1ZktzCaaH72GV/IU8eWWAmsUdd4azxnO6NeC3MU81GudSVoaXjpDuhWRJF dwHZX28CCbVY6n3D5Z0ClCOcWMArvlGs9Bde+xnUheFIV0IVY22xiOZrCRsXa0gX cYdMV6hJvCeUGn2RonJk74iiOShV0frQGRDjsmvNwHZEdpShAmg7d84hEa6TbHTI yo7AYpqS0ydDmhDCHW6o/6XB5CwzLBx7OkpzCF7UjAOVm4SFgisxj0DW2HUAq/XO mdPQCC8hu4DUhGSDkBrTDQ==; Received: from relay26.apple.com (relay26.apple.com [17.171.128.107]) (using TLS with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mail-in25.apple.com (Apple Secure Mail Relay) with SMTP id F7.6E.05744.4B410B95; Wed, 6 Sep 2017 08:31:00 -0700 (PDT) X-AuditID: 11ab0219-dacb19c000001670-eb-59b014b45990 Received: from ma1-mmpp-sz11.apple.com (ma1-mmpp-sz11.apple.com [17.171.128.33]) by relay26.apple.com (Apple SCV relay) with SMTP id 15.CB.30418.3B410B95; Wed, 6 Sep 2017 08:31:00 -0700 (PDT) MIME-version: 1.0 Received: from [17.234.155.105] by ma1-mmpp-sz11.apple.com (Oracle Communications Messaging Server 8.0.1.3.20170825 64bit (built Aug 25 2017)) with ESMTPSA id <0OVV007RK73LX370@ma1-mmpp-sz11.apple.com>; Wed, 06 Sep 2017 08:30:59 -0700 (PDT) Sender: afish@apple.com From: Andrew Fish Message-id: Date: Wed, 06 Sep 2017 08:30:56 -0700 In-reply-to: Cc: "edk2-devel@lists.01.org" To: Marvin H?user References: X-Mailer: Apple Mail (2.3273) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrCLMWRmVeSWpSXmKPExsUiuLohW3eLyIZIgxs97BZ7Dh1ltnj7/yq7 A5NH9+x/LB6bX79gDmCK4rJJSc3JLEst0rdL4Mr4232VqeCOacXb3q+MDYwndbsYOTkkBEwk fvzoYO5i5OIQEljPJHHm4y8WmMSFT++YIBKHGCW6z61jAknwCghK/Jh8D6yIWSBM4tb7S6wQ Rd8YJX6fOcsOkhAWEJd4d2YTM4jNJqAssWL+B3aIZhuJZ133WSBqrCUmNqxi7GLk4GARUJXY u4ELJMwpEC+xdOlqqPnmEjMufAHbKyKgJ7Hs6TuwuJBAnMT5qddYIQ6Vlbg1+xLYBxICC9gk rjz8yjiBUWgWkltnIbkVwtaS+P6oFSjOAWTLSxw8LwsR1pR4du8TO4StLfHk3QXWBYxsqxiF cxMzc3Qz84xM9RILCnJS9ZLzczcxgqOBSXIH49fXhocYBTgYlXh4dzBuiBRiTSwrrsw9xCjN waIkzjvTZX2kkEB6YklqdmpqQWpRfFFpTmrxIUYmDk6pBkZtbWvpS0Vca8SemhcFrndz6IvY 4WbNvebD5wnvs+fuzetXyH29IrWn//SO20LqrFpV2TvtJU5K2Jft/nNqd6rRBdXclX5r2NW+ szm9/bVT4GIsB+O/JduNQhdEOkkd/CnE+ubahJfpeTNW1Dw+Gf37FkNXguR29aZPNZLlHp/q P3eey6nua1RiKc5INNRiLipOBADSf36SZwIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrOLMWRmVeSWpSXmKPExsUiuLpBUXeLyIZIg5s3mS32HDrKbPH2/1V2 ByaP7tn/WDw2v37BHMAUxWWTkpqTWZZapG+XwJXxt/sqU8Ed04q3vV8ZGxhP6nYxcnJICJhI XPj0jqmLkYtDSOAQo0T3uXVMIAleAUGJH5PvsYDYzAJhErfeX2KFKPrGKPH7zFl2kISwgLjE uzObmEFsNgFliRXzP7BDNNtIPOu6zwJRYy0xsWEVYxcjBweLgKrE3g1cIGFOgXiJpUtXQ803 l5hx4QvYXhEBPYllT9+BxYUE4iTOT73GCnGorMSt2ZeYJzDyz0Jy3iwk50HYWhLfH7UCxTmA bHmJg+dlIcKaEs/ufWKHsLUlnry7wLqAkW0Vo2BRak5ipZGZXmJBQU6qXnJ+7iZGSPBm72A8 ec/sEKMAB6MSD+8Oxg2RQqyJZcWVucBA4mBWEuG9KQAU4k1JrKxKLcqPLyrNSS0+xCjNwaIk zqs/Y32kkEB6YklqdmpqQWoRTJaJg1OqgdHf2WK+Q75f9JHXcm1XZrwuuPtogq7KtfvZX+fM Xa4550FX8NstD4qvPVWpupHstCR2fuDP8gUdUZ8C6k2P3j/2TPeKZWXx4QktpWc3Pf6p1Lrg 8nJ/afb876tmTLnY8z5PQdP9AZvV5MqDay7ry765G3NcmOcw0/OlGU/DrztNauRQ5fn5+eB9 JZbijERDLeai4kQAPmP2V1oCAAA= X-Content-Filtered-By: Mailman/MimeDel 2.1.22 Subject: Re: PI 1.6: Issues within the SPI sections. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Sep 2017 15:28:11 -0000 Content-Type: text/plain; CHARSET=US-ASCII Content-Transfer-Encoding: 7BIT Marvin, There is a public forum for feedback. http://www.uefi.org/FWOSForum Thanks, Andrew Fish > On Sep 5, 2017, at 8:21 PM, Marvin H?user wrote: > > Dear UEFI contributors, > > I am not an UEFI contributor and hence cannot submit changes. Could somebody please take note of the following? > > > 1. I do not see EFI_SPI_TRANSACTION_TYPE defined anywhere. There is a list of names for possible values with descriptions (PI 1.6, Vol. 5, page 368), though not assigned to numerical values. The size of the type is unknown, as far as I can see. > 2. Some parameter names in the protocol descriptions are flawed (e.g. PI 1.6, Vol. 5, page 368: "Read Bytes", "Read Buffer"). > 3. Some protorype return types are flawed (e.g. PI 1.6, Vol. 5, page 367: "EFI STATUS" (space instead of underscore); page 364: "FI STATUS" (same as before, also "E" missing)). > 4. Some prototype parameter types are flawed (e.g. PI 1.6, Vol. 5, page 364: "EFI- LEGACY- SPI- FLASH- PROTOCOL"). > 5. Some status code descriptions are flawed (e.g. PI 1.6, Vol. 5, page 364: "BLocksToProtect" (capital "L")). > 6. Some formatations are flawed (e.g. PI 1.6, Vol. 5, page 358: multiple parameters in one line). > 7. Some function decorators are flawed (e.g. PI 1.6, Vol. 5, page 357: "In" (lower-case "n")). > 8. Some function parameter names are flawed (e.g. PI 1.6, Vol. 5, page 356: "LengthinBytes" (lower-case "i")). > 9. Some descriptions contain spaces in inappropiate places (e.g. PI 1.5, Vol. 5, page 349: "EFI_SPI_P ART"). > 10. Occasionally incorrect punctuation (e.g. PI 1.6, Vol. 5, page 346: "[...] SPI busses, The SPI bus layer [...]" (comma instead of period)). > 11. PI 1.6, Vol. 5, page 349: The description of "SpiPeripheralDriverGuid" speaks of a "Driversupported" routine. Is EFI_DRIVER_BINDING_PROTOCOL.Supported() meant by this? > 12. PI 1.6, Vol. 5, page 350: The description of "ChipSelectParameter" contains spaces, though they are barely noticable when having the PDF opened with the latest version of Acrobat DC. Can this be fixed? > 13. UEFI PI 1.6, Vol. 5, 18.2 contains a reference to "EDK2". Is this intended? > > Please note that this list is not complete. Maybe the entire section 18 should be reviewed again? > > Thank you in advance! > > Regards, > Marvin. > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel