From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from nwk-aaemail-lapp01.apple.com (nwk-aaemail-lapp01.apple.com [17.151.62.66]) by mx.groups.io with SMTP id smtpd.web12.34155.1598579479261799181 for ; Thu, 27 Aug 2020 18:51:19 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@apple.com header.s=20180706 header.b=mzQ/bJKv; spf=pass (domain: apple.com, ip: 17.151.62.66, mailfrom: afish@apple.com) Received: from pps.filterd (nwk-aaemail-lapp01.apple.com [127.0.0.1]) by nwk-aaemail-lapp01.apple.com (8.16.0.43/8.16.0.42) with SMTP id 07S1jNmN030567; Thu, 27 Aug 2020 18:50:27 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apple.com; h=from : message-id : content-type : mime-version : subject : date : in-reply-to : cc : to : references; s=20180706; bh=8l8QayX6zJ2aHNAP5+D8lz3eZr+ZHtYo8lvsLhX8sd0=; b=mzQ/bJKvQCBZDcDchAsih6hVraUC29LTM5lTKJsfS+QD8g2p8aqO7+hguU9oMWcbi54L gONoj+qNZagE9ypgXKVqIV7dNRfsRiiIoAISIgNrMFwClWamkZwM6++KDCkVB+mNVVQb u2vr+3BsVGK3QIEn2KXP5ZXxmUMZqyaBUXoOyH17oEXUJeFw+7FyYUELSIpHtQNVnFI/ BcILYrwHXh79Ev+7hf7jG6OKb9jrTFmsJfW7Wsp0uORs1C6fWmJfby4//sMDpIwsKC0s 1VMO2o9X9EuBZ37kK72J5Ria/9vPbQwl3jiqyJJrWCuK+9TX3MnxrW42eyoW+1w9XkmY Ew== Received: from rn-mailsvcp-mta-lapp01.rno.apple.com (rn-mailsvcp-mta-lapp01.rno.apple.com [10.225.203.149]) by nwk-aaemail-lapp01.apple.com with ESMTP id 3332a0cu8p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Thu, 27 Aug 2020 18:50:27 -0700 Received: from rn-mailsvcp-mmp-lapp02.rno.apple.com (rn-mailsvcp-mmp-lapp02.rno.apple.com [17.179.253.15]) by rn-mailsvcp-mta-lapp01.rno.apple.com (Oracle Communications Messaging Server 8.1.0.6.20200729 64bit (built Jul 29 2020)) with ESMTPS id <0QFR00CSS3S38G40@rn-mailsvcp-mta-lapp01.rno.apple.com>; Thu, 27 Aug 2020 18:50:27 -0700 (PDT) Received: from process_milters-daemon.rn-mailsvcp-mmp-lapp02.rno.apple.com by rn-mailsvcp-mmp-lapp02.rno.apple.com (Oracle Communications Messaging Server 8.1.0.6.20200729 64bit (built Jul 29 2020)) id <0QFR00L002XKR400@rn-mailsvcp-mmp-lapp02.rno.apple.com>; Thu, 27 Aug 2020 18:50:27 -0700 (PDT) X-Va-A: X-Va-T-CD: 36e7a95c5a6048d9c36308b131fa87c1 X-Va-E-CD: 6340f00d2530f1f3dce2a7a4bdb30e46 X-Va-R-CD: d2cf8717909ab5ea825a814333252c2f X-Va-CD: 0 X-Va-ID: c3fc0db9-522f-4130-9077-018f5b9b82cd X-V-A: X-V-T-CD: 36e7a95c5a6048d9c36308b131fa87c1 X-V-E-CD: 6340f00d2530f1f3dce2a7a4bdb30e46 X-V-R-CD: d2cf8717909ab5ea825a814333252c2f X-V-CD: 0 X-V-ID: 9551615f-364c-4a6f-98c4-183d565afcf5 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-08-27_14:2020-08-27,2020-08-27 signatures=0 Received: from [17.235.53.32] (unknown [17.235.53.32]) by rn-mailsvcp-mmp-lapp02.rno.apple.com (Oracle Communications Messaging Server 8.1.0.6.20200729 64bit (built Jul 29 2020)) with ESMTPSA id <0QFR00EA63S1HQ00@rn-mailsvcp-mmp-lapp02.rno.apple.com>; Thu, 27 Aug 2020 18:50:26 -0700 (PDT) From: "Andrew Fish" Message-id: MIME-version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Correcting EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT definition Date: Thu, 27 Aug 2020 18:50:25 -0700 In-reply-to: <001901d67cd6$40ca65a0$c25f30e0$@byosoft.com.cn> Cc: edk2-devel-groups-io , paul.grimes@amd.com, Leif Lindholm , Laszlo Ersek , Mike Kinney , Zhiguang Liu To: gaoliming References: <20200827204051.777-1-Paul.Grimes@amd.com> <20200827204051.777-2-Paul.Grimes@amd.com> <001901d67cd6$40ca65a0$c25f30e0$@byosoft.com.cn> X-Mailer: Apple Mail (2.3608.80.23.2.2) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-08-27_14:2020-08-27,2020-08-27 signatures=0 Content-type: multipart/alternative; boundary="Apple-Mail=_B7E3FBA7-D671-4032-8B71-8FDD9883EE0B" --Apple-Mail=_B7E3FBA7-D671-4032-8B71-8FDD9883EE0B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Liming, Sounds like a good thing to get into the stable tag. Thanks, Andrew Fish > On Aug 27, 2020, at 5:57 PM, gaoliming wrote: >=20 > Paul: > This is a clear issue. Thanks for your reporting it. I would like to ca= tch > the fix into this stable tag 202008.=20 > Reviewed-by: Liming Gao > >=20 > Thanks > Liming >> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- >> =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+64705+4905953+8761045@groups.= io >> > =E4=BB=A3=E8=A1=A8 Paul >> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B48=E6=9C=8828=E6=97= =A5 4:41 >> =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io >> =E6=8A=84=E9=80=81: Michael D Kinney >; Liming Gao >> >; Zhiguang = Liu > >> =E4=B8=BB=E9=A2=98: [edk2-devel] [PATCH v1 1/1] MdePkg: Correcting >> EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT definition >>=20 >> In Acpi10.h, EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT is defined as 0x10, >> but should be 0x02 per the ACPI Specification. >>=20 >> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2937 >>=20 >> Cc: Michael D Kinney >> Cc: Liming Gao >> Cc: Zhiguang Liu >> Signed-off-by: Paul G >> --- >> MdePkg/Include/IndustryStandard/Acpi10.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >>=20 >> diff --git a/MdePkg/Include/IndustryStandard/Acpi10.h >> b/MdePkg/Include/IndustryStandard/Acpi10.h >> index fa06eefbb6e6..adeb5ae8c219 100644 >> --- a/MdePkg/Include/IndustryStandard/Acpi10.h >> +++ b/MdePkg/Include/IndustryStandard/Acpi10.h >> @@ -358,7 +358,7 @@ typedef struct { >> #define EFI_ACPI_DMA_TRANSFER_TYPE_MASK 0x03 >>=20 >>=20 >> #define EFI_ACPI_DMA_TRANSFER_TYPE_8_BIT 0x00 >>=20 >>=20 >> #define EFI_ACPI_DMA_TRANSFER_TYPE_8_BIT_AND_16_BIT 0x01 >>=20 >>=20 >> -#define EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT 0x10 >>=20 >>=20 >> +#define EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT 0x02 >>=20 >>=20 >>=20 >>=20 >>=20 >> // >>=20 >>=20 >> // IO Information >>=20 >>=20 >> -- >> 2.21.0 >>=20 >>=20 >>=20 --Apple-Mail=_B7E3FBA7-D671-4032-8B71-8FDD9883EE0B Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 Liming,
Sounds like a good thing to get into the= stable tag.

Than= ks,

Andrew Fish

On Aug 27, 2020, at 5:57 PM, gaoliming <gaoliming@byosoft.com.cn> wrote:
Paul:
 This is a clear iss= ue. Thanks for your reporting it. I would like to catch
the fix into this stable tag 202008. 
 Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

Thanks
Liming
-----=E9=82=AE=E4=BB=B6=E5=8E= =9F=E4=BB=B6-----
=E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+64705+4905953+8761045@gro= ups.io
<bounce+27952+64705+4905953+8761045@groups.io> =E4=BB=A3=E8=A1=A8 Paul
=E5=8F=91=E9=80=81=E6=97=B6=E9= = =97=B4: 2020=E5=B9=B48=E6=9C=8828=E6=97=A5 4:41
=E6=94=B6=E4= = =BB=B6=E4=BA=BA: devel@edk2.groups.io
=E6=8A=84=E9=80=81: Michael D Kinney <michael.d.kinney@intel.com>; Liming = Gao
<gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>
=E4=B8=BB=E9=A2=98: [edk2-devel] [PATCH v1 1/1] MdePkg: Correcting
EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT definition

In Acpi10.h, EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT is defined as 0x10,but should be 0x02 per the ACPI Specification.
<= br class=3D"">REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2937<= /a>

Cc: Michael D Kinney <michael.d.kinney@intel.com><= br class=3D"">Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Li= u <zhiguang.liu@int= el.com>
Signed-off-by: Paul G <paul.grimes@amd.com>
---=
MdePkg/Include/IndustryStandard/Acpi10.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdePkg/Include/IndustryStandard/Acpi10.h
b/Mde= Pkg/Include/IndustryStandard/Acpi10.h
index fa06eefbb6e6..ade= b5ae8c219 100644
--- a/MdePkg/Include/IndustryStandard/Acpi10= .h
+++ b/MdePkg/Include/IndustryStandard/Acpi10.h
@@ -358,7 +358,7 @@ typedef struct {
#define EFI_ACPI_DMA_= TRANSFER_TYPE_MASK          &n= bsp;      0x03

<= br class=3D"">#define   EFI_ACPI_DMA_TRANSFER_TYPE_8_BIT  &n= bsp;           0x00<= br class=3D"">

#define   EFI_ACPI_DM= A_TRANSFER_TYPE_8_BIT_AND_16_BIT   0x01


-#define   EFI_ACPI_DMA_TRANSFER_TYPE_16_BI= T             0= x10


+#define   EFI_AC= PI_DMA_TRANSFER_TYPE_16_BIT         = ;    0x02


<= br class=3D"">

//


// IO Information


--
2.21.0



--Apple-Mail=_B7E3FBA7-D671-4032-8B71-8FDD9883EE0B--