From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-in7.apple.com (mail-out7.apple.com [17.151.62.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 21F701A1E56 for ; Wed, 19 Oct 2016 17:11:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; d=apple.com; s=mailout2048s; c=relaxed/simple; q=dns/txt; i=@apple.com; t=1476922308; h=From:Sender:Reply-To:Subject:Date:Message-id:To:Cc:MIME-version:Content-type: Content-transfer-encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-reply-to:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=9UErYej6qvSd8lKBpg0RXK0AvDTGM41KJZA1Blq7Zmw=; b=nLoVcEcBNRs8lsZhpf4ErtKVZlp1X22XsK8wgLelwJov9t3mCQw1vTYAIPjsWmCS y3syf63iiJwnefgUAyRYTOxgDxWlvW/yZU7V1m6fNS4U5+XP6RYrB3LZKxIN70H9 HNVwhDjFk961KxhIq07Ug3l0lyqFRCRJ8q/GHQDZ35Li7E75lUUztgxqNR3xPsWI WJ53iCxM+0/HDIUwWNVLlL80f/LW8/ibx0R59TOKGFBVrQ2oqvSTTJ3bLQl/jHsH aQ0sgigXCx4kCrb2e3HHDWk74EwXeHsIJOWssgne4LR9NdSkWUah78Y9KWN1NDvK kiBQ22TRN+uX3/79yIWN/A==; Received: from relay3.apple.com (relay3.apple.com [17.128.113.83]) by mail-in7.apple.com (Apple Secure Mail Relay) with SMTP id 6B.0A.07050.4CB08085; Wed, 19 Oct 2016 17:11:48 -0700 (PDT) X-AuditID: 11973e16-e7d8d9a000001b8a-26-58080bc4eaec Received: from nwk-mmpp-sz08.apple.com (nwk-mmpp-sz08.apple.com [17.128.115.25]) by relay3.apple.com (Apple SCV relay) with SMTP id 97.D1.13773.4CB08085; Wed, 19 Oct 2016 17:11:48 -0700 (PDT) MIME-version: 1.0 Received: from [17.114.152.106] by nwk-mmpp-sz08.apple.com (Oracle Communications Messaging Server 8.0.1.1.0 64bit (built Jun 15 2016)) with ESMTPSA id <0OFB00DPCKJOXH10@nwk-mmpp-sz08.apple.com>; Wed, 19 Oct 2016 17:11:48 -0700 (PDT) Sender: afish@apple.com From: Andrew Fish In-reply-to: Date: Wed, 19 Oct 2016 17:11:47 -0700 Cc: "edk2-devel@lists.01.org" Message-id: References: <35C6824F-AF9E-45D2-B380-17E9547411F1@apple.com> To: Sean Brogan X-Mailer: Apple Mail (2.3226) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrBLMWRmVeSWpSXmKPExsUi2FAYrHuEmyPCYNEcJYs9h44yWyx8tJnZ gcmje/Y/Fo/WHX/ZA5iiuGxSUnMyy1KL9O0SuDJObf7EUvBBu+Lz8jb2BsavSl2MHBwSAiYS m15zdTFycQgJ7GWU6Hw2g7mLkRMsvvHFAWaIxEFGiZU/GlhBErwCghI/Jt9jAWlmFpCXOHhe FiTMLKAl8f1RKwtE/XtGia9Tl7CAJIQFxCXendnEDGEHSFx9tokdxGYTUJZYMf8DmM0pEC/x cFknE4jNIqAqcXnDa3aIoeYSMy58YQLZxStgI7GmvRRi/hNGiWvnn4PNFxHQlrj8eTUTxDOy ErN/eUHcv4VN4sF8tgmMwrOQXD0L4epZSK5ewMi8ilEoNzEzRzczz1wvsaAgJ1UvOT93EyMo qKfbie1gfLjK6hCjAAejEg9vxjn2CCHWxLLiytxDjNIcLErivNUb2CKEBNITS1KzU1MLUovi i0pzUosPMTJxcEo1MKZpeLyt9vjyYXb2uhelIssYZPXuz1bijjTx+85r3n1LZFHGVv2Lq+7L Jzlyce5225YUmxA9Y8NbybxKxpaGX1fNjZqSz55a+1i84duhb8z3Avn3Odswv69+euRuX90H I90lfPuPlvCeV3R7szLxXI20mVJ0dYdeY3i2Wq+zdfOS7feMTzlYKLEUZyQaajEXFScCAJWD xzJLAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpkkeLIzCtJLcpLzFFi42IRbCiW1D3CzRFhMGeCrMWeQ0eZLRY+2szs wOTRPfsfi0frjr/sAUxRXDYpqTmZZalF+nYJXBmnNn9iKfigXfF5eRt7A+NXpS5GTg4JAROJ jS8OMEPYYhIX7q1n62Lk4hASOMgosfJHAytIgldAUOLH5HssXYwcHMwC8hIHz8uChJkFtCS+ P2plgah/zyjxdeoSFpCEsIC4xLszm5gh7ACJq882sYPYbALKEivmfwCzOQXiJR4u62QCsVkE VCUub3jNDjHUXGLGhS9MILt4BWwk1rSXQsx/wihx7fxzsPkiAtoSlz+vBquREJCVmP3LawKj 4Cwkl85CuHQWkksXMDKvYhQoSs1JrDTWSywoyEnVS87P3cQIDtDC4B2Mf5ZZHWIU4GBU4uHN OMceIcSaWFZcmXuIUYKDWUmEd8oGoBBvSmJlVWpRfnxRaU5q8SHGZKDzJzJLiSbnA6MnryTe 0MTEwMTY2MzY2NzEnDRhJXFe/mdAKwTSE0tSs1NTC1KLYLYwcXBKNTDmL9oyrT4oJ/rK/NqE 9Uu/mroe4u8448zqtTg6hnXxUpdrn2qOqfVcyN3hOXX7O4Niuz1Cv1a93jD3+plfMW93XWhb 1Zx5a7mL53VzAdG81Z3NHI/s5bnyhCYefzJl9uOFQV8ZtCY7OPW9SrudzRF/7u61E0/jJhjN 12eY2dnVdNBGxDHD03aWEktxRqKhFnNRcSIAhXxJspQCAAA= Subject: Re: question about a compressed Ffs3 file inside FFS2 filesystem X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2016 00:11:49 -0000 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII > On Oct 19, 2016, at 4:59 PM, Sean Brogan wrote: > > Yes. I think the challenge in the code is the compressed section is a guided section and the decompression is all handled transparently. > One solution might be that once a section was processed that had attributes of EFI_GUIDED_SECTION_PROCESSING_REQUIRED then the check for filesystems should no longer be performed. > That seems reasonable. Lets see what other people think. We can also, independently, bring it up at the UEFI Forum to see if we need to clarify the PI spec. Thanks, Andrew Fish > Thanks > Sean > > >> -----Original Message----- >> From: afish@apple.com [mailto:afish@apple.com] >> Sent: Wednesday, October 19, 2016 4:40 PM >> To: Sean Brogan >> Cc: edk2-devel@lists.01.org >> Subject: Re: [edk2] question about a compressed Ffs3 file inside FFS2 >> filesystem >> >> >>> On Oct 19, 2016, at 4:09 PM, Sean Brogan >> wrote: >>> >>> We have a condition that occurs when we boot where we see the following >> message and our boot fails because of it. >>> DEBUG ((EFI_D_ERROR, "Found a FFS3 formatted section in a non-FFS3 >>> formatted FV.\n")); >>> >>> Which is on line 773 of FwVol.c ( >>> >> https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Core/Pei/ >> Fw >>> Vol/FwVol.c ) >>> >>> The condition is caused by a large firmware volume (greater than 16mb) >> that is compressed and put into a smaller FV (less than 16mb). My question >> is why isn't this allowed (seems like a valid scenario). Volinfo supports this >> and decodes binary fine. The PI Vol 3 spec has a section 3.2.2 >> EFI_FIRMWARE_FILE_SYSTEM3_GUID which says FileSystem2 doesn't >> support large files but it seems that the code is not taking into account that >> the section is compressed and therefore you can have a large file inside a >> compressed section inside a FV with File System2. >>> >>> Feedback/thoughts/comments/Bug? >>> >> >> Sean, >> >> If I understand correctly you are stating that the contents of an Encapsulation >> section should not have any restrictions on content type. The only error >> checking should be that the raw encapsulation section data needs to fit into >> the file type. That seems reasonable to me? I'm not sure if the PI spec makes >> some statement that the code is enforcing, or I guess the PI spec could be >> vague and people are interpreting it differently. >> >> Thanks, >> >> Andrew Fish >> >>> Here are some details of my scenario. >>> Compressed FV has filesystem == 8c8ce578-8a3d-4f1c-9935-896185c32dd3 >>> (ffs3) Non compressed FV has filesystem == >>> 5473c07a-3dcb-4dca-bd6f-1e9689e7349a (ffs2) >>> >>> VolInfo dump of the Non Compressed FV showing the nested/compressed >> FV inside. >>> >>> Decoding >>> VolInfo Version 1.0 Build Build 20909 >>> Signature: _FVH (4856465F) >>> Attributes: 4FEFF >>> EFI_FVB2_READ_DISABLED_CAP >>> EFI_FVB2_READ_ENABLED_CAP >>> EFI_FVB2_READ_STATUS >>> EFI_FVB2_WRITE_DISABLED_CAP >>> EFI_FVB2_WRITE_ENABLED_CAP >>> EFI_FVB2_WRITE_STATUS >>> EFI_FVB2_LOCK_CAP >>> EFI_FVB2_LOCK_STATUS >>> EFI_FVB2_STICKY_WRITE >>> EFI_FVB2_MEMORY_MAPPED >>> EFI_FVB2_ERASE_POLARITY >>> EFI_FVB2_READ_LOCK_CAP >>> EFI_FVB2_READ_LOCK_STATUS >>> EFI_FVB2_WRITE_LOCK_CAP >>> EFI_FVB2_WRITE_LOCK_STATUS >>> EFI_FVB2_ALIGNMENT_16 >>> EFI_FVB2_ALIGNMENT_32 >>> EFI_FVB2_ALIGNMENT_64 >>> EFI_FVB2_ALIGNMENT_128 >>> EFI_FVB2_ALIGNMENT_4K >>> EFI_FVB2_ALIGNMENT_8K >>> EFI_FVB2_ALIGNMENT_16K >>> EFI_FVB2_ALIGNMENT_32K >>> EFI_FVB2_ALIGNMENT_1M >>> EFI_FVB2_ALIGNMENT_2M >>> EFI_FVB2_ALIGNMENT_4M >>> EFI_FVB2_ALIGNMENT_8M >>> EFI_FVB2_ALIGNMENT_256M >>> EFI_FVB2_ALIGNMENT_512M >>> EFI_FVB2_ALIGNMENT_1G >>> EFI_FVB2_ALIGNMENT_2G >>> Header Length: 0x00000048 >>> File System ID: 5473c07a-3dcb-4dca-bd6f-1e9689e7349a >>> Revision: 0x0002 >>> Number of Blocks: 0x00000028 >>> Block Length: 0x00010000 >>> Total Volume Size: 0x00280000 >>> >> ========================================================== >> == >>> File Name: 9E21FD93-9C72-4C15-8C4B-E77F1DB2D792 >>> File Offset: 0x00000048 >>> File Length: 0x001F3FFD >>> File Attributes: 0x00 >>> File State: 0xF8 >>> EFI_FILE_DATA_VALID >>> File Type: 0x0B EFI_FV_FILETYPE_FIRMWARE_VOLUME_IMAGE >>> ------------------------------------------------------------ >>> Type: EFI_SECTION_GUID_DEFINED >>> Size: 0x001F3FE5 >>> SectionDefinitionGuid: ee4e5898-3914-4259-9d6e-dc7bd79403cf >>> >>> DataOffset: 0x0018 >>> Attributes: 0x0001 >>> ------------------------------------------------------------ >>> Type: EFI_SECTION_RAW >>> Size: 0x00000FF8 >>> ------------------------------------------------------------ >>> Type: EFI_SECTION_FIRMWARE_VOLUME_IMAGE >>> Size: 0x01010008 >>> >> ========================================================== >> == >>> >>> Thanks >>> Sean >>> _______________________________________________ >>> edk2-devel mailing list >>> edk2-devel@lists.01.org >>> https://lists.01.org/mailman/listinfo/edk2-devel > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel