From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.66]) by mx.groups.io with SMTP id smtpd.web11.25839.1683615992866704410 for ; Tue, 09 May 2023 00:06:33 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@posteo.de header.s=2017 header.b=QupTlkC0; spf=pass (domain: posteo.de, ip: 185.67.36.66, mailfrom: mhaeuser@posteo.de) Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 4A6D5240281 for ; Tue, 9 May 2023 09:06:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1683615991; bh=7Tv3UEpMA3n2nWEGQwuVsrTLhtfS0tvjQnpuNVwYQq4=; h=From:Subject:Date:Cc:To:From; b=QupTlkC0wHhXb591xi5OUauHL0uVY/5intG93eANqAaAAz+W/5pmNvHf2WQN+KmBS btS5vVqLDBrio+ddBjkR78JL3iyQIrLSjFpAz31mnozBXLkGJRNVCRAXGzzw4s+9gW 9gYq+bIEUOZEIaM0+CBIV7TUYAgWK9l2vz98m4shj3SR+A+XlB6E9VBxx7oRlyK3Gf I6wboXPDuY+2EZ4K7semYGW+LWz0scf9Y9HZX1J6dSV9/is4id9B2Ic+2Vq5wkuSQd 1ctTtvlcvWcij3MyL0wfJQo9RkC8iFZFiXnjw2nxlm/ROcIiGn4pRGjcgmHpEt8/9Z JJBrRvsHF8IYA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QFq2Z6Gzvz9rxB; Tue, 9 May 2023 09:06:30 +0200 (CEST) From: =?UTF-8?B?TWFydmluIEjDpHVzZXI=?= Mime-Version: 1.0 (1.0) Subject: Re: [PATCH 2/2] Ext4Pkg: Advertise CSUM_SEED as supported Date: Tue, 9 May 2023 07:06:30 +0000 Message-Id: References: <20230509004202.243859-2-pedro.falcato@gmail.com> Cc: devel@edk2.groups.io In-Reply-To: <20230509004202.243859-2-pedro.falcato@gmail.com> To: Pedro Falcato Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Reviewed-by: Marvin H=C3=A4user > On 9. May 2023, at 02:42, Pedro Falcato wrote: >=20 > =EF=BB=BFWe had added support for CSUM_SEED but accidentally forgot to adv= ertise > it in gSupportedIncompatFeat. This made it (erroneously) impossible to > mount CSUM_SEED filesystems. >=20 > Detected by attempting to mount a relatively new mkfs.ext4'd filesystem. >=20 > Cc: Marvin H=C3=A4user > Signed-off-by: Pedro Falcato > --- > Features/Ext4Pkg/Ext4Dxe/Superblock.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/Features/Ext4Pkg/Ext4Dxe/Superblock.c b/Features/Ext4Pkg/Ext4= Dxe/Superblock.c > index 3f56de93c105..604925b582c1 100644 > --- a/Features/Ext4Pkg/Ext4Dxe/Superblock.c > +++ b/Features/Ext4Pkg/Ext4Dxe/Superblock.c > @@ -1,7 +1,7 @@ > /** @file > Superblock managing routines >=20 > - Copyright (c) 2021 - 2022 Pedro Falcato All rights reserved. > + Copyright (c) 2021 - 2023 Pedro Falcato All rights reserved. > SPDX-License-Identifier: BSD-2-Clause-Patent > **/ >=20 > @@ -18,7 +18,7 @@ STATIC CONST UINT32 gSupportedIncompatFeat =3D > EXT4_FEATURE_INCOMPAT_64BIT | EXT4_FEATURE_INCOMPAT_DIRDATA | > EXT4_FEATURE_INCOMPAT_FLEX_BG | EXT4_FEATURE_INCOMPAT_FILETYPE | > EXT4_FEATURE_INCOMPAT_EXTENTS | EXT4_FEATURE_INCOMPAT_LARGEDIR | > - EXT4_FEATURE_INCOMPAT_MMP | EXT4_FEATURE_INCOMPAT_RECOVER; > + EXT4_FEATURE_INCOMPAT_MMP | EXT4_FEATURE_INCOMPAT_RECOVER | EXT4_FEATUR= E_INCOMPAT_CSUM_SEED; >=20 > // Future features that may be nice additions in the future: > // 1) Btree support: Required for write support and would speed up lookups= in large directories. > --=20 > 2.40.1 >=20