From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: jiewen.yao@intel.com) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Mon, 24 Jun 2019 15:58:42 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jun 2019 15:58:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,413,1557212400"; d="scan'208";a="172148119" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga002.jf.intel.com with ESMTP; 24 Jun 2019 15:58:40 -0700 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 24 Jun 2019 15:58:40 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 24 Jun 2019 15:58:40 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.33]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.173]) with mapi id 14.03.0439.000; Tue, 25 Jun 2019 06:58:38 +0800 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "lersek@redhat.com" CC: "Wu, Hao A" , "rfc@edk2.groups.io" , Andrew Fish , Leif Lindholm , "Kinney, Michael D" , "Wang, Jian J" , "Ni, Ray" , "Zeng, Star" Subject: Re: [edk2-devel] [RFC] Fine-grained review ownership for MdeModulePkg Thread-Topic: [edk2-devel] [RFC] Fine-grained review ownership for MdeModulePkg Thread-Index: AdUfX+yvPcbIWDrsTIaYM9h7G+B2QwAmE+IAAZUzdKAATHl31ACaGcOAAChHKAAAFfoR+A== Date: Mon, 24 Jun 2019 22:58:37 +0000 Message-ID: References: <20190611095150.l7vmqyn3ln4gmvyq@bivouac.eciton.net> <20190619093533.ueex63rrkovdhyz2@bivouac.eciton.net> ,<29f72258-7dea-ff96-ee5d-c9a09694ce52@redhat.com> In-Reply-To: <29f72258-7dea-ff96-ee5d-c9a09694ce52@redhat.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: MIME-Version: 1.0 Return-Path: jiewen.yao@intel.com Content-Language: zh-CN Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable thanks How about to put driversample to ui? How about to put iommu to device? thank you! Yao, Jiewen > =1B$B:_=1B(B 2019=1B$BG/=1B(B6=1B$B7n=1B(B25=1B$BF|!$>e8a=1B(B4:30=1B$B!= $=1B(BLaszlo Ersek =1B$B=20 >> On 06/24/19 03:16, Wu, Hao A wrote: >> Hello all, >>=20 >> With Leif's comment on the better usage of the wildcard character & 'X:= ' tag: >> https://edk2.groups.io/g/devel/message/42587 >>=20 >> The list is updated as shown below. >>=20 >> Also, I forgot to mention that some directory/file may be classified in= to >> multiple classes. I think it is a valid case, for example: >>=20 >> MdeModulePkg/Library/SmmMemoryAllocationProfileLib >>=20 >> matches both 'Memory Management' and 'SMM' sections: >>=20 >> Memory Management - F: MdeModulePkg/*Mem*/ >> SMM - F: MdeModulePkg/*Smm*/ >>=20 >> Then, reviewers from both classes should be Cc-ed when changes are made= in >> the above library. >>=20 >> If the updated list is good enough, the next step will be determining t= he >> reviewer(s) for each feature in the list. >=20 > I think it's good enough. :) >=20 > Thanks > Laszlo >=20 >>=20 >>=20 >> The updated list: >> ACPI: >> F: MdeModulePkg/Include/*/*Acpi*.h >> F: MdeModulePkg/Universal/Acpi/ >>=20 >> BDS: >> F: MdeModulePkg/*BootManager*/ >> X: MdeModulePkg/Application/BootManagerMenuApp/ >> F: MdeModulePkg/Include/Library/UefiBootManagerLib.h >> F: MdeModulePkg/Universal/BdsDxe/ >> F: MdeModulePkg/Universal/LoadFileOnFv2/ >> F: MdeModulePkg/Universal/SecurityStubDxe/Defer3rdPartyImageLoad.* >>=20 >> Console: >> F: MdeModulePkg/Include/Guid/ConnectConInEvent.h >> F: MdeModulePkg/Include/Guid/Console*.h >> F: MdeModulePkg/Include/Guid/StandardErrorDevice.h >> F: MdeModulePkg/Include/Guid/TtyTerm.h >> F: MdeModulePkg/Universal/Console/ >> X: MdeModulePkg/Universal/Console/GraphicsOutputDxe/ >>=20 >> Core (PEI, DXE and Runtime): >> F: MdeModulePkg/*SectionExtract*/ >> F: MdeModulePkg/Core/Dxe/ >> X: MdeModulePkg/Core/Dxe/Gcd/ >> X: MdeModulePkg/Core/Dxe/Mem/ >> F: MdeModulePkg/Core/DxeIplPeim/ >> F: MdeModulePkg/Core/Pei/ >> X: MdeModulePkg/Core/Pei/Memory/ >> X: MdeModulePkg/Core/Pei/PciCfg2/ >> X: MdeModulePkg/Core/Pei/Reset/ >> X: MdeModulePkg/Core/Pei/StatusCode/ >> F: MdeModulePkg/Core/RuntimeDxe/ >> F: MdeModulePkg/Include/Guid/Crc32GuidedSectionExtraction.h >> F: MdeModulePkg/Include/Guid/EventExitBootServiceFailed.h >> F: MdeModulePkg/Include/Guid/IdleLoopEvent.h >> F: MdeModulePkg/Include/Guid/LoadModuleAtFixedAddress.h >> F: MdeModulePkg/Include/Library/SecurityManagementLib.h >> F: MdeModulePkg/Library/DxeSecurityManagementLib/ >> F: MdeModulePkg/Universal/PlatformDriOverrideDxe/ >> F: MdeModulePkg/Universal/SecurityStubDxe/SecurityStub.c >>=20 >> Debug: >> F: MdeModulePkg/*Debug*/ >> X: MdeModulePkg/Universal/EbcDxe/EbcDebugger/ >> F: MdeModulePkg/Include/Guid/DebugMask.h >> F: MdeModulePkg/Include/Library/DebugAgentLib.h >> F: MdeModulePkg/Include/Ppi/Debug.h >>=20 >> Decompress: >> F: MdeModulePkg/Include/Guid/LzmaDecompress.h >> F: MdeModulePkg/Library/*Decompress*/ >>=20 >> Device: >> F: MdeModulePkg/*Serial*/ >> X: MdeModulePkg/Library/PlatformHookLibSerialPortPpi/ >> F: MdeModulePkg/Bus/ >> X: MdeModulePkg/Bus/Pci/IncompatiblePciDeviceSupportDxe/ >> X: MdeModulePkg/Bus/Pci/PciBusDxe/ >> X: MdeModulePkg/Bus/Pci/PciHostBridgeDxe/ >> F: MdeModulePkg/Include/*/*Ata*.h >> F: MdeModulePkg/Include/*/*NonDiscoverableDevice*.h >> F: MdeModulePkg/Include/*/*NvmExpress*.h >> F: MdeModulePkg/Include/*/*SerialPort*.h >> F: MdeModulePkg/Include/*/*SdMmc*.h >> F: MdeModulePkg/Include/*/*Ufs*.h >> F: MdeModulePkg/Include/*/*Usb*.h >> F: MdeModulePkg/Include/Guid/S3StorageDeviceInitList.h >> F: MdeModulePkg/Include/Guid/RecoveryDevice.h >> F: MdeModulePkg/Include/Ppi/StorageSecurityCommand.h >> F: MdeModulePkg/Include/Protocol/Ps2Policy.h >> F: MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/ >>=20 >> Disk: >> F: MdeModulePkg/Universal/Disk/ >>=20 >> EBC: >> F: MdeModulePkg/Include/*/*Ebc*.h >> F: MdeModulePkg/Include/Protocol/DebuggerConfiguration.h >> F: MdeModulePkg/Universal/EbcDxe/ >>=20 >> Firmware Update: >> F: MdeModulePkg/*Capsule*/ >> F: MdeModulePkg/Include/*/*Capsule*.h >> F: MdeModulePkg/Include/Library/DisplayUpdateProgressLib.h >> F: MdeModulePkg/Include/Library/FmpAuthenticationLib.h >> F: MdeModulePkg/Include/Protocol/EsrtManagement.h >> F: MdeModulePkg/Include/Protocol/FirmwareManagementProgress.h >> F: MdeModulePkg/Library/DisplayUpdateProgressLib*/ >> F: MdeModulePkg/Library/FmpAuthenticationLibNull/ >> F: MdeModulePkg/Universal/Esrt*/ >>=20 >> Graphic: >> F: MdeModulePkg/*Logo*/ >> F: MdeModulePkg/Include/*/*Logo*.h >> F: MdeModulePkg/Include/Library/BmpSupportLib.h >> F: MdeModulePkg/Include/Library/FrameBufferBltLib.h >> F: MdeModulePkg/Library/BaseBmpSupportLib/ >> F: MdeModulePkg/Library/FrameBufferBltLib/ >> F: MdeModulePkg/Universal/Console/GraphicsOutputDxe/ >>=20 >> HII/UI: >> F: MdeModulePkg/*FileExplorer*/ >> F: MdeModulePkg/*Hii*/ >> F: MdeModulePkg/*Ui*/ >> F: MdeModulePkg/Application/BootManagerMenuApp/ >> F: MdeModulePkg/Include/*/*FileExplorer*.h >> F: MdeModulePkg/Include/*/*FormBrowser*.h >> F: MdeModulePkg/Include/*/*Hii*.h >> F: MdeModulePkg/Include/Library/CustomizedDisplayLib.h >> F: MdeModulePkg/Include/Protocol/DisplayProtocol.h >> F: MdeModulePkg/Library/CustomizedDisplayLib/ >> F: MdeModulePkg/Universal/DisplayEngineDxe/ >> F: MdeModulePkg/Universal/SetupBrowserDxe/ >>=20 >> IPMI: >> F: MdeModulePkg/Include/*/*Ipmi*.h >> F: MdeModulePkg/Library/*Ipmi*/ >>=20 >> Memory Management: >> F: MdeModulePkg/*Mem*/ >> F: MdeModulePkg/Core/Dxe/Gcd/ >> F: MdeModulePkg/Include/*/*Mem*.h >> F: MdeModulePkg/Include/*/*IoMmu*.h >>=20 >> PCD: >> F: MdeModulePkg/Application/DumpDynPcd/ >> F: MdeModulePkg/Include/*/*Pcd*.h >> F: MdeModulePkg/Universal/PCD/ >>=20 >> PCI Bus: >> F: MdeModulePkg/*PciHostBridge*/ >> F: MdeModulePkg/Bus/Pci/IncompatiblePciDeviceSupportDxe/ >> F: MdeModulePkg/Bus/Pci/PciBusDxe/ >> F: MdeModulePkg/Core/Pei/PciCfg2/ >> F: MdeModulePkg/Include/Library/PciHostBridgeLib.h >> F: MdeModulePkg/Universal/PcatSingleSegmentPciCfg2Pei/ >>=20 >> Performance: >> F: MdeModulePkg/Include/*/*Perf*.h >> F: MdeModulePkg/Library/*Perf*/ >>=20 >> Reset: >> F: MdeModulePkg/*Reset*/ >> F: MdeModulePkg/Include/*/*Reset*.h >>=20 >> S3: >> F: MdeModulePkg/*LockBox*/ >> F: MdeModulePkg/Include/*/*BootScript*.h >> F: MdeModulePkg/Include/*/*LockBox*.h >> F: MdeModulePkg/Include/*/*S3*.h >> F: MdeModulePkg/Library/*S3*/ >>=20 >> SMBIOS: >> F: MdeModulePkg/Universal/Smbios*/ >>=20 >> SMM: >> F: MdeModulePkg/*Smi*/ >> F: MdeModulePkg/*Smm*/ >> F: MdeModulePkg/Include/*/*Smi*.h >> F: MdeModulePkg/Include/*/*Smm*.h >>=20 >> Status Code: >> F: MdeModulePkg/*StatusCode*/ >> F: MdeModulePkg/Include/*/*StatusCode*.h >>=20 >> Variable: >> F: MdeModulePkg/*Var*/ >> F: MdeModulePkg/Include/*/*FaultTolerantWrite*.h >> F: MdeModulePkg/Include/*/*Var*.h >> F: MdeModulePkg/Include/Guid/SystemNvDataGuid.h >> F: MdeModulePkg/Include/Protocol/SwapAddressRange.h >> F: MdeModulePkg/Universal/FaultTolerantWrite*/ >>=20 >> Misc: >> F: MdeModulePkg/Application/HelloWorld/ >> F: MdeModulePkg/Include/Guid/F: MdeModulePkgTokenSpace.h >> F: MdeModulePkg/Include/Guid/MtcVendor.h >> F: MdeModulePkg/Include/Guid/ZeroGuid.h >> F: MdeModulePkg/Include/Library/CpuExceptionHandlerLib.h >> F: MdeModulePkg/Include/Library/PlatformHookLib.h >> F: MdeModulePkg/Include/Library/RecoveryLib.h >> F: MdeModulePkg/Include/Library/SortLib.h >> F: MdeModulePkg/Include/Library/TpmMeasurementLib.h >> F: MdeModulePkg/Include/Protocol/Dpc.h >> F: MdeModulePkg/Include/Protocol/LoadPe32Image.h >> F: MdeModulePkg/Include/Protocol/PeCoffImageEmulator.h >> F: MdeModulePkg/Include/Protocol/Print2.h >> F: MdeModulePkg/Library/BaseHobLibNull/ >> F: MdeModulePkg/Library/BasePlatformHookLibNull/ >> F: MdeModulePkg/Library/BaseSortLib/ >> F: MdeModulePkg/Library/CpuExceptionHandlerLibNull/ >> F: MdeModulePkg/Library/DxePrintLibPrint2Protocol/ >> F: MdeModulePkg/Library/PeiRecoveryLibNull/ >> F: MdeModulePkg/Library/PlatformHookLibSerialPortPpi/ >> F: MdeModulePkg/Library/TpmMeasurementLibNull/ >> F: MdeModulePkg/Library/UefiSortLib/ >> F: MdeModulePkg/Universal/DevicePathDxe/ >> F: MdeModulePkg/Universal/DriverHealthManagerDxe/ >> F: MdeModulePkg/Universal/DriverSampleDxe/ >> F: MdeModulePkg/Universal/FvSimpleFileSystemDxe/ >> F: MdeModulePkg/Universal/LegacyRegion2Dxe/ >> F: MdeModulePkg/Universal/Metronome/ >> F: MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/ >> F: MdeModulePkg/Universal/PrintDxe/ >> F: MdeModulePkg/Universal/RegularExpressionDxe/ >> F: MdeModulePkg/Universal/TimestampDxe/ >> F: MdeModulePkg/Universal/WatchdogTimerDxe/ >>=20 >>=20 >> Best Regards, >> Hao Wu >>=20 >=20 >=20 >=20 >=20