Re: [PATCH 4/4] EdkCompatibilityPkg: remove PE/COFF header workaround for ELILO on IPF

From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Laszlo Ersek <lersek@redhat.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"Gao, Liming" <liming.gao@intel.com>,
	"Yao, Jiewen" <jiewen.yao@intel.com>,
	"Zeng, Star" <star.zeng@intel.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	"Zhang, Chao B" <chao.b.zhang@intel.com>
Subject: Re: [PATCH 4/4] EdkCompatibilityPkg: remove PE/COFF header workaround for ELILO on IPF
Date: Thu, 6 Sep 2018 18:01:07 +0000	[thread overview]
Message-ID: <C76D9188-857F-4F1E-A52C-5CFB38029644@intel.com> (raw)
In-Reply-To: <CAKv+Gu_njxx69QyUi72RJfd9V4fvrs02VMUS5k_hkPO9iKTTVw@mail.gmail.com>

We have a BZ to remove the compatibility package... I’d call updating it redundant and not worth your time.

Jaben

> On Sep 6, 2018, at 10:27 AM, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> 
>> On 6 September 2018 at 18:53, Laszlo Ersek <lersek@redhat.com> wrote:
>>> On 09/06/18 15:45, Ard Biesheuvel wrote:
>>> Now that Itanium support has been dropped, we can remove the various
>>> occurrences of the ELILO on Itanium PE/COFF header workaround.
>>> 
>>> Link: https://bugzilla.tianocore.org/show_bug.cgi?id=816
>>> Contributed-under: TianoCore Contribution Agreement 1.1
>>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>>> ---
>>> EdkCompatibilityPkg/Foundation/Library/EdkIIGlueLib/Library/BasePeCoffLib/BasePeCoff.c | 60 +++-----------------
>>> 1 file changed, 8 insertions(+), 52 deletions(-)
>> 
>> Should we care about EdkCompatibilityPkg at all? Because:
>> 
>> * IPF removal seems not to have occurred to EdkCompatibilityPkg:
>> 
>>  $ git grep -w IPF -- 'EdkCompatibilityPkg/*inf'
>>  [bunch of hits]
>> 
>> * In <https://bugzilla.tianocore.org/show_bug.cgi?id=816#c7>, you wrote:
>> 
>>> [...] there is a big difference between IPF drivers that are never
>>> referenced by modern platforms, and workarounds in generic code that
>>> are present in every modern build for every platform, and are only
>>> intended for a specific build of ELILO.
>> 
>>> The former is essentially dead code. The latter gets executed many
>>> times on every boot of every modern UEFI platform in existence.
>> 
>> Under that distinction, I would classify EdkCompatibilityPkg as the
>> first category, i.e., essentially dead code.
>> 
> 
> OK, fair enough. I don't care about EdkCompatibilityPkg at all, I just
> wanted to be thorough, but if others don't care either, I'll drop this
> from v2.
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel