From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 27B1D21121200 for ; Thu, 6 Sep 2018 11:01:13 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Sep 2018 11:01:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,339,1531810800"; d="scan'208";a="68088346" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga007.fm.intel.com with ESMTP; 06 Sep 2018 11:01:08 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 6 Sep 2018 11:01:08 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.126]) by FMSMSX154.amr.corp.intel.com ([169.254.6.197]) with mapi id 14.03.0319.002; Thu, 6 Sep 2018 11:01:07 -0700 From: "Carsey, Jaben" To: Ard Biesheuvel CC: Laszlo Ersek , "edk2-devel@lists.01.org" , "Gao, Liming" , "Yao, Jiewen" , "Zeng, Star" , "Kinney, Michael D" , "Zhang, Chao B" Thread-Topic: [edk2] [PATCH 4/4] EdkCompatibilityPkg: remove PE/COFF header workaround for ELILO on IPF Thread-Index: AQHURef2SdxNgaZftkK1CJGkqs9NKqTj7cEAgAAJfID//5QeAw== Date: Thu, 6 Sep 2018 18:01:07 +0000 Message-ID: References: <20180906134523.2036-1-ard.biesheuvel@linaro.org> <20180906134523.2036-5-ard.biesheuvel@linaro.org> <1687b7c4-4bce-d184-8e23-d156d3a4a9df@redhat.com>, In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: MIME-Version: 1.0 Subject: Re: [PATCH 4/4] EdkCompatibilityPkg: remove PE/COFF header workaround for ELILO on IPF X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Sep 2018 18:01:14 -0000 Content-Language: en-US Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable We have a BZ to remove the compatibility package... I=92d call updating it = redundant and not worth your time. Jaben > On Sep 6, 2018, at 10:27 AM, Ard Biesheuvel w= rote: >=20 >> On 6 September 2018 at 18:53, Laszlo Ersek wrote: >>> On 09/06/18 15:45, Ard Biesheuvel wrote: >>> Now that Itanium support has been dropped, we can remove the various >>> occurrences of the ELILO on Itanium PE/COFF header workaround. >>>=20 >>> Link: https://bugzilla.tianocore.org/show_bug.cgi?id=3D816 >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: Ard Biesheuvel >>> --- >>> EdkCompatibilityPkg/Foundation/Library/EdkIIGlueLib/Library/BasePeCoffL= ib/BasePeCoff.c | 60 +++----------------- >>> 1 file changed, 8 insertions(+), 52 deletions(-) >>=20 >> Should we care about EdkCompatibilityPkg at all? Because: >>=20 >> * IPF removal seems not to have occurred to EdkCompatibilityPkg: >>=20 >> $ git grep -w IPF -- 'EdkCompatibilityPkg/*inf' >> [bunch of hits] >>=20 >> * In , you wrot= e: >>=20 >>> [...] there is a big difference between IPF drivers that are never >>> referenced by modern platforms, and workarounds in generic code that >>> are present in every modern build for every platform, and are only >>> intended for a specific build of ELILO. >>=20 >>> The former is essentially dead code. The latter gets executed many >>> times on every boot of every modern UEFI platform in existence. >>=20 >> Under that distinction, I would classify EdkCompatibilityPkg as the >> first category, i.e., essentially dead code. >>=20 >=20 > OK, fair enough. I don't care about EdkCompatibilityPkg at all, I just > wanted to be thorough, but if others don't care either, I'll drop this > from v2. > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel