From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail2.protonmail.ch (mail2.protonmail.ch [185.70.40.22]) by mx.groups.io with SMTP id smtpd.web11.1611.1581494871764369418 for ; Wed, 12 Feb 2020 00:07:52 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@protonmail.com header.s=default header.b=cimrbnor; spf=pass (domain: protonmail.com, ip: 185.70.40.22, mailfrom: vit9696@protonmail.com) Date: Wed, 12 Feb 2020 08:07:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=default; t=1581494868; bh=Y305L+smMISo6EkQ2IlPB1aPOzGwyakx3FMXsxygcE0=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References: Feedback-ID:From; b=cimrbnor/Uti6sECcmEqN4yYSJy+RNE3mWTu8QvjjmvICDnjfk6JMrnenpaoP+efm zlA8AmXByZB9NQtyaTq2hS4Ehdlm3x9w/NAguCpWj6tkLcxiBrYYemVR4ppGXr0h2n 0KwVnEPSSu0d0xcxZBvjvGX8MQpfPBxD8ggY5n+c= To: "Liu, Zhiguang" From: "Vitaly Cheptsov" Cc: "devel@edk2.groups.io" , "Gao, Liming" , "Shi, Steven" Reply-To: vit9696 Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB Message-ID: In-Reply-To: <8ca1af8a17634df2875f352186dece12@intel.com> References: <20200210105919.19192-1-vit9696@protonmail.com> <20200210105919.19192-2-vit9696@protonmail.com> <7399fb4286314a9bb4c0378a6622b844@intel.com> <15F24239275957C5.19576@groups.io> <7ED61A40-41D8-46E6-A8E9-3C6555D50C0E@protonmail.com> <8ca1af8a17634df2875f352186dece12@intel.com> Feedback-ID: p9QuX-L1wMgUm6nrSvNrf8juLupNs0VSnzXGVXuYDxlEahFdWtaedWDMB9zpwGDklGt7kzs1-RBc0cqz327Gcg==:Ext:ProtonMail MIME-Version: 1.0 X-Spam-Status: No, score=-0.7 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,FREEMAIL_REPLYTO_END_DIGIT,HTML_FONT_LOW_CONTRAST, HTML_MESSAGE shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch X-Groupsio-MsgNum: 54272 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha256; boundary="---------------------eff5ab399da77c35027de962496c1671"; charset=UTF-8 -----------------------eff5ab399da77c35027de962496c1671 Cc: "devel@edk2.groups.io" , "Gao, Liming" , "Shi, Steven" Content-Type: multipart/alternative; boundary="Apple-Mail=_38F3A91B-88E9-49D8-92B2-86D7E5410D6F" Date: Wed, 12 Feb 2020 11:06:40 +0300 From: vit9696 In-Reply-To: <8ca1af8a17634df2875f352186dece12@intel.com> Message-Id: Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\)) References: <20200210105919.19192-1-vit9696@protonmail.com> <20200210105919.19192-2-vit9696@protonmail.com> <7399fb4286314a9bb4c0378a6622b844@intel.com> <15F24239275957C5.19576@groups.io> <7ED61A40-41D8-46E6-A8E9-3C6555D50C0E@protonmail.com> <8ca1af8a17634df2875f352186dece12@intel.com> Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB To: "Liu, Zhiguang" X-Mailer: Apple Mail (2.3608.60.0.2.5) --Apple-Mail=_38F3A91B-88E9-49D8-92B2-86D7E5410D6F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Liu, Thanks for explanation, it does make sense now. As for no need to -DNO_MSA= BI_VA_FUNCS I agree, but it will not make much difference, because from wha= t I understand the VA_ARG implementation is chosen based on EFIAPI presence= when generic __builtin=E2=80=99s are used. Best, Vitaly > 12 =D1=84=D0=B5=D0=B2=D1=80. 2020 =D0=B3., =D0=B2 04:38, Liu, Zhiguang <= zhiguang.liu@intel.com> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0): >=20 > Hi Vitaly, > After your patch to Switch to GNU mode for CLANGPDB, the build option -D= NO_MSABI_VA_FUNCS is not required. I will send another patch to remove it. > And for you question, this is a patch set that resolves BZ 2415, and the= second patch 21821933aea284cd3dfea6994bd4b83bd9739fc9 has direct influence= to CLANG38. > > Thanks > Zhiguang > > From: devel@edk2.groups.io > On Behalf Of Vitaly Cheptsov via Grou= ps.Io > Sent: Tuesday, February 11, 2020 3:09 PM > To: Gao, Liming >; Li= u, Zhiguang >; Shi, = Steven > > Cc: devel@edk2.groups.io > Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for = CLANGPDB > > Liming, > > Done. As a side note, I am not positive how can 7990438f1437f47990a8890d= ee51978cb8dbc25c[1] resolve BZ 2415[2]. The bug was about CLANG38, and the = toolchain updated was CLANGPDB. While it makes sense to update CLANGPDB wit= h this flag to stay clean (it will not make a difference for clang in GNU m= ode), CLANGPDB has nothing to do to CLANG38. > > Best wishes, > Vitaly > > [1] https://bugzilla.tianocore.org/show_bug.cgi?id=3D2415 > [2] https://github.com/tianocore/edk2/commit/7990438f1437f47990a8890dee5= 1978cb8dbc25c > >=20 >=20 > 11 =D1=84=D0=B5=D0=B2=D1=80. 2020 =D0=B3., =D0=B2 09:02, Gao, Liming > =D0=BD=D0=B0=D0=BF=D0=B8= =D1=81=D0=B0=D0=BB(=D0=B0): > > Vitaly: > Can you update this patch based on the latest edk2 trunk? I will catch= it for edk2 Q1 stable tag. > > Thanks > Liming > From: devel@edk2.groups.io > On Behalf Of Liming Gao > Sent: Tuesday, February 11, 2020 1:34 PM > To: vit9696 >; de= vel@edk2.groups.io > Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for = CLANGPDB > > Reviewed-by: Liming Gao > > > From: vit9696 >= =20 > Sent: Tuesday, February 11, 2020 3:23 AM > To: Gao, Liming >; de= vel@edk2.groups.io > Subject: RE: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for = CLANGPDB > > Liming, > > We did run several of our projects based on EDK II in X64 mode, DEBUG, R= ELEASE, NOOPT. Noticed no change from XCODE5. > > We also tried building several EDK builtin packages like CryptoPkg, MdeP= kg, MdeModulePkg. > > Best wishes, > Vitaly > > =D0=92 =D0=BF=D0=BD, =D1=84=D0=B5=D0=B2=D1=80. 10, 2020 =D0=B2 16:47, Ga= o, Liming > =D0=BF=D0=B8= = =D1=88=D0=B5=D1=82: > Vitaly: > This change is good. Can you your test for it? I verify this patch for O= vmf platform on Windows. It can make ovmf pass build with CLANGPDB. >=20 > Thanks > Liming > > -----Original Message----- > > From: devel@edk2.groups.io > On Behalf Of Vitaly Cheptsov via Gr= oups.Io > > Sent: Monday, February 10, 2020 6:59 PM > > To: devel@edk2.groups.io > > Subject: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CL= ANGPDB > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2397 > > > > Signed-off-by: Vitaly Cheptsov > > > --- > > BaseTools/Conf/tools_def.template | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_= def.template > > index feee2bbf16..6bf6c5768e 100755 > > --- a/BaseTools/Conf/tools_def.template > > +++ b/BaseTools/Conf/tools_def.template > > @@ -2755,11 +2755,11 @@ RELEASE_CLANG38_AARCH64_DLINK_FLAGS =3D DEF(CL= ANG38_AARCH64_DLINK_FLAGS) -flto -Wl > > DEFINE CLANGPDB_IA32_PREFIX =3D ENV(CLANG_BIN) > > DEFINE CLANGPDB_X64_PREFIX =3D ENV(CLANG_BIN) > > > > -DEFINE CLANGPDB_IA32_TARGET =3D -target i686-unknown-windows > > -DEFINE CLANGPDB_X64_TARGET =3D -target x86_64-unknown-windows > > +DEFINE CLANGPDB_IA32_TARGET =3D -target i686-unknown-windows-gnu > > +DEFINE CLANGPDB_X64_TARGET =3D -target x86_64-unknown-windows-gnu > > > > DEFINE CLANGPDB_WARNING_OVERRIDES =3D -Wno-parentheses-equality -Wno-t= autological-compare -Wno-tautological-constant-out- > > of-range-compare -Wno-empty-body -Wno-unused-const-variable -Wno-varar= gs -Wno-unknown-warning-option -Wno-microsoft-enum- > > forward-reference > > -DEFINE CLANGPDB_ALL_CC_FLAGS =3D DEF(GCC48_ALL_CC_FLAGS) DEF(CLANGPDB= _WARNING_OVERRIDES) -fno-stack-protector - > > mms-bitfields -Wno-address -Wno-shift-negative-value -Wno-unknown-prag= mas -Wno-incompatible-library-redeclaration -fno- > > asynchronous-unwind-tables -mno-implicit-float -ftrap-function=3Dundef= ined_behavior_has_been_optimized_away_by_clang - > > funsigned-char -fno-ms-extensions -Wno-null-dereference -fms-compatibi= lity -mno-stack-arg-probe > > +DEFINE CLANGPDB_ALL_CC_FLAGS =3D DEF(GCC48_ALL_CC_FLAGS) DEF(CLANGPDB= _WARNING_OVERRIDES) -fno-stack-protector - > > fno-asynchronous-unwind-tables -funsigned-char -ftrap-function=3Dundef= ined_behavior_has_been_optimized_away_by_clang -Wno- > > address -Wno-shift-negative-value -Wno-unknown-pragmas -Wno-incompatib= le-library-redeclaration -Wno-null-dereference -mno- > > implicit-float -mms-bitfields -mno-stack-arg-probe -nostdlib -nostdlib= inc > > > > ########################### > > # CLANGPDB IA32 definitions > > -- > > 2.21.1 (Apple Git-122.3) > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D > > Groups.io Links: You receive all messages sent to = this group. > > > > View/Reply Online (#54130): https://edk2.groups.io/g/devel/message/541= 30 > > Mute This Topic: https://groups.io/mt/71134286/1759384 > > Group Owner: devel+owner@edk2.groups.io > > Unsubscribe: https://edk2.groups.io/g/devel/unsub [liming.gao@intel.com ] > > -=3D-=3D-=3D-=3D-=3D-=3D >=20 > > > >=20 --Apple-Mail=_38F3A91B-88E9-49D8-92B2-86D7E5410D6F Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 Liu,

Thanks for explanation, it does make sense = now. As for no need to -DNO_MSABI_VA_FUNCS I agree, but it will not ma= ke much difference, because from what I understand the VA_ARG implementatio= n is chosen based on EFIAPI presence when generic __builtin=E2=80=99s are u= sed.

Best,
<= div class=3D"">Vitaly

12 =D1=84=D0=B5=D0=B2=D1=80. 2020 =D0=B3.= , =D0=B2 04:38, Liu, Zhiguang <zhiguang.liu@intel.com> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81= =D0=B0=D0=BB(=D0=B0):

Hi Vitaly,
After your patch to Switch to GNU mode for CLANGPD= B, the build option -DNO_MSABI_VA_FUNCS is not required. I will send anothe= r patch to remove it.
And for you question, this is a patch set that resolves BZ 2415, and the = second patch 21821933aea284cd3dfea6994bd4b83bd9739fc9 has direct influence to= CLANG38.
 
Thanks=
Zhiguang
 
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Vitaly Cheptsov via Groups.Io
Sent: Tuesday,= February 11, 2020 3:09 PM
To: Gao, Liming <liming.gao@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>; Shi, Steven <steven.shi@intel.com>
C= c: devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH= 1/1] BaseTools: Switch to GNU mode for CLANGPDB
 
=
Liming,
 
=
Done. As a side note, I am not = positive how can 7990438f1437f47990a8890de= e51978cb8dbc25c[1] resolve BZ 2415[2]. The bug was about CLANG38, an= d the toolchain updated was CLANGPDB. While it makes sense to update CLANGP= DB with this flag to stay clean (it will not make a difference for clang in= GNU mode), CLANGPDB has nothing to do to CLANG38.
 =
Best wishes,<= o:p class=3D"">
Vitaly
 
[1] https://bugzilla.tianocore.org/show_bug.cgi?id=3D2415
[2] https://github.com/= tianocore/edk2/commit/7990438f1437f47990a8890dee51978cb8dbc25c
 


11 =D1=84=D0=B5=D0=B2=D1=80. 2020 = = =D0=B3., =D0=B2 09:02, Gao, Liming <liming= .gao@intel.com> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0):<= o:p class=3D"">
 
Vitaly:
  Can you update this patch based on the latest edk= 2 trunk? I will catch it for edk2 Q1 stable tag.
 
Thanks
Liming=
From: = ;devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Liming Gao
Sent:=  Tuesday, February 11= , 2020 1:34 PM
To: vit9696 <vit9696@protonmail.com>;<= span class=3D"apple-converted-space"> devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU= mode for CLANGPDB
 
=
Reviewed-by: Liming Gao <liming.= gao@intel.com>
 
From: vit9696 <vit9696@protonmail.com> 
Sent: Tues= day, February 11, 2020 3:23 AM
To: Gao, Liming <liming.gao@intel.com<= /span>>; devel@edk2= .groups.io
Subject: RE: [edk2-devel] [PATCH 1/1] BaseT= ools: Switch to GNU mode for CLANGPDB
 <= /o:p>
Liming,
 
We did run several of our projects based on EDK II in X64 mode, DEBU= G, RELEASE, NOOPT. Noticed no change from XCODE5.
&= nbsp;
We also tried building several EDK builtin pa= ckages like CryptoPkg, MdePkg, MdeModulePkg.
=  
Best wishes,
Vitaly<= /div>
&nbs= p;
=D0=92 =D0=BF=D0=BD, =D1=84=D0=B5=D0=B2=D1=80. 10, 2020 =D0=B2 1= 6:47, Gao, Liming <liming.gao@intel.com> =D0=BF=D0=B8=D1=88=D0= = =B5=D1=82:

Vita= ly:
This change is good. Can you your test for it? I verify t= his patch for Ovmf platform on Windows. It can make ovmf pass build with CL= ANGPDB.

Thanks
Liming
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io= > On Behalf Of Vitaly Cheptsov via Groups.Io
> Sent: Mo= nday, February 10, 2020 6:59 PM
> To: devel@edk2.groups.io
&g= t; Subject: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLAN= GPDB
>
> REF: https://bugzilla.tianocore.org= /show_bug.cgi?id=3D2397
>
> Si= gned-off-by: Vitaly Cheptsov <vit9696@protonmail.com>
> ---
> BaseTools/Conf/tools_def.template | 6 = +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)>
> diff --git a/BaseTools/Conf/tools_def.= template b/BaseTools/Conf/tools_def.template
> index feee2= bbf16..6bf6c5768e 100755
> --- a/BaseTools/Conf/tools_def.= template
> +++ b/BaseTools/Conf/tools_def.template
> @@ -2755,11 +2755,11 @@ RELEASE_CLANG38_AARCH64_DLINK_FLAGS =3D= DEF(CLANG38_AARCH64_DLINK_FLAGS) -flto -Wl
> DEFINE CLANG= PDB_IA32_PREFIX =3D ENV(CLANG_BIN)
> DEFINE CLANGPDB_X64_P= REFIX =3D ENV(CLANG_BIN)
>
> -DEFINE CLAN= GPDB_IA32_TARGET =3D -target i686-unknown-windows
> -DEFIN= E CLANGPDB_X64_TARGET =3D -target x86_64-unknown-windows
>= +DEFINE CLANGPDB_IA32_TARGET =3D -target i686-unknown-windows-gnu
> +DEFINE CLANGPDB_X64_TARGET =3D -target x86_64-unknown-windows-= gnu
>
> DEFINE CLANGPDB_WARNING_OVERRIDES= =3D -Wno-parentheses-equality -Wno-tautological-compare -Wno-tautological-= constant-out-
> of-range-compare -Wno-empty-body -Wno-unus= ed-const-variable -Wno-varargs -Wno-unknown-warning-option -Wno-microsoft-e= num-
> forward-reference
> -DEFINE CLANGP= DB_ALL_CC_FLAGS =3D DEF(GCC48_ALL_CC_FLAGS) DEF(CLANGPDB_WARNING_OVERRIDES)= -fno-stack-protector -
> mms-bitfields -Wno-address -Wno-= shift-negative-value -Wno-unknown-pragmas -Wno-incompatible-library-redecla= ration -fno-
> asynchronous-unwind-tables -mno-implicit-fl= oat -ftrap-function=3Dundefined_behavior_has_been_optimized_away_by_clang -=
> funsigned-char -fno-ms-extensions -Wno-null-dereference= -fms-compatibility -mno-stack-arg-probe
> +DEFINE CLANGPD= B_ALL_CC_FLAGS =3D DEF(GCC48_ALL_CC_FLAGS) DEF(CLANGPDB_WARNING_OVERRIDES) = -fno-stack-protector -
> fno-asynchronous-unwind-tables -f= unsigned-char -ftrap-function=3Dundefined_behavior_has_been_optimized_away_= by_clang -Wno-
> address -Wno-shift-negative-value -Wno-un= known-pragmas -Wno-incompatible-library-redeclaration -Wno-null-dereference= -mno-
> implicit-float -mms-bitfields -mno-stack-arg-prob= e -nostdlib -nostdlibinc
>
> ############= ###############
> # CLANGPDB IA32 definitions
> --
> 2.21.1 (Apple Git-122.3)
>>
> -=3D-=3D-=3D-=3D-=3D-=3D
= > G= roups.io Links: You r= eceive all messages sent to this group.
>
&g= t; View/Reply Online (#54130): <= /span>https://edk2.groups.io/g/devel/message/54130<= br class=3D"">> Mute This Topic:&n= bsp;https://groups.io/mt/71134286/1759384
> Group Owner: = devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/= g/devel/unsub = [liming.gao@intel.com]
> = -=3D-=3D-=3D-=3D-=3D-=3D

 
 
 

--Apple-Mail=_38F3A91B-88E9-49D8-92B2-86D7E5410D6F-- -----------------------eff5ab399da77c35027de962496c1671 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: ProtonMail wsBmBAEBCAAQBQJeQ7JMCRBPsoxt7Hy0xQAKCRBPsoxt7Hy0xW2lB/0WgXko Nc0fA86tgZt86yKllAe9vy2m362r68d9/iuB3Asfyx46EMkXm6uO3TQNSb0V Evtgo0zZvKrw0xwqm0EvABvn24fbdY3M1aQeBc50ppXIf7fSaHEb80XfnRZg XCy0SfOVEHJ1DQnbFbDax9PJDvfYZrS31fTG7c1huLXFbneOU8sINRwv7elS HFYKOLKIjCzDLOogah0tXzoNwsifXYJi/bvi81xOtvQXB22aVhWjPfFwp0Ep WZQaUXRch5HYxHL12odd5YfLNzKapLHMaT7ZQRBKHyFlpBocnnNxCiatpqvA hebF1pJEaVrhPh95m1ZjnJyWaQtmXjGviOB1 =SpsZ -----END PGP SIGNATURE----- -----------------------eff5ab399da77c35027de962496c1671--