From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) by mx.groups.io with SMTP id smtpd.web12.1033.1649350621042596429 for ; Thu, 07 Apr 2022 09:57:01 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=M+nV6Q50; spf=pass (domain: gmail.com, ip: 209.85.128.174, mailfrom: marietto2008@gmail.com) Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-2eb3db5b172so68728577b3.6 for ; Thu, 07 Apr 2022 09:57:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SlcipZXOo8Yh08uRoo3B90hKSNwRvCXNeFfgjTKh1yY=; b=M+nV6Q50346gKkbOFGLCkrI5zCQgw4UaXqKuBkbib27l7rZPu0ePNcM/POcGBmGICs UwI37o13QU7XR/tSDMF/Hk3lCXfIqBfCq8R8Bava9uJw/RfXgLAR2yABtq0h13lJban6 ZRNwhUgKMSjZ2m1AX/khjyQKrZv7BaXOxnS5qRENLC6glopIInx2995FBVwn16GpJrBt k5r2lTMK1qPaJb6bUWMpnpwRJmOtiSGwD7wGawfgwe/0w2eUDe4YAD0SvUE8ijNwK82M GH6gxzgdWvhL9uKrmaMwA33LBlnTsLhak1CzZ1BauZmQxsuSESa03eSxZGbGW/Ndx3dt 0tvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SlcipZXOo8Yh08uRoo3B90hKSNwRvCXNeFfgjTKh1yY=; b=5qjAoG41em145HuZCpcZahLurbdOB57oUubygWAFXzcqU1BsEOQWQq1Bz2u60mjHRm ATRf7I/Zkjnn3LRtSvfUZmZaWQTpdZdo5UFPIQV8J7GIjXQ6UfOKV8xVySjWj+/ZFRLm G8iC7TDJtP0nC0rPJLZagTmmlhkUeL2aeX2oN7J3BXLCbT2nUkG1lwfkCVgFe1XdiXEu n1Vb4kaLwyoZOjKtyeojaFglGciz8ZViTIZumGUe2eO67/jooOYF1XaBS4P+kAraIrtZ DlHtP1adVbJK/FBm+7Efut3mEevV0C9lp3A47jFJ9NQciEASzv2sUEVvVpQph55vxedN 58eg== X-Gm-Message-State: AOAM530jmh4iLcZglbNpQCGJ0bVxXs2gjNzPXN9pDkDomn7Iua/U1GUL qlRG8Rk2E2i+MJ6NJWOAhR5cFOhogmqq0U4DOxw= X-Google-Smtp-Source: ABdhPJyYcbGxe/NnpE9641zJy47e1HBATaL3B5FxZyAKJziOe2aY6qScc6DXr1ZA69qtPC9D7h4ROAqDoH5nAlZHSfY= X-Received: by 2002:a0d:e247:0:b0:2eb:303a:a4b9 with SMTP id l68-20020a0de247000000b002eb303aa4b9mr12701854ywe.124.1649350620195; Thu, 07 Apr 2022 09:57:00 -0700 (PDT) MIME-Version: 1.0 References: <20220329101417.617-1-c.koehne@beckhoff.com> <7cdf6ac12fbc499fb846f85782d06e21@beckhoff.com> <8dc8c192-1bc6-71cc-d572-eda275724e99@bsdio.com> In-Reply-To: <8dc8c192-1bc6-71cc-d572-eda275724e99@bsdio.com> From: Mario Marietto Date: Thu, 7 Apr 2022 18:56:48 +0200 Message-ID: Subject: Re: [edk2-devel] [PATCH v2] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg To: Rebecca Cran Cc: =?UTF-8?Q?Corvin_K=C3=B6hne?= , Peter Grehan , devel@edk2.groups.io, Ard Biesheuvel , Jiewen Yao , Jordan Justen , FreeBSD Virtualization , Gerd Hoffmann Content-Type: multipart/alternative; boundary="000000000000d3b0b905dc135d30" --000000000000d3b0b905dc135d30 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable im trying to test the patch on my pc,that has two graphic cards,the intel coffee lake and the nvidia. i tried to start the pc from the nvidia card and ive configured the xorg.conf file giving the proper bus id value. in addition ive loaded the kernel.ko file from the boot loader.conf i have removed the intel and the drm drivers used by the Intel graphic card. unfortunately my pc wont boot from the nvidia card. my mouse and keyboard freezes just before the desktop manager (xfce and kde5) starts. Il gio 7 apr 2022, 18:46 Rebecca Cran ha scritto: > I've just looked at the patch and it looks good, though I haven't tested > it. > > So yes, please add: > > > Acked-by: Rebecca Cran > > > On 4/6/22 23:24, Corvin K=C3=B6hne wrote: > > Hi Peter and Rebecca, > > > > thanks for your feedback. This patch is backward compatible. It checks > > if QemuFwCfg is available and if QemuFwCfg is missing it falls > > back to BhyveFwCtl. > > > > So, should I add Reviewed-by (or Acked-by?) Peter and Rebecca to the > > commit message? > > > > > > Thanks > > Corvin > > > > Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans > Beckhoff > > Registered office: Verl, Germany | Register court: Guetersloh HRA 7075 > > > > > > > > --000000000000d3b0b905dc135d30 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
im trying to test the patch on my pc,that has two graphic= cards,the intel coffee lake and the nvidia. i tried to start the pc from t= he nvidia card and ive configured the xorg.conf file giving the proper bus = id value. in addition ive loaded the kernel.ko file from the boot loader.co= nf i have removed the intel and the drm drivers used by the Intel graphic c= ard. unfortunately my pc wont boot from the nvidia card. my mouse and keybo= ard freezes just before the desktop manager (xfce and kde5) starts.
Il gio 7= apr 2022, 18:46 Rebecca Cran <rebe= cca@bsdio.com> ha scritto:
I= 've just looked at the patch and it looks good, though I haven't te= sted it.

So yes, please add:


Acked-by: Rebecca Cran <rebecca@bsdio.com>


On 4/6/22 23:24, Corvin K=C3=B6hne wrote:
> Hi Peter and Rebecca,
>
> thanks for your feedback. This patch is backward compatible. It checks=
> if QemuFwCfg is available and if QemuFwCfg is missing it falls
> back to BhyveFwCtl.
>
> So, should I add Reviewed-by (or Acked-by?) Peter and Rebecca to the > commit message?
>
>
> Thanks
> Corvin
>
> Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys.= Hans Beckhoff
> Registered office: Verl, Germany | Register court: Guetersloh HRA 7075=
>
>
>

--000000000000d3b0b905dc135d30--