From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:400d:c09::234; helo=mail-qk0-x234.google.com; envelope-from=joakim.bech@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-qk0-x234.google.com (mail-qk0-x234.google.com [IPv6:2607:f8b0:400d:c09::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BD011221F93B6 for ; Tue, 16 Jan 2018 02:54:32 -0800 (PST) Received: by mail-qk0-x234.google.com with SMTP id i141so20327637qke.0 for ; Tue, 16 Jan 2018 02:59:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:from:date:message-id:subject:to:cc; bh=9EjdIjxms5pmTR2JuQMWt93k734iLMEm/tKKUDO3Swg=; b=ZWqrDWzoQ34BxpkKUOE6IYPTNeVJNzGKNjFV22t0i2Dr7jAMbJQTne6lJxy3HK3V2B IqkYY6KiAB+HE0sYq8UrTJPwYLTrGKcj8IfZ7efSyH5qJynE2A/MrW3d8AttXCYPbjAp DXR0F+D9Lwe9TclJD8xFVVrUSlAxFXM/5HpmE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=9EjdIjxms5pmTR2JuQMWt93k734iLMEm/tKKUDO3Swg=; b=nS1y9Ilw98d7wBzO12GrKnIM+5rpHnc6eapVjBnBDdGdfVrLb0ud/pOoRULLk9RN3R 6VTtfP1QQ+wWz4VJgsJwV/z3BC/Oa41o3sQJQXWF+7YfR4g0y9XU2ivzV/L1gsHXPmb7 TN8G6N0M6VGzz5p5L6ObOGXz0e3ZvCeFu6Ae12IH5EYb8qkl7PLPv5ad40kdqaTGBW9A IQQRS8IQ6ObWUzAaAziL45rOHh2qY5181Hh9bXM7owqR68Nr6idYGrXJau39KNPIZ0/Q NJij6jvMMq+nXsozgKOtlnJQzLGs4sHTnu+L99yqiH+wCczeMC2mZBKegbJ4FVE+nK1X QLEQ== X-Gm-Message-State: AKwxytcQ6g6R2+0XxtXk1bGyGZpqPUqy2L6LbrzSe5h7TApbm4gT4AuV KNPhT71iN/kKy/qxydrbRNpjh/J3NuYhgrUGL6Mk/Q== X-Google-Smtp-Source: ACJfBouvM6/X9ek62reUzG9DoVjBDosxAbyw2JVN0+gh/c+V73WZaAQ9sLnN3Z6FsPMuO/V2bkHwFcQCOSlQ+s+zq5s= X-Received: by 10.55.116.68 with SMTP id p65mr9513063qkc.230.1516100390684; Tue, 16 Jan 2018 02:59:50 -0800 (PST) MIME-Version: 1.0 Received: by 10.200.27.193 with HTTP; Tue, 16 Jan 2018 02:59:10 -0800 (PST) From: Joakim Bech Date: Tue, 16 Jan 2018 11:59:10 +0100 Message-ID: To: fan.wang@intel.com Cc: edk2-devel@lists.01.org, jiaxin.wu@intel.com, siyuan.fu@intel.com, Ard Biesheuvel , team-security-wg , Leif Lindholm X-Mailman-Approved-At: Tue, 16 Jan 2018 05:38:35 -0800 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 Subject: Regression/Assert : MdeModulePkg: Did some code enhancement for DxeIpIoLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jan 2018 10:54:33 -0000 Content-Type: text/plain; charset="UTF-8" Hi, With recent patches being merged in EDK2 we get an assert when booting: -------------------------------------------------------------------------- ... InstallProtocolInterface: 41D94CD2-35B6-455A-8258-D4E51334AADD 7BA990A0 InstallProtocolInterface: 83F01464-99BD-45E5-B383-AF6305D8E9E6 7BA99B20 ASSERT [Udp4Dxe] /mnt/sshd/devel/optee_projects/qemu_v8/edk2/MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.c(1750): (IpInfo->IpVersion == 4) || (IpInfo->IpVersion == 6) -------------------------------------------------------------------------- I've bisected it to this commit: -------------------------------------------------------------------------- $ git bisect bad 2b2087478c861b967394f1ce31531d27ab541b02 is the first bad commit commit 2b2087478c861b967394f1ce31531d27ab541b02 Author: Wang Fan Date: Wed Jan 10 11:09:28 2018 +0800 MdeModulePkg: Did some code enhancement for DxeIpIoLib * In DxeIpIo, there are several places use ASSERT() to check input parameters without and descriptions or error handling. This patch fixed this issue. * Fixed some incorrect descriptions in code commence. * Remove unneeded Exit tag in function IpIoOpen and IpIoConfigIp. * Add EFIAPI tag for function IpIoRefreshNeighbor. Cc: Jiaxin Wu Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wang Fan Reviewed-by: Jiaxin Wu Reviewed-by: Fu Siyuan :040000 040000 2c60fa2019178c75556b238dbf877927917531f0 080ccf675bf7ee498eccccc89f76bfd14fd61ff9 M MdeModulePkg -------------------------------------------------------------------------- This EKD2 build is being used in a QEMU Arm v8 setup running AArch64 (aarch64-linux-gnu-) and for reference here are the build parameters: -------------------------------------------------------------------------- make -j1 -C /mnt/sshd/devel/optee_projects/qemu_v8/build/../edk2/BaseTools && \ GCC49_AARCH64_PREFIX=/mnt/sshd/devel/optee_projects/qemu_v8/build/../toolchains/aarch64-legacy/bin/aarch64-linux-gnu- make -j1 -C /mnt/sshd/devel/optee_projects/qemu_v8/build/../edk2 -f ArmPlatformPkg/Scripts/Makefile EDK2_ARCH=AARCH64 EDK2_DSC=ArmVirtPkg/ArmVirtQemuKernel.dsc EDK2_TOOLCHAIN=GCC49 EDK2_BUILD=DEBUG EDK2_MACROS="-n 6" all -------------------------------------------------------------------------- Is this something an EDK2 developer could look into or give advice how to resolve it? Set IP_VERSION_4 or IP_VERSION_6 somewhere? Regards, Joakim