From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:400d:c09::22d; helo=mail-qk0-x22d.google.com; envelope-from=joakim.bech@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-qk0-x22d.google.com (mail-qk0-x22d.google.com [IPv6:2607:f8b0:400d:c09::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 066F4221F93C1 for ; Tue, 16 Jan 2018 16:39:21 -0800 (PST) Received: by mail-qk0-x22d.google.com with SMTP id u76so23211043qku.11 for ; Tue, 16 Jan 2018 16:44:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=6h18uxZat3bX3v4CVIvBL+63YHpQF3Iqc+25cX8+XeA=; b=D0wvYDB2+B7Jx5mUHEvQnKrnslbD0nQyf6HZEjZbPcUSXJWEgD4KO5/SPd3YGWBHPK FvdZrSMYZGpYJbKfB5PB6acvaU3bRN60MLl3bTdenWdSszl7E+gzzkglZNzeHxxFV9qj 8yW1jYTR1qhGTJFokMZcC13ethkj91FtT+adE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=6h18uxZat3bX3v4CVIvBL+63YHpQF3Iqc+25cX8+XeA=; b=r4KMRKiqQ864iwoHgzYRPj9lj96Fqlysum/UDqMKbMPkVe2GGItnLvqhSB0KsqvKnR Qua5l99+op6hmaOSancrdz7UBZm5nth7mOTGkfWNakKaU/7PklCH/0OqtWx51rcT/6a+ FQMWtPk/JEYE/8S5Hk4y8sKxajGwNfrkCTvHELihoaWr7jypzgLu959IrpkCLSrUlz9o WYvihZpO7FHpbzGYoSXPLKoFr42Ej/yv84BoYDDl9+I1FeJc6aOmip7LsCan+RFh+wBC QcEdnWVFukW2mD36VTkMWYT3I1ZCkPLhGlc782y94vX+YMH9IM8cg48J65B2ojdAAbRA 8WiQ== X-Gm-Message-State: AKwxytdkol3F2oWcXGgmUQjmXwSR66FhHGA6Y5zit7Pu40hkCzxMxKrD enK+y8M4A8QKPUUFjVgjiOBStV/P1fsA0WPodOWKzA== X-Google-Smtp-Source: ACJfBov8v+ezy5nqpM/UIqA+C3DMASWLQTKrrPaYMeSUGqBLJwsv3ZGs7XIzia4FkGbhLFMkfQCdGc5mXOPmeo9u9mg= X-Received: by 10.55.186.130 with SMTP id k124mr57413194qkf.153.1516149878607; Tue, 16 Jan 2018 16:44:38 -0800 (PST) MIME-Version: 1.0 Received: by 10.200.27.193 with HTTP; Tue, 16 Jan 2018 16:43:58 -0800 (PST) In-Reply-To: <895558F6EA4E3B41AC93A00D163B72741635D592@SHSMSX103.ccr.corp.intel.com> References: <895558F6EA4E3B41AC93A00D163B72741635D592@SHSMSX103.ccr.corp.intel.com> From: Joakim Bech Date: Wed, 17 Jan 2018 01:43:58 +0100 Message-ID: To: "Wu, Jiaxin" Cc: "Wang, Fan" , "edk2-devel@lists.01.org" , "Fu, Siyuan" , Ard Biesheuvel , team-security-wg , Leif Lindholm X-Content-Filtered-By: Mailman/MimeDel 2.1.23 Subject: Re: Regression/Assert : MdeModulePkg: Did some code enhancement for DxeIpIoLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jan 2018 00:39:22 -0000 Content-Type: text/plain; charset="UTF-8" Hi Jiaxin, I just gave it a try and I can confirm that your patch fixed the issue. Thanks for the quick turnaround time! Regards, Joakim On 17 January 2018 at 01:36, Wu, Jiaxin wrote: > Hi Joakim, > > > > It has been fixed in EDK2 trunk. The commit log is shown as below: > > > > SHA-1: 6478baf891524348451d75a37f4e4692b835a45b > > > > ** MdeModulePkg/DxeIpIoLib: Fixed the error ASSERT incorrectly used in > IpIoAddIp().* > > > > * In DxeIpIo, an ASSERT check is incorrectly used in IpIoAddIp(), which > result > > debug image hang when this API is called, this patch is to fix this > issue. > > > > Cc: Jiaxin Wu > > Cc: Fu Siyuan > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Wang Fan > > Reviewed-by: Jiaxin Wu > > > > Thanks, > > Jiaxin > > > > > > *From:* Joakim Bech [mailto:joakim.bech@linaro.org] > *Sent:* Tuesday, January 16, 2018 6:59 PM > *To:* Wang, Fan > *Cc:* edk2-devel@lists.01.org; Wu, Jiaxin ; Fu, > Siyuan ; Ard Biesheuvel ; > team-security-wg ; Leif Lindholm < > leif.lindholm@linaro.org> > *Subject:* [edk2] Regression/Assert : MdeModulePkg: Did some code > enhancement for DxeIpIoLib > > > > Hi, > > > > With recent patches being merged in EDK2 we get an assert when booting: > > -------------------------------------------------------------------------- > > ... > > InstallProtocolInterface: 41D94CD2-35B6-455A-8258-D4E51334AADD 7BA990A0 > > InstallProtocolInterface: 83F01464-99BD-45E5-B383-AF6305D8E9E6 7BA99B20 > > ASSERT [Udp4Dxe] /mnt/sshd/devel/optee_projects/qemu_v8/edk2/ > MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.c(1750): (IpInfo->IpVersion == > 4) || (IpInfo->IpVersion == 6) > > -------------------------------------------------------------------------- > > > > > > I've bisected it to this commit: > > -------------------------------------------------------------------------- > > $ git bisect bad > > 2b2087478c861b967394f1ce31531d27ab541b02 is the first bad commit > > commit 2b2087478c861b967394f1ce31531d27ab541b02 > > Author: Wang Fan > > Date: Wed Jan 10 11:09:28 2018 +0800 > > > > MdeModulePkg: Did some code enhancement for DxeIpIoLib > > > > * In DxeIpIo, there are several places use ASSERT() to check input > > parameters without and descriptions or error handling. This patch > > fixed this issue. > > * Fixed some incorrect descriptions in code commence. > > * Remove unneeded Exit tag in function IpIoOpen and IpIoConfigIp. > > * Add EFIAPI tag for function IpIoRefreshNeighbor. > > > > Cc: Jiaxin Wu > > Cc: Ye Ting > > Cc: Fu Siyuan > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Wang Fan > > Reviewed-by: Jiaxin Wu > > Reviewed-by: Fu Siyuan > > > > :040000 040000 2c60fa2019178c75556b238dbf877927917531f0 > 080ccf675bf7ee498eccccc89f76bfd14fd61ff9 M MdeModulePkg > > -------------------------------------------------------------------------- > > > > > > This EKD2 build is being used in a QEMU Arm v8 setup running AArch64 > (aarch64-linux-gnu-) and for reference here are the build parameters: > > -------------------------------------------------------------------------- > > > make -j1 -C /mnt/sshd/devel/optee_projects/qemu_v8/build/../edk2/BaseTools > && \ GCC49_AARCH64_PREFIX=/mnt/sshd/devel/optee_projects/ > qemu_v8/build/../toolchains/aarch64-legacy/bin/aarch64-linux-gnu- make > -j1 -C /mnt/sshd/devel/optee_projects/qemu_v8/build/../edk2 -f > ArmPlatformPkg/Scripts/Makefile EDK2_ARCH=AARCH64 EDK2_DSC=ArmVirtPkg/ArmVirtQemuKernel.dsc > EDK2_TOOLCHAIN=GCC49 EDK2_BUILD=DEBUG EDK2_MACROS="-n 6" all > > -------------------------------------------------------------------------- > > > > Is this something an EDK2 developer could look into or give advice how to > resolve it? Set IP_VERSION_4 or IP_VERSION_6 somewhere? > > > Regards, > > Joakim >