From: "Vijayenthiran Subramaniam" <vijayenthiran.subramaniam@arm.com>
To: devel@edk2.groups.io, leif@nuviainc.com
Cc: michael.d.kinney@intel.com, Ard.Biesheuvel@arm.com,
Thomas Abraham <thomas.abraham@arm.com>
Subject: Re: [edk2-devel] [edk2-platforms] [PATCH v3 0/5] Platform/ARM/SgiPkg: Add support for RD-N1-Edge-Dual platform
Date: Wed, 19 Feb 2020 08:45:16 +0000 [thread overview]
Message-ID: <CA+FsMCN2GTjTxr-jjS4xH4jtUBeXWA1MMyBY-hi-BJgeC0QETg@mail.gmail.com> (raw)
In-Reply-To: <20200218203423.GY23627@bivouac.eciton.net>
Hi Leif,
On Tue, Feb 18, 2020 at 8:34 PM Leif Lindholm <leif@nuviainc.com> wrote:
>
> On Fri, Feb 14, 2020 at 19:11:29 +0530, Vijayenthiran Subramaniam wrote:
> > Changes since v2:
> > - Rename i to Idx in Patch 2/5
> > - Retaining R-b in rest of the patches as there's no change
> >
> > Changes since v1:
> > - Fix typo which caused build error
> >
> > This patch series adds support for RD-N1-Edge platform with multi-chip
> > capability. The first patch in this series is an improvement to SgiPkg to avoid
> > any usage of deprecated APIs. The second patch refactors the existing code to
> > use lookup table in order to identify the platform. The rest of the patch adds
> > multi-chip support for the RD-N1-Edge platform.
>
> For remaining patches:
> Reviewed-by: Leif Lindholm <leif@nuviainc.com>
>
> Series pushed as 41c1d9ba3304..2fb4670d9f68.
>
> However, while test building I noticed the SGI platform currently
> fails to build with clang (version 7 in my case). This fails also
> before this set however.
>
> But could you please look into the warnings in
> Platform/ARM/SgiPkg/Drivers/PlatformDxe/VirtioDevices.c
> ?
Thanks for checking. I've posted a patch fixing this:
https://edk2.groups.io/g/devel/message/54618
>
> Regards,
>
> Leif
>
> > Vijayenthiran Subramaniam (5):
> > Platform/ARM/SgiPkg: Disable use of deprecated APIs
> > Platform/ARM/SgiPkg: Use lookup table to install ACPI table
> > Platform/ARM/SgiPkg: Add MultiChipMode to Platform Descriptor
> > Platform/ARM/Sgi: Add ACPI tables for dual-chip RD-N1-Edge platform
> > Platform/ARM/Sgi: Add initial support for RD-N1-Edge-Dual platform
> >
> > Platform/ARM/SgiPkg/SgiPlatform.dec | 1 +
> > Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 3 +
> > Platform/ARM/SgiPkg/SgiPlatform.dsc | 4 +
> > Platform/ARM/SgiPkg/SgiPlatform.fdf | 1 +
> > Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 59 ++++++
> > Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf | 1 +
> > Platform/ARM/SgiPkg/Include/SgiPlatform.h | 7 +
> > Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 61 +++++-
> > Platform/ARM/SgiPkg/Library/SgiPlatformPei/SgiPlatformPeim.c | 8 +
> > Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Madt.aslc | 198 ++++++++++++++++++++
> > 10 files changed, 333 insertions(+), 10 deletions(-)
> > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Madt.aslc
> >
> > --
> > 2.7.4
Regards,
Vijay
prev parent reply other threads:[~2020-02-19 8:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 13:41 [edk2-platforms] [PATCH v3 0/5] Platform/ARM/SgiPkg: Add support for RD-N1-Edge-Dual platform Vijayenthiran Subramaniam
2020-02-14 13:41 ` [edk2-platforms] [PATCH v3 1/5] Platform/ARM/SgiPkg: Disable use of deprecated APIs Vijayenthiran Subramaniam
2020-02-14 13:41 ` [edk2-platforms] [PATCH v3 2/5] Platform/ARM/SgiPkg: Use lookup table to install ACPI table Vijayenthiran Subramaniam
2020-02-14 13:41 ` [edk2-platforms] [PATCH v3 3/5] Platform/ARM/SgiPkg: Add MultiChipMode to Platform Descriptor Vijayenthiran Subramaniam
2020-02-14 13:41 ` [edk2-platforms] [PATCH v3 4/5] Platform/ARM/Sgi: Add ACPI tables for dual-chip RD-N1-Edge platform Vijayenthiran Subramaniam
2020-02-14 13:41 ` [edk2-platforms] [PATCH v3 5/5] Platform/ARM/Sgi: Add initial support for RD-N1-Edge-Dual platform Vijayenthiran Subramaniam
2020-02-18 20:34 ` [edk2-platforms] [PATCH v3 0/5] Platform/ARM/SgiPkg: Add " Leif Lindholm
2020-02-19 8:45 ` Vijayenthiran Subramaniam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+FsMCN2GTjTxr-jjS4xH4jtUBeXWA1MMyBY-hi-BJgeC0QETg@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox