From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.9583.1582101955864229920 for ; Wed, 19 Feb 2020 00:45:56 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: vijayenthiran.subramaniam@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 23DE91045 for ; Wed, 19 Feb 2020 00:45:55 -0800 (PST) Received: from mail-lj1-f182.google.com (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EC8483F9E6 for ; Wed, 19 Feb 2020 00:45:54 -0800 (PST) Received: by mail-lj1-f182.google.com with SMTP id x7so26146313ljc.1 for ; Wed, 19 Feb 2020 00:45:54 -0800 (PST) X-Gm-Message-State: APjAAAUx79KNYkeqt5mCjFnrLytzniokD3Sa7qGplKJ4mgIgLw5adooy Z+2iw2PIDCofxrQPOI4ZryvVBJ2QPotNilLTpDk= X-Google-Smtp-Source: APXvYqyh0gzczF7BDjh+lRFeK2Abczr+9LrM2Ik2tcUM5ARWtu+3BpnyAX0lyz4+c/j8RUfkOY6Cr2P28Jp9ZIuh1Lg= X-Received: by 2002:a2e:93c9:: with SMTP id p9mr14812440ljh.136.1582101953508; Wed, 19 Feb 2020 00:45:53 -0800 (PST) MIME-Version: 1.0 References: <1581687694-12752-1-git-send-email-vijayenthiran.subramaniam@arm.com> <20200218203423.GY23627@bivouac.eciton.net> In-Reply-To: <20200218203423.GY23627@bivouac.eciton.net> From: "Vijayenthiran Subramaniam" Date: Wed, 19 Feb 2020 08:45:16 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [edk2-platforms] [PATCH v3 0/5] Platform/ARM/SgiPkg: Add support for RD-N1-Edge-Dual platform To: devel@edk2.groups.io, leif@nuviainc.com Cc: michael.d.kinney@intel.com, Ard.Biesheuvel@arm.com, Thomas Abraham Content-Type: text/plain; charset="UTF-8" Hi Leif, On Tue, Feb 18, 2020 at 8:34 PM Leif Lindholm wrote: > > On Fri, Feb 14, 2020 at 19:11:29 +0530, Vijayenthiran Subramaniam wrote: > > Changes since v2: > > - Rename i to Idx in Patch 2/5 > > - Retaining R-b in rest of the patches as there's no change > > > > Changes since v1: > > - Fix typo which caused build error > > > > This patch series adds support for RD-N1-Edge platform with multi-chip > > capability. The first patch in this series is an improvement to SgiPkg to avoid > > any usage of deprecated APIs. The second patch refactors the existing code to > > use lookup table in order to identify the platform. The rest of the patch adds > > multi-chip support for the RD-N1-Edge platform. > > For remaining patches: > Reviewed-by: Leif Lindholm > > Series pushed as 41c1d9ba3304..2fb4670d9f68. > > However, while test building I noticed the SGI platform currently > fails to build with clang (version 7 in my case). This fails also > before this set however. > > But could you please look into the warnings in > Platform/ARM/SgiPkg/Drivers/PlatformDxe/VirtioDevices.c > ? Thanks for checking. I've posted a patch fixing this: https://edk2.groups.io/g/devel/message/54618 > > Regards, > > Leif > > > Vijayenthiran Subramaniam (5): > > Platform/ARM/SgiPkg: Disable use of deprecated APIs > > Platform/ARM/SgiPkg: Use lookup table to install ACPI table > > Platform/ARM/SgiPkg: Add MultiChipMode to Platform Descriptor > > Platform/ARM/Sgi: Add ACPI tables for dual-chip RD-N1-Edge platform > > Platform/ARM/Sgi: Add initial support for RD-N1-Edge-Dual platform > > > > Platform/ARM/SgiPkg/SgiPlatform.dec | 1 + > > Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 3 + > > Platform/ARM/SgiPkg/SgiPlatform.dsc | 4 + > > Platform/ARM/SgiPkg/SgiPlatform.fdf | 1 + > > Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 59 ++++++ > > Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf | 1 + > > Platform/ARM/SgiPkg/Include/SgiPlatform.h | 7 + > > Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 61 +++++- > > Platform/ARM/SgiPkg/Library/SgiPlatformPei/SgiPlatformPeim.c | 8 + > > Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Madt.aslc | 198 ++++++++++++++++++++ > > 10 files changed, 333 insertions(+), 10 deletions(-) > > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf > > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Madt.aslc > > > > -- > > 2.7.4 Regards, Vijay