From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.6510.1581688416365183116 for ; Fri, 14 Feb 2020 05:53:36 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: vijayenthiran.subramaniam@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0F6EB106F for ; Fri, 14 Feb 2020 05:53:36 -0800 (PST) Received: from mail-lj1-f175.google.com (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D869D3F9E6 for ; Fri, 14 Feb 2020 05:53:35 -0800 (PST) Received: by mail-lj1-f175.google.com with SMTP id a13so10826382ljm.10 for ; Fri, 14 Feb 2020 05:53:35 -0800 (PST) X-Gm-Message-State: APjAAAUMBtQCN3IfZj05eLAug5rcKSs89YfoOxSB5ev5wXLrPXuL4CZp EBG/k4vUNIxEENHkm2ymqmroKNyk0z506JXUhB8= X-Google-Smtp-Source: APXvYqyFi2BgtKZFcK/2paM3x5r+dd9Ckwev8CTDZlb7sJmS8nOovr7vKLsZNVRD15SPLixEz1vZDAN3HpWT8KKESTc= X-Received: by 2002:a2e:884c:: with SMTP id z12mr2258106ljj.55.1581688414201; Fri, 14 Feb 2020 05:53:34 -0800 (PST) MIME-Version: 1.0 References: <1581514167-1340-1-git-send-email-vijayenthiran.subramaniam@arm.com> <20200213173147.GQ23627@bivouac.eciton.net> In-Reply-To: <20200213173147.GQ23627@bivouac.eciton.net> From: "Vijayenthiran Subramaniam" Date: Fri, 14 Feb 2020 13:52:57 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [edk2-platforms] [PATCH v2 0/5] Platform/ARM/SgiPkg: Add support for RD-N1-Edge-Dual platform To: devel@edk2.groups.io, leif@nuviainc.com Cc: michael.d.kinney@intel.com, Ard.Biesheuvel@arm.com, Thomas Abraham Content-Type: text/plain; charset="UTF-8" Hi Leif, On Thu, Feb 13, 2020 at 5:31 PM Leif Lindholm wrote: > > On the whole, looks good. > If you can resubmit v3 versions of patches 2-3 only based on feedback, > that would suffice. Thanks for reviewing. I have sent out v3 retaining R-b in all patch except in patch 2. There's no change in patch 3 except i to Idx. > > On a separate note: > Could someone in ARM take an action item to go and figure out who > should be default reviewer for the various ARM ltd platforms (virtual > or not), and submit a patch to Maintainers.txt adding some R:? > > Best Regards, > > Leif > > On Wed, Feb 12, 2020 at 18:59:22 +0530, Vijayenthiran Subramaniam wrote: > > Changes since v1: > > - Fix typo which caused build error > > > > This patch series adds support for RD-N1-Edge platform with multi-chip > > capability. The first patch in this series is an improvement to SgiPkg to avoid > > any usage of deprecated APIs. The second patch refactors the existing code to > > use lookup table in order to identify the platform. The rest of the patch adds > > multi-chip support for the RD-N1-Edge platform. > > > > Vijayenthiran Subramaniam (5): > > Platform/ARM/SgiPkg: Disable use of deprecated APIs > > Platform/ARM/SgiPkg: Use lookup table to install ACPI table > > Platform/ARM/SgiPkg: Add MultiChipMode to Platform Descriptor > > Platform/ARM/Sgi: Add ACPI tables for dual-chip RD-N1-Edge platform > > Platform/ARM/Sgi: Add initial support for RD-N1-Edge-Dual platform > > > > Platform/ARM/SgiPkg/SgiPlatform.dec | 1 + > > Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 3 + > > Platform/ARM/SgiPkg/SgiPlatform.dsc | 4 + > > Platform/ARM/SgiPkg/SgiPlatform.fdf | 1 + > > Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 59 ++++++ > > Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf | 1 + > > Platform/ARM/SgiPkg/Include/SgiPlatform.h | 7 + > > Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 61 +++++- > > Platform/ARM/SgiPkg/Library/SgiPlatformPei/SgiPlatformPeim.c | 8 + > > Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Madt.aslc | 198 ++++++++++++++++++++ > > 10 files changed, 333 insertions(+), 10 deletions(-) > > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf > > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Madt.aslc > > > > -- > > 2.7.4 > > > Regards, Vijayenthiran