From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-x235.google.com (mail-qk0-x235.google.com [IPv6:2607:f8b0:400d:c09::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6C66280350 for ; Tue, 7 Mar 2017 11:17:55 -0800 (PST) Received: by mail-qk0-x235.google.com with SMTP id 1so20404491qkl.3 for ; Tue, 07 Mar 2017 11:17:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=KmGQ97t3yPClyZC+4Tq/yrHtcClHn9pPoOa4VJQXdyg=; b=QIn2YkZooN7BycXkZmp+NXAZJZnihxYoTxmpuxYX/uXZrWvng1ScHfG+4FwgjEn8eA oV69hmH4NsbUmlmyWhDF7/EbEFgoOnUbemCSAWKgx4QzmIPDjH+RWRTYAl4io3IyJnYw DeREQ/EH0rEChpu7Mfbxc8XSe7bRHOOUl8NvBTjdwlxpJXA7qnXeXaT6rrUaSd6oGJ8c m3tEfUssLYqXXvporb8/DJewxIWoa5/C9Yj7FXDL+CTWrc1T0sZPo9OS1Ebs/c7y44pJ Df8um6aAr02gdc52PPSUIXig9OB+sAmFUpGuimk5w/3/Rjru9HZH8vjjgB9hEFzsMoma l7Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=KmGQ97t3yPClyZC+4Tq/yrHtcClHn9pPoOa4VJQXdyg=; b=I/lEljOWoqubFdTwkX6uG2TgKG/FLzxkVpTvzQVNilE0E+WWSQO2CdpWwTJ6ke40mH Sgk8ufaFwFXF4Dv1KtEP8ZsNvIyVght4Sjpdk+Hpd/9szMqF0DkHeI4TAu7edwNA0wzX +bYtCWmEZoW60HmTyqN+AQtQ/DKEoMJLuqlnBpffo9zWSzZeWE9yD1jmWKpp/C4xclEs vKiPJoEPYO2NLatWO5vMNFnTtiPBvr8+MM8CMq3XxKvm3GufcDUVxHm6W+9hIxFLanAQ z0JzXBTLG68o/c/cD9YfvQF0DIRijDAwTmDv98aTfUwBOVLXCr/R1QRhtJGXpRMhOZwq qjyQ== X-Gm-Message-State: AMke39l9qAvl4b+GiiOb9MApJvhKsyKOA9vKHlz97RgVrx/x5U21fH1Km+sfTA6OqUryqyXpwkghsWJH+aO53Q== X-Received: by 10.200.47.161 with SMTP id l30mr2575677qta.248.1488914274578; Tue, 07 Mar 2017 11:17:54 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.182.65 with HTTP; Tue, 7 Mar 2017 11:17:54 -0800 (PST) In-Reply-To: <9193d837-6a78-b1c4-42c0-427fbc1f2364@redhat.com> References: <148884284887.29188.7643544710695103939.stgit@brijesh-build-machine> <148884286883.29188.10103467162152106751.stgit@brijesh-build-machine> <9193d837-6a78-b1c4-42c0-427fbc1f2364@redhat.com> From: Brijesh Singh Date: Tue, 7 Mar 2017 13:17:54 -0600 Message-ID: To: Laszlo Ersek Cc: jordan.l.justen@intel.com, edk2-devel@ml01.01.org, Tom Lendacky , Leo Duran , brijesh.singh@amd.com X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [RFC PATCH v1 3/5] OvmfPkg/PlatformPei: Initialize SEV support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Mar 2017 19:17:55 -0000 Content-Type: text/plain; charset=UTF-8 On Tue, Mar 7, 2017 at 11:08 AM, Laszlo Ersek wrote: > On 03/07/17 00:27, Brijesh Singh wrote: > > Initialize Secure Encrypted Virtualization (SEV) support. > > > > Signed-off-by: Brijesh Singh > > --- > > OvmfPkg/PlatformPei/Platform.c | 6 ++++++ > > OvmfPkg/PlatformPei/PlatformPei.inf | 1 + > > 2 files changed, 7 insertions(+) > > > > diff --git a/OvmfPkg/PlatformPei/Platform.c b/OvmfPkg/PlatformPei/ > Platform.c > > index 0be8672..a948037 100644 > > --- a/OvmfPkg/PlatformPei/Platform.c > > +++ b/OvmfPkg/PlatformPei/Platform.c > > @@ -33,6 +33,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -669,5 +670,10 @@ InitializePlatform ( > > MiscInitialization (); > > InstallFeatureControlCallback (); > > > > + // > > + // Initialize SEV support > > + // > > + MemcryptSevInitialize (); > > + > > This will be called on both the normal boot path and the S3 resume boot > path. (Similarly to InstallFeatureControlCallback() above.) IIRC, you > did modify S3Resume2Pei to consider the PCD (and at that time we > discussed that setting the PCD here, in PlatformPei, would be > sufficiently early even for S3 resume). Thus, can you please confirm (in > the commit message) whether this works with S3 resume? > > I have not tested te S3 resume funcationlity, should have mentioned in my TODO list. I will test it before next rfc and update the commit messages accordingly. > > return EFI_SUCCESS; > > } > > diff --git a/OvmfPkg/PlatformPei/PlatformPei.inf b/OvmfPkg/PlatformPei/ > PlatformPei.inf > > index fbaed31..f85b208 100644 > > --- a/OvmfPkg/PlatformPei/PlatformPei.inf > > +++ b/OvmfPkg/PlatformPei/PlatformPei.inf > > @@ -60,6 +60,7 @@ > > QemuFwCfgLib > > MtrrLib > > PcdLib > > + MemcryptSevLib > > As noted before, I suggest to replace this new libclass (introduction > and dependency) simply with a new file here. > > Sure I will remove the dependency and create a new file in PlatformPei. > Thanks! > Laszlo > > > > > [Pcd] > > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfPeiMemFvBase > > > > -- Confusion is always the most honest response.