From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-x244.google.com (mail-qt0-x244.google.com [IPv6:2607:f8b0:400d:c0d::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7F73321A18AAC for ; Mon, 27 Mar 2017 11:40:29 -0700 (PDT) Received: by mail-qt0-x244.google.com with SMTP id r45so8890653qte.0 for ; Mon, 27 Mar 2017 11:40:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=HK7Mrs6sRfYDdg9bJnBU2rfdjxPCyRZbkSd9N3Ckbtk=; b=Z0hC032AcJrtpHINHUvSynf9X3AwqiMzo88E9lsVwnaUXZcoM+zC/r5ZVLcBiUTi4g mGt22BkgX+ABHimeiVvinby32j0AsIr4Ys2dhG0mZTc7dvOxI63Aks4zfuIjlpIdePp6 HZtm/cFCHybLANOuqG2uB7XH/9VcdUqEvGJTfyL/voxHebLqobsFIbpWf4HdW0CLTEMQ 0PcYL69eSSOJJY9m58k7Q3DK1RRk/Y+bhS7Hvpe4VHP0aYxVS2aKhN5Eh+sPwUVokiue n4jTgd0ep8srYob6SV2m0+qxFsxJAj/9jnvFHSC7GwQlry1GwpFI0BCf4cWf7/Yuz9jp vcfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=HK7Mrs6sRfYDdg9bJnBU2rfdjxPCyRZbkSd9N3Ckbtk=; b=Yj29JUMwclsAqzYPA28j+jmf3clPFzP7fe8G3aAQCYZ+0CVzhIVFlVF8/FXauB5NXx qGUSfts9gSybd/ewfEqOkwgGYb4uwpZFiHcnvddGrQp05BUHZNPJSjDnP5LJx2hPoedd sYATTuWl5VOYcsRa4voPuoRVeAteXdLgKr35Jhro0ugZxDf2J2CBaKUxMDQYO3Lg8OBA JXV/dTfqHtV6cPiiWO/QONl6niYYRumcZhKdlFVsARPiME3akn2rKd1gNUcQScKSL+/4 7ZHGFThIPR0Yu7KthISzdaSdn0bP7Q9ZOhZlgy1Ea4Lq+TepO/KHZDO6GgRLLUoBveLZ HlZw== X-Gm-Message-State: AFeK/H1RabY0eW3FZGF3xN+TxWeXFJ6G51jutzOxjHEo9J2bcIFkYefj5PTuSZkMf17D5Jj2XZSAuTYadZMFLw== X-Received: by 10.200.34.37 with SMTP id o34mr22293490qto.213.1490640028515; Mon, 27 Mar 2017 11:40:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.182.65 with HTTP; Mon, 27 Mar 2017 11:40:28 -0700 (PDT) In-Reply-To: References: <149013076154.27235.10725020825643505862.stgit@brijesh-build-machine> <149013079967.27235.18127368697377544049.stgit@brijesh-build-machine> From: Brijesh Singh Date: Mon, 27 Mar 2017 13:40:28 -0500 Message-ID: To: Laszlo Ersek Cc: "Kinney, Michael D" , "Justen, Jordan L" , edk2-devel@ml01.01.org, "Gao, Liming" , "Singh, Brijesh" , Leo Duran , Tom Lendacky X-Content-Filtered-By: Mailman/MimeDel 2.1.22 Subject: Re: [RFC PATCH v2 06/10] OvmfPkg/DxeBmDmaLib: Fix AllocateBounceBuffer parameter X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Mar 2017 18:40:29 -0000 Content-Type: text/plain; charset=UTF-8 On Mon, Mar 27, 2017 at 4:21 AM, Laszlo Ersek wrote: > On 03/21/17 22:13, Brijesh Singh wrote: > > The patch fixes AllocateBounceBuffer parameters. > > > > Signed-off-by: Brijesh Singh > > --- > > OvmfPkg/Library/DxeBmDmaLib/DxeBmDmaLib.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/OvmfPkg/Library/DxeBmDmaLib/DxeBmDmaLib.c > b/OvmfPkg/Library/DxeBmDmaLib/DxeBmDmaLib.c > > index a342c9e..0d960a8 100644 > > --- a/OvmfPkg/Library/DxeBmDmaLib/DxeBmDmaLib.c > > +++ b/OvmfPkg/Library/DxeBmDmaLib/DxeBmDmaLib.c > > @@ -192,8 +192,8 @@ BmDmaMap ( > > } > > > > return AllocateBounceBuffer ( > > - Operation, > > FORCE_BELOW_4GB_TRUE, > > + Operation, > > PhysicalAddress, > > NumberOfBytes, > > DeviceAddress, > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > > > > I'm not yet convinced that we should copy DxeBmDmaLib to OvmfPkg at all, > but even if we do, the argument order should be fixed in the original > first (under MdeModulePkg), and then copied to OvmfPkg. > > Like you said, BmDmaLib is not final and accepted solution in upstream. Jiewen submitted RFC to provide an alternative way of clearing the encryption bit mask. We will need to look at that approach as well. In this RFC, i was trying to show if BmDmaLib gets accepted then how SEV will make use of it.